Require two votes from dawn committers on each CL.
Bug: 356276603
Change-Id: I2d09ad040a9e8fe5c72593acb587bb1f7c4c807b
diff --git a/project.config b/project.config
index c52a0ad..0d0b684 100644
--- a/project.config
+++ b/project.config
@@ -23,8 +23,7 @@
forgeAuthor = group Registered Users
forgeCommitter = group Project Owners
forgeCommitter = group mdb/webgpu-dawn-admin
- label-Code-Review = -2..+2 group Project Owners
- label-Code-Review = -2..+2 group mdb/webgpu-dawn-admin
+ label-Code-Review = -2..+2 group cria/project-dawn-committers
label-Code-Review = -1..+1 group Registered Users
push = group Project Owners
push = group mdb/webgpu-dawn-admin
@@ -94,12 +93,14 @@
[plugin "jwtservice"]
audience = https://api.cr.dev
[submit-requirement "Code-Review"]
- description = At least one maximum vote for label 'Code-Review' is required
- submittableIf = label:Code-Review=MAX,user=non_uploader AND -label:Code-Review=MIN
+ description = If the author is a Dawn committer, code review is required from one other committer (see https://dawn.googlesource.com/dawn/+/HEAD/docs/becoming-committer.md). Otherwise, code review is required from two committers.
+ applicableIf = -branch:refs/meta/config
+ submittableIf = ((uploaderin:cria/project-dawn-committers AND label:Code-Review=MAX,user=non_uploader) OR label:Code-Review=MAX,count>=2) AND -label:Code-Review=MIN
overrideIf = label:Bot-Commit=+1 AND -label:Code-Review=MIN
- canOverrideInChildProjects = true
+ canOverrideInChildProjects = false
[submit-requirement "No-Unresolved-Comments"]
- description = Changes that have unresolved comments are not submittable. Unless overridden with "Unresolved-Comment-Reason: <reason>" line in change message.
- overrideIf = message:\"^.*Unresolved-Comment-Reason:.*\"
+ description = Changes that have unresolved comments are not submittable. Unless overridden with \"Unresolved-Comment-Reason: <reason>\" line in change message.
applicableIf = has:unresolved
- submittableIf = -has:unresolved
\ No newline at end of file
+ submittableIf = -has:unresolved
+ overrideIf = message:\"^.*Unresolved-Comment-Reason:.*\"
+ canOverrideInChildProjects = false
