)]}'
{
  "commit": "42e1bba480d1eebc9df9c39551711d3fd3d033aa",
  "tree": "31d620e21b4e546128626e121086f4d2319a9fec",
  "parents": [
    "ab8b768d27c4f0a38cf7f4650771f34c2b8d09c8"
  ],
  "author": {
    "name": "Austin Eng",
    "email": "enga@chromium.org",
    "time": "Thu Aug 08 22:41:00 2019 +0000"
  },
  "committer": {
    "name": "Commit Bot service account",
    "email": "commit-bot@chromium.org",
    "time": "Thu Aug 08 22:41:00 2019 +0000"
  },
  "message": "Revert \"Fix dynamic buffer offset issues on D3D12 backend\"\n\nThis reverts commit 421584173cae282ee496291b1cb08eebcad71be7.\n\nReason for revert: Some of the newly added tests are failing on Windows NVIDIA GTX 1660\n\nhttps://ci.chromium.org/p/chromium/builders/ci/Win10%20FYI%20x64%20Release%20%28NVIDIA%20GeForce%20GTX%201660%29/21\n\nOriginal change\u0027s description:\n\u003e Fix dynamic buffer offset issues on D3D12 backend\n\u003e \n\u003e This patch fixes\n\u003e 1. Inherit dynamic buffer offsets : dawn chooses vulkan\n\u003e like inherit behaviour, so dynamic offsets need to be inherited.\n\u003e This patch adds inherit dynamic offsets between pipelines support and\n\u003e adds tests to cover it.\n\u003e \n\u003e 2. Dynamic offsets are skipped when groups have been set : in D3D12\n\u003e backend, when invoke SetBindGroup, dawn will check whether this group\n\u003e has already been set and skip updating root signature if the answer is\n\u003e yes. However, this behaviour will affect dynamic offsets update. With\n\u003e the latest patch, we always update dynamic offsets, even if they didn\u0027t\n\u003e change and adds tests to cover it.\n\u003e \n\u003e This patch also hit a dawn\u0027s issue about storage buffer validation in compute pass.\n\u003e Currently the validation is a workaround to avoid access conflicts but will impact\n\u003e using dynamic buffer offset in compute pipeline. Fix this issue is hard so disable\n\u003e related test for now and will enable it after the issue been fixed. File dawn bug\n\u003e 198 to track this\n\u003e \n\u003e BUG\u003ddawn:55\n\u003e \n\u003e Change-Id: I2b0f179b3555d37d5b350292eb729767b0d60ab6\n\u003e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9621\n\u003e Commit-Queue: Austin Eng \u003cenga@chromium.org\u003e\n\u003e Reviewed-by: Austin Eng \u003cenga@chromium.org\u003e\n\u003e Reviewed-by: Kai Ninomiya \u003ckainino@chromium.org\u003e\n\nTBR\u003dkainino@chromium.org,shaobo.yan@intel.com,enga@chromium.org\n\n# Not skipping CQ checks because original CL landed \u003e 1 day ago.\n\nBug: dawn:55\nChange-Id: I018e6fa9b4b0905de602ab4ba3294ef537c53759\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/9900\nReviewed-by: Austin Eng \u003cenga@chromium.org\u003e\nCommit-Queue: Austin Eng \u003cenga@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "dc9d5f0ab2fd4cd21a3a8c78e2271b3e263eb3cb",
      "old_mode": 33188,
      "old_path": "src/dawn_native/d3d12/CommandBufferD3D12.cpp",
      "new_id": "e041f8c7744124c762c75e790266f3ee0c9b4b41",
      "new_mode": 33188,
      "new_path": "src/dawn_native/d3d12/CommandBufferD3D12.cpp"
    },
    {
      "type": "modify",
      "old_id": "6cbb3085c9d48994bbf28d2e684d72475e6d28c8",
      "old_mode": 33188,
      "old_path": "src/dawn_native/d3d12/PipelineLayoutD3D12.cpp",
      "new_id": "f5ae7c72ef02bf76d5ecbc48cf0d3c130ec269c5",
      "new_mode": 33188,
      "new_path": "src/dawn_native/d3d12/PipelineLayoutD3D12.cpp"
    },
    {
      "type": "modify",
      "old_id": "b2ee9e6bbdbab3105532b474f6f423eecb823520",
      "old_mode": 33188,
      "old_path": "src/dawn_native/d3d12/PipelineLayoutD3D12.h",
      "new_id": "2b8358caee968eb6ff953ab15f39f91816401f01",
      "new_mode": 33188,
      "new_path": "src/dawn_native/d3d12/PipelineLayoutD3D12.h"
    },
    {
      "type": "modify",
      "old_id": "46c888e35da0035a1e46cbc79d88e5be2aa58882",
      "old_mode": 33188,
      "old_path": "src/tests/end2end/DynamicBufferOffsetTests.cpp",
      "new_id": "f55b9e5b940d79fbbc91ead3af58292491e6c1e5",
      "new_mode": 33188,
      "new_path": "src/tests/end2end/DynamicBufferOffsetTests.cpp"
    }
  ]
}