)]}'
{
  "commit": "5f85f4f5c9d27cdeaee9e01c572784908ff676f0",
  "tree": "d3014398d085fe779b7f19b6b71e6690ce290d57",
  "parents": [
    "1455a56bf76540305a81a0b95300cd7fefd9b036"
  ],
  "author": {
    "name": "Ryan Harrison",
    "email": "rharrison@chromium.org",
    "time": "Mon Aug 18 14:04:16 2025 -0700"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Mon Aug 18 14:04:16 2025 -0700"
  },
  "message": "Cleanup lint issues with uses of testify in Go code\n\nRan testifylint (https://github.com/Antonboom/testifylint) over our\ntests to see what issues it would detect, since testify has some\ninconsistent APIs, e.g. .Equal(expect, real), but .Len(obj, count), so\nit is easy to get args reversed or miss a better function to use.\n\nIt found mostly minor things, like being able use .Len() instead of\n.Equal(..., len(foo)) or using .NoError() instead of .Nil() on errors,\nand a bunch of .Equal() calls that should be reversed.\n\nIt did get a number of things wrong that I had to revert, and missed a\nnumber potential cleanups (like specific cases it could be using\n.NoError() or .Len() even though it identified other cases in the same\nfile), so I don\u0027t think I would recommend us adding it to our\npresubmit or CI.\n\nIt is a useful tool for checking your code style, but I don\u0027t think it\nis good enough at this point to be blocking CLs or be run in an\nautomated fashion.\n\nChange-Id: Ib44412442af82cf3ab3bf04de7c4d68fabb1f2ca\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/257896\nCommit-Queue: Ryan Harrison \u003crharrison@chromium.org\u003e\nAuto-Submit: Ryan Harrison \u003crharrison@chromium.org\u003e\nReviewed-by: Brian Sheedy \u003cbsheedy@google.com\u003e\nCommit-Queue: Brian Sheedy \u003cbsheedy@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "69b40a5873058b1c5494a41d9e3f6a79d483679c",
      "old_mode": 33188,
      "old_path": "tools/src/auth/auth_test.go",
      "new_id": "702195ad2416e9cb62a0dc8aa12b25de870ecb26",
      "new_mode": 33188,
      "new_path": "tools/src/auth/auth_test.go"
    },
    {
      "type": "modify",
      "old_id": "660cd869ff52b1a26874ef384260fddf6ba38678",
      "old_mode": 33188,
      "old_path": "tools/src/cmd/cts/common/paths_test.go",
      "new_id": "a66e12b2cc004256965cecdcff108077a4814b04",
      "new_mode": 33188,
      "new_path": "tools/src/cmd/cts/common/paths_test.go"
    },
    {
      "type": "modify",
      "old_id": "97a8cd3581ceb5023c89effd8d68e963a7096cc8",
      "old_mode": 33188,
      "old_path": "tools/src/cmd/cts/common/results_test.go",
      "new_id": "11360773df88d15b0b5d4d8408f145d0784289ba",
      "new_mode": 33188,
      "new_path": "tools/src/cmd/cts/common/results_test.go"
    },
    {
      "type": "modify",
      "old_id": "3a1af3545701401911033b66d1ab855e64ba87ca",
      "old_mode": 33188,
      "old_path": "tools/src/cmd/cts/expectationcoverage/expectationcoverage_test.go",
      "new_id": "96c9cdbbe10ed1ddf5e1eb5abec6be3ea27860d6",
      "new_mode": 33188,
      "new_path": "tools/src/cmd/cts/expectationcoverage/expectationcoverage_test.go"
    },
    {
      "type": "modify",
      "old_id": "7d8ec6b04e6076e2fcfd1dac1de69ecf3bca850f",
      "old_mode": 33188,
      "old_path": "tools/src/cmd/gen/build/build_test.go",
      "new_id": "70c550e5130b4c8605e34f2699145b4e1761c82a",
      "new_mode": 33188,
      "new_path": "tools/src/cmd/gen/build/build_test.go"
    },
    {
      "type": "modify",
      "old_id": "533c9341a3ee697d40e85c76289754027d090e92",
      "old_mode": 33188,
      "old_path": "tools/src/cmd/run-cts/common/flags_test.go",
      "new_id": "87d9d3afb2d70944a80ad0692f1aa064983b7cf3",
      "new_mode": 33188,
      "new_path": "tools/src/cmd/run-cts/common/flags_test.go"
    },
    {
      "type": "modify",
      "old_id": "ce22b9a3e4ea9edfed61f651f44d996f0a30505d",
      "old_mode": 33188,
      "old_path": "tools/src/cts/expectations/expectations_test.go",
      "new_id": "bd9180e23fe6e8ae0807f549b95029aa6268dbdc",
      "new_mode": 33188,
      "new_path": "tools/src/cts/expectations/expectations_test.go"
    },
    {
      "type": "modify",
      "old_id": "910b7b814140561c97a1fba05c771c16a96d47f0",
      "old_mode": 33188,
      "old_path": "tools/src/glob/glob_test.go",
      "new_id": "7ca20a498d68cba230cc2c3ec63f815a39db21ac",
      "new_mode": 33188,
      "new_path": "tools/src/glob/glob_test.go"
    },
    {
      "type": "modify",
      "old_id": "72b68312a6a36100262d651a04b0bf80c6b24f53",
      "old_mode": 33188,
      "old_path": "tools/src/oswrapper/fstestoswrapper_test.go",
      "new_id": "86169fa33ec2ec37ae3bf3739db6602f53efb6a3",
      "new_mode": 33188,
      "new_path": "tools/src/oswrapper/fstestoswrapper_test.go"
    },
    {
      "type": "modify",
      "old_id": "8b8e4e8dc4f4afaf68feff0ecb7936d3b44cf0d2",
      "old_mode": 33188,
      "old_path": "tools/src/oswrapper/memmaposwrapper_test.go",
      "new_id": "8b93d1d3bf2863f5fba7bd1e8db7ff0728e9a1ca",
      "new_mode": 33188,
      "new_path": "tools/src/oswrapper/memmaposwrapper_test.go"
    },
    {
      "type": "modify",
      "old_id": "8553354c045d0fcce48d39f4f8f064fb5501c9f3",
      "old_mode": 33188,
      "old_path": "tools/src/reducedglob/reducedglob_test.go",
      "new_id": "02c3c4da989776cfc9558d5036710de0c1dc6ae9",
      "new_mode": 33188,
      "new_path": "tools/src/reducedglob/reducedglob_test.go"
    }
  ]
}
