commit d59fec5d706eb7ff403e83ae69ed999a3c13f6df
author Li, Hao <hao.x.li@intel.com> Tue Oct 15 01:42:45 2019 +0000
committer Commit Bot service account <commit-bot@chromium.org> Tue Oct 15 01:42:45 2019 +0000
tree d0022502667d3563e9c333a5ee26d82cd35d8117
parent 91fbfc34e839a319b4e451f38c74365df1318562

Skip LargeBufferFails test with NVIDIA for enabling Vulkan validation layers on Windows

Fails on NVIDIA cards when Vulkan validation layers are enabled becuase the maximum size of a single allocation cannot be larger than or equal to 4G on some platforms.

BUG=dawn:241

Change-Id: I863a2219287d3d363b3013027ba8fc9df846b42d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/12141
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Hao Li <hao.x.li@intel.com>

src/tests/end2end/BufferTests.cpp

diff --git a/src/tests/end2end/BufferTests.cpp b/src/tests/end2end/BufferTests.cpp
index 2b0f10b..98f2387 100644
--- a/src/tests/end2end/BufferTests.cpp
+++ b/src/tests/end2end/BufferTests.cpp
@@ -635,6 +635,11 @@
     // TODO(http://crbug.com/dawn/27): Missing support.
     DAWN_SKIP_TEST_IF(IsMetal() || IsOpenGL());
 
+    // TODO(http://crbug.com/dawn/241): Fails on NVIDIA cards when Vulkan validation layers are
+    // enabled becuase the maximum size of a single allocation cannot be larger than or equal to
+    // 4G on some platforms.
+    DAWN_SKIP_TEST_IF(IsVulkan() && IsNvidia() && IsBackendValidationEnabled());
+
     dawn::BufferDescriptor descriptor;
     descriptor.size = std::numeric_limits<uint64_t>::max();
     descriptor.usage = dawn::BufferUsage::MapRead | dawn::BufferUsage::CopyDst;