)]}'
{
  "commit": "07510d97314fd5b2bdcaba2a337c4fff3d26efa7",
  "tree": "28b632324037cb56709c4af3d10b057d372d44e7",
  "parents": [
    "3838767c35e97fdf4b6b4ae3e7d066beedb20111"
  ],
  "author": {
    "name": "Zhaoming Jiang",
    "email": "zhaoming.jiang@microsoft.com",
    "time": "Mon Apr 07 07:36:42 2025 -0700"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Mon Apr 07 07:36:42 2025 -0700"
  },
  "message": "Dawn: Make shader creation parse shader code after checking cache\n\nThis CL make shader code validation and parsing only happens after\nshader module cache missed, to prevent unnecessary overhead. This CL\nalso split the non-shader-code validation from shader-code validation\nwithin ValidateAndParseShaderModule, and remove the\nInjectCompilationMessages (now compilation messages are moved into\nshader modules during InitializeBase or MakeError).\n\nIssue: 42242185\nChange-Id: I192bf55a2f3b5784972a3e25e98452543c6afe67\nSkip-Clang-Tidy-Checks: modernize-use-std-format\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/231034\nReviewed-by: Geoff Lang \u003cgeofflang@chromium.org\u003e\nReviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\nCommit-Queue: Zhaoming Jiang \u003czhaoming.jiang@microsoft.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "2f35a8f2914fdc922d8179a31e916ea15bd6c33c",
      "old_mode": 33188,
      "old_path": "src/dawn/native/Device.cpp",
      "new_id": "b2a0410cda87fcd87510057741c0408a1c21a2ce",
      "new_mode": 33188,
      "new_path": "src/dawn/native/Device.cpp"
    },
    {
      "type": "modify",
      "old_id": "ba8e185d3dcfea9236ed8e483c4e99f8cef8e5cb",
      "old_mode": 33188,
      "old_path": "src/dawn/native/Device.h",
      "new_id": "e4c7f24be055ab5bc089a02b7f6f7251b7376dd5",
      "new_mode": 33188,
      "new_path": "src/dawn/native/Device.h"
    },
    {
      "type": "modify",
      "old_id": "94e04d7030702cf3251cbb571c15c15344de40e3",
      "old_mode": 33188,
      "old_path": "src/dawn/native/ShaderModule.cpp",
      "new_id": "bb2cb4906b85ae59b300faf9cb07dbb39a561a99",
      "new_mode": 33188,
      "new_path": "src/dawn/native/ShaderModule.cpp"
    },
    {
      "type": "modify",
      "old_id": "c9ad6b554ea81c4e2e639c67f05952fb068009d1",
      "old_mode": 33188,
      "old_path": "src/dawn/native/ShaderModule.h",
      "new_id": "4cedbd2f6a62f41ca2d46e821e27d42b6f10e513",
      "new_mode": 33188,
      "new_path": "src/dawn/native/ShaderModule.h"
    },
    {
      "type": "modify",
      "old_id": "e913305bcc4bd2909e8e207c5e0a23fcca5df22b",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d11/DeviceD3D11.cpp",
      "new_id": "806cf7834f03c12d8fb660a46860db6545abcc6f",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d11/DeviceD3D11.cpp"
    },
    {
      "type": "modify",
      "old_id": "935f4ac994028c72ec3321f271af000e7993b67c",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d11/DeviceD3D11.h",
      "new_id": "a0a91e2cc77f154571cba8e4dca3cd361421b20d",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d11/DeviceD3D11.h"
    },
    {
      "type": "modify",
      "old_id": "575c1a4893dba45f2b6750750f5129b742c77dc4",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d11/ShaderModuleD3D11.cpp",
      "new_id": "fd49b2f46b6ac4fdc48c9205315f82901a17308f",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d11/ShaderModuleD3D11.cpp"
    },
    {
      "type": "modify",
      "old_id": "a99f963f605e2ab9ec1412a317d33b89fa39d97b",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d11/ShaderModuleD3D11.h",
      "new_id": "30ee9f3df466117ba53da3fe93c399e976c4498d",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d11/ShaderModuleD3D11.h"
    },
    {
      "type": "modify",
      "old_id": "7d436cc2f325b4b5fb57c43917ef7aa20e28a8eb",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d12/DeviceD3D12.cpp",
      "new_id": "5cace31886e02c86415d260a8d2e7818099ef8cd",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d12/DeviceD3D12.cpp"
    },
    {
      "type": "modify",
      "old_id": "1df4aac897fee1d82e41871be065f98158398bfd",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d12/DeviceD3D12.h",
      "new_id": "d672711456a19c7de89487fdf291a29c2cc35749",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d12/DeviceD3D12.h"
    },
    {
      "type": "modify",
      "old_id": "67dac1b04246d9a934265ed3f024edd95293da90",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d12/ShaderModuleD3D12.cpp",
      "new_id": "f714db312da1300d270a1a54ad11fd0a739f3ed1",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d12/ShaderModuleD3D12.cpp"
    },
    {
      "type": "modify",
      "old_id": "cab1dd0063bb34c1d3c1d663fdfb9382ef407e01",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d12/ShaderModuleD3D12.h",
      "new_id": "aefebd94ef725591923b7f51c7cccf5d60953c1d",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d12/ShaderModuleD3D12.h"
    },
    {
      "type": "modify",
      "old_id": "3418ff33f5e1919a1ed51f7fde3e25167d789ae7",
      "old_mode": 33188,
      "old_path": "src/dawn/native/metal/DeviceMTL.h",
      "new_id": "5c1b377cb7df02fe805e29afe2c8000a96ce36c5",
      "new_mode": 33188,
      "new_path": "src/dawn/native/metal/DeviceMTL.h"
    },
    {
      "type": "modify",
      "old_id": "b6b5f9523b21039fefbf1d76a9f8515102910670",
      "old_mode": 33188,
      "old_path": "src/dawn/native/metal/DeviceMTL.mm",
      "new_id": "666481649c7f83df51b368538fc841f7dc242a96",
      "new_mode": 33188,
      "new_path": "src/dawn/native/metal/DeviceMTL.mm"
    },
    {
      "type": "modify",
      "old_id": "fbb0ebf8c4550bc9334d5f3ff0b51f917d79d3da",
      "old_mode": 33188,
      "old_path": "src/dawn/native/metal/ShaderModuleMTL.h",
      "new_id": "61f5c185bf4c3d590b6bdabbadf455078537cd70",
      "new_mode": 33188,
      "new_path": "src/dawn/native/metal/ShaderModuleMTL.h"
    },
    {
      "type": "modify",
      "old_id": "c37f2f6371b9ecfe1274c4606b28a4782b520950",
      "old_mode": 33188,
      "old_path": "src/dawn/native/metal/ShaderModuleMTL.mm",
      "new_id": "2b114ef086c5f167ea6ff449b6f6565d9f782a45",
      "new_mode": 33188,
      "new_path": "src/dawn/native/metal/ShaderModuleMTL.mm"
    },
    {
      "type": "modify",
      "old_id": "3b189b988f5f4534a5c857a251971b5e73fd8d10",
      "old_mode": 33188,
      "old_path": "src/dawn/native/null/DeviceNull.cpp",
      "new_id": "d455b992a26ce0e7716656faaf9122c6447c4598",
      "new_mode": 33188,
      "new_path": "src/dawn/native/null/DeviceNull.cpp"
    },
    {
      "type": "modify",
      "old_id": "aceba4f7d62cbb577b366c96f6f9690f6a1cae85",
      "old_mode": 33188,
      "old_path": "src/dawn/native/null/DeviceNull.h",
      "new_id": "0946d3103485a6b61fe5ed804f9e06720c75d214",
      "new_mode": 33188,
      "new_path": "src/dawn/native/null/DeviceNull.h"
    },
    {
      "type": "modify",
      "old_id": "3ec7956e9bf748929fad8190f0a0b4e6b23386ce",
      "old_mode": 33188,
      "old_path": "src/dawn/native/opengl/DeviceGL.cpp",
      "new_id": "651298438a18c81789fdc49e163616a54e55f02b",
      "new_mode": 33188,
      "new_path": "src/dawn/native/opengl/DeviceGL.cpp"
    },
    {
      "type": "modify",
      "old_id": "c2f51e72fa48d67457811555a030891af191dad6",
      "old_mode": 33188,
      "old_path": "src/dawn/native/opengl/DeviceGL.h",
      "new_id": "db7ccde7fe4578fa257418d5bffa8ec00aa5eec5",
      "new_mode": 33188,
      "new_path": "src/dawn/native/opengl/DeviceGL.h"
    },
    {
      "type": "modify",
      "old_id": "9d95e8f4a0c3d81f8cbfcc39f663dab3b1457c02",
      "old_mode": 33188,
      "old_path": "src/dawn/native/opengl/ShaderModuleGL.cpp",
      "new_id": "78669352e42609b0c9ba87158f7c24cff1204930",
      "new_mode": 33188,
      "new_path": "src/dawn/native/opengl/ShaderModuleGL.cpp"
    },
    {
      "type": "modify",
      "old_id": "76fda307f43dcddaf58f88b1cae78dd184ab93d0",
      "old_mode": 33188,
      "old_path": "src/dawn/native/opengl/ShaderModuleGL.h",
      "new_id": "0d724f893ba3e6f109adf419c37e4d2cf44ac386",
      "new_mode": 33188,
      "new_path": "src/dawn/native/opengl/ShaderModuleGL.h"
    },
    {
      "type": "modify",
      "old_id": "1d17f523ea04d52882131f9d28fc81f0f14a0c80",
      "old_mode": 33188,
      "old_path": "src/dawn/native/utils/WGPUHelpers.cpp",
      "new_id": "5fb33534d716f7cad27c4ff21a563f5cb72ae4c3",
      "new_mode": 33188,
      "new_path": "src/dawn/native/utils/WGPUHelpers.cpp"
    },
    {
      "type": "modify",
      "old_id": "54995300b6e7a1b5c600a811619d957cafdbc379",
      "old_mode": 33188,
      "old_path": "src/dawn/native/vulkan/DeviceVk.cpp",
      "new_id": "ab4b68a8e33fee595a5914002c076784b5b9179d",
      "new_mode": 33188,
      "new_path": "src/dawn/native/vulkan/DeviceVk.cpp"
    },
    {
      "type": "modify",
      "old_id": "5b9c0bc3c61529fe3dfd69fd7b305028467a67d3",
      "old_mode": 33188,
      "old_path": "src/dawn/native/vulkan/DeviceVk.h",
      "new_id": "99e43dc97978217a24e35aa1a0492dc736d61607",
      "new_mode": 33188,
      "new_path": "src/dawn/native/vulkan/DeviceVk.h"
    },
    {
      "type": "modify",
      "old_id": "2990a52812117daeaabb9f92b2fb0d87ed0113d7",
      "old_mode": 33188,
      "old_path": "src/dawn/native/vulkan/ShaderModuleVk.cpp",
      "new_id": "2c36f8f60719b91652ddaf92abcf556f425f97a1",
      "new_mode": 33188,
      "new_path": "src/dawn/native/vulkan/ShaderModuleVk.cpp"
    },
    {
      "type": "modify",
      "old_id": "50c608470891cdc08a7054a053f8139e16d1e013",
      "old_mode": 33188,
      "old_path": "src/dawn/native/vulkan/ShaderModuleVk.h",
      "new_id": "0ee0766b15e3114ba665ff0a6453f40ac1bd4c8d",
      "new_mode": 33188,
      "new_path": "src/dawn/native/vulkan/ShaderModuleVk.h"
    },
    {
      "type": "modify",
      "old_id": "c9488b5c3ebdb5347e2fbc5f5eb1d21bcdecc03c",
      "old_mode": 33188,
      "old_path": "src/dawn/tests/unittests/native/mocks/DeviceMock.h",
      "new_id": "27bc5ae4bd536782bb4ca7b0a81cae99549106b8",
      "new_mode": 33188,
      "new_path": "src/dawn/tests/unittests/native/mocks/DeviceMock.h"
    },
    {
      "type": "modify",
      "old_id": "8c89a53e5217139f6f31ccce18681bdac47f79b3",
      "old_mode": 33188,
      "old_path": "src/dawn/tests/unittests/native/mocks/ShaderModuleMock.cpp",
      "new_id": "574f738bc97accda0dfa116c89a1ea367a0c1a27",
      "new_mode": 33188,
      "new_path": "src/dawn/tests/unittests/native/mocks/ShaderModuleMock.cpp"
    }
  ]
}