)]}' { "commit": "098fd8d2225013faec7bfaa3bccd2022a19cb19f", "tree": "f66bb1b021abfb213141ee32daf5d674efeea295", "parents": [ "fb2013b709fad7e2d44435947b94a6d56096d417" ], "author": { "name": "Lokbondo Kung", "email": "lokokung@google.com", "time": "Fri Sep 25 16:28:36 2026 -0700" }, "committer": { "name": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com", "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Sep 25 16:28:36 2026 -0700" }, "message": "[utils] Fixes death test conditions and macros.\n\nIn https://dawn-review.git.corp.google.com/c/dawn/+/339076, when\ntrying to get partition_alloc death tests working for RawSpan,\nI unconditionally imported:\n //build/config/sanitizers/sanitizers.gni\nBy importing that config, the use_fuzzing_engine flag was flipped\nto \"true\" when the gn arg use_libfuzzer was set to \"true\". (This\nhappens in the clusterfuzz CI bot linked in the bug.) This\ncaused all the compilation flags of:\n DAWN_ENABLE_ASSERTS\n DAWN_ABORT_ON_ASSERT\n DAWN_DISABLE_LOGGING\nto be set at compilation time. At the same time, that CI bot\nactually sets is_debug \u003d false, which meant that the\nDAWN_EXPECT_DEBUG_DEATH_IF_SUPPORTED macro assumed the test should\nnot crash, when in reality it does because DAWN_ENABLE_ASSERT\nis the real flag that decides whether we crash or not and it\nwas set because use_fuzzing_engine was true.\n\nThis change does two main things:\n 1) Fix the condition in utils/BUILD.gn such that we only set\n DAWN_ENABLE_ASSERTS w.r.t use_fuzzing_engine when we are\n building as a part of Chromium. This reverts the behavior\n of the tests to be the same as before the change above.\n Specifically, that the standalone clusterfuzz build does\n not build with asserts enabled since standalone builds\n depend on the is_debug flag to determine whether they\n should be enabled.\n 2) Updates the test macros in utils/gtest.h to more\n explicitly handle the different cases appropriately so that\n tests don\u0027t need to handle them with ifdefs. This includes:\n - Adding DAWN_EXPECT_DEATH_IF_SUPPORTED macros that\n automatically suppresses string matching on the error\n\t logs when DAWN_DISABLE_LOGGING in enabled.\n - Update DAWN_*_DEBUG_DEATH_IF_SUPPORTED macros to check\n both if we are in debug mode, or if DAWN_ENABLE_ASSERTS\n\t is explicitly enabled.\n - Update PRESUBMIT.py to prevent Dawn code from using the\n gtest native macros, and instead make tests use the Dawn\n\t ones that handle the different compilation defines\n\t appropriately.\n - Update existing test code to use the new macros.\n\nBug: 564917473\nChange-Id: Ia3e5cc597d9bcc7288cc3d66f16ce136d2f7db63\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/344475\nReviewed-by: Kai Ninomiya \u003ckainino@chromium.org\u003e\nCommit-Queue: Loko Kung \u003clokokung@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "381e6c656fe86b8e39627d13280a98fa6b6feb97", "old_mode": 33188, "old_path": "PRESUBMIT.py", "new_id": "40dbe335db3aaae8d7ceb7143631c9e3cdab7369", "new_mode": 33188, "new_path": "PRESUBMIT.py" }, { "type": "modify", "old_id": "d95bd0cad586bab3c418a052794b7b81773eda2f", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/CommandAllocatorTests.cpp", "new_id": "9996db94cad5c0df6abb8bf4906cff8e80d19f08", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/CommandAllocatorTests.cpp" }, { "type": "modify", "old_id": "a51f6d3a187ec29ebdb6b9a46338f174ff61fee6", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/ITypArrayTests.cpp", "new_id": "6495be38ad79a7762793a219225a2ec87bfb3e78", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/ITypArrayTests.cpp" }, { "type": "modify", "old_id": "484fb91118ec0034954a7dc0f9c727b1e14628ea", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/ITypBitsetTests.cpp", "new_id": "b5e6bd9a53474e2bc9f7becbeb35c5e9c26a6593", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/ITypBitsetTests.cpp" }, { "type": "modify", "old_id": "3dbed0f99c3ffd2c8a95e3aa38b99d4593bae3c2", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/ITypStackVecTests.cpp", "new_id": "a7182b88a5630a4b83a90abb1ad9461b9f6a1ca8", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/ITypStackVecTests.cpp" }, { "type": "modify", "old_id": "b413172cc7bc90d032921c9e7dc610850c1f2f13", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/ITypVectorTests.cpp", "new_id": "642323905ea4965f729e1ccedba0ed8867ce0f2c", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/ITypVectorTests.cpp" }, { "type": "modify", "old_id": "ee6f5bc12ad673545c7a5a3959c27a57e3ca63f2", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/MutexTests.cpp", "new_id": "67d14c82ef2a533a3a1e5123538cd7a3323cfdac", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/MutexTests.cpp" }, { "type": "modify", "old_id": "d781fb85739a48067454afd8a57f3291f1a392ba", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/RawPtrTests.cpp", "new_id": "16d9462a3eb78aa91071d433a861d4504df15e0b", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/RawPtrTests.cpp" }, { "type": "modify", "old_id": "f869f3c4d88cd17144a5f97e43a0c5e5ac613af7", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/SlabAllocatorTests.cpp", "new_id": "e197bea6bbe5c563f4329531083a752f2eab218f", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/SlabAllocatorTests.cpp" }, { "type": "modify", "old_id": "ed6e968ad92f2ec4db72e87374e0ddd925b96098", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/wire/WireConfusionDeathTests.cpp", "new_id": "4b9b25d3db2f5e827cd8133eda668ae455a848c0", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/wire/WireConfusionDeathTests.cpp" }, { "type": "modify", "old_id": "3be3c106396cbb29a5903ed5fb71333c6341c85a", "old_mode": 33188, "old_path": "src/utils/BUILD.gn", "new_id": "bdb1f213cc206d7b8b710449882d08dd782a7270", "new_mode": 33188, "new_path": "src/utils/BUILD.gn" }, { "type": "modify", "old_id": "fcdd9ce9dd3e24a7c06017bd619c70921532fe1d", "old_mode": 33188, "old_path": "src/utils/assert_test.cc", "new_id": "1883a5cd25d9de44b49988eabb70762844c25290", "new_mode": 33188, "new_path": "src/utils/assert_test.cc" }, { "type": "modify", "old_id": "b4c4f0e7024a93e2d9c59de2aad05dcaa1a58acb", "old_mode": 33188, "old_path": "src/utils/gtest.h", "new_id": "875a591ff32357bf10d0d2004099955b3c31b5b0", "new_mode": 33188, "new_path": "src/utils/gtest.h" }, { "type": "modify", "old_id": "51eedcf7868961a5d9110f43deaa0dff7d730ed6", "old_mode": 33188, "old_path": "src/utils/heap_array_test.cc", "new_id": "0f27b3a09f3e4c5f85cd7febca29a9dbbfdc8dcc", "new_mode": 33188, "new_path": "src/utils/heap_array_test.cc" }, { "type": "modify", "old_id": "a343e51eba89482365607901d67d98c49b91e0d6", "old_mode": 33188, "old_path": "src/utils/numeric_test.cc", "new_id": "1d9c8dc66d23cd7d6575d74591fa093459504f83", "new_mode": 33188, "new_path": "src/utils/numeric_test.cc" }, { "type": "modify", "old_id": "44f8eb9e36db919b53fd3219cd332105c92a9f9d", "old_mode": 33188, "old_path": "src/utils/raw_span_tests.cc", "new_id": "232eee0d5087586065fe4ae212c3023f734421e9", "new_mode": 33188, "new_path": "src/utils/raw_span_tests.cc" }, { "type": "modify", "old_id": "b9d91c68c166136be914cd2df524f0253a0b1ee4", "old_mode": 33188, "old_path": "src/utils/span_tests.cc", "new_id": "a8e01fed4a721218d68c6fc801cbef8537f73daa", "new_mode": 33188, "new_path": "src/utils/span_tests.cc" } ] }