)]}' { "commit": "0c227e21d110bd77779f9e6605a65a4fa08c3c1b", "tree": "1b926648ffb4b542cf6432129cbe7d43d082f6b4", "parents": [ "c33a8c188526757501286c64466cc5f19a66b400" ], "author": { "name": "Yunchao He", "email": "yunchao.he@intel.com", "time": "Fri Apr 12 07:58:44 2019 +0000" }, "committer": { "name": "Commit Bot service account", "email": "commit-bot@chromium.org", "time": "Fri Apr 12 07:58:44 2019 +0000" }, "message": "baseVertex in drawIndexed() should be int32, not uint32\n\nbaseVertex in drawIndexed() is int32 in web idl. But it is uint32 in Dawn\nproject. I also checked the native Graphics API sets. baseVertex is int32\non all native APIs (D3D12, Vulkan, Metal). So this feature in web idl is\ndefinitely correct.\n\nThis small change makes dawn match web idl for this feature. And it also\nadds a couple of tests to cover negative baseVertex.\n\nBUG\u003ddawn:135\nTEST\u003ddawn_end2end_tests\n\nChange-Id: I642c96faed9103c8392979f3714527ed0aac4089\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6442\nReviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\nCommit-Queue: Corentin Wallez \u003ccwallez@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "7528d461dceddb49baea1e938ea4043e41118002", "old_mode": 33188, "old_path": "dawn.json", "new_id": "d1c321fecc9015fbe63acf59e4f8343188e6cbed", "new_mode": 33188, "new_path": "dawn.json" }, { "type": "modify", "old_id": "091547c69e89d778b37cfedc74846c59ac8739c5", "old_mode": 33188, "old_path": "src/dawn_native/Commands.h", "new_id": "26e0b682ab2bb0cc78e2048cbf037daf9c5037f0", "new_mode": 33188, "new_path": "src/dawn_native/Commands.h" }, { "type": "modify", "old_id": "9288c6a81d0fd4b8309b19f10b3d30f56c350ae3", "old_mode": 33188, "old_path": "src/dawn_native/RenderPassEncoder.cpp", "new_id": "74700634877103462e6c48acfbd1ad81ee6841f6", "new_mode": 33188, "new_path": "src/dawn_native/RenderPassEncoder.cpp" }, { "type": "modify", "old_id": "ccc776fb1a59baa0ef284b58af4f4580417de8cf", "old_mode": 33188, "old_path": "src/dawn_native/RenderPassEncoder.h", "new_id": "7e8243e26f9c8e870f32a5c21648e06868021c51", "new_mode": 33188, "new_path": "src/dawn_native/RenderPassEncoder.h" }, { "type": "modify", "old_id": "c1b889e82ad54c2d0d15ec6f43bd05eff33500e7", "old_mode": 33188, "old_path": "src/tests/end2end/DrawIndexedTests.cpp", "new_id": "02421c7a6b45401b08d1674e286846de4c3c61d5", "new_mode": 33188, "new_path": "src/tests/end2end/DrawIndexedTests.cpp" } ] }