)]}'
{
  "commit": "10ec4ee7efb3c0fd10bdb7191da77cdd6d063ea9",
  "tree": "64357143f0e4412c28457c3327ddb4bcb2cd554f",
  "parents": [
    "600c97af810d04ffbd4b27b221948bec2a728052"
  ],
  "author": {
    "name": "Austin Eng",
    "email": "enga@chromium.org",
    "time": "Thu Mar 31 01:26:49 2022 +0000"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Thu Mar 31 01:26:49 2022 +0000"
  },
  "message": "Disallow creating a 2D-array view on a multisampled texture\n\nSpec issue: https://github.com/gpuweb/gpuweb/issues/2715\nSpec PR: https://github.com/gpuweb/gpuweb/pull/2716\n\nThis is invalid in the Metal API because MTLTextureType2DArray is\nimcompatible with MTLTextureType2DMultisample, even if the layer\ncount is 1.\n\nMTLTextureType2DMultisampleArray is not supported until macOS 10.14\nand iOS 14.0.\n\nFurther, the view type must match between the API and the shader.\na 2D view array requires texture2d_array in MSL.\nIt would be inconsistent to allow 1-layer 2D arrays which internally\nget translated as (non-array) MTLTextureType2DMultisample. You would\nexpect to need to use texture2d_ms_array in the shader.\n\nChange-Id: Ib9268c1276d3d31e90d6c61118e27fa2afd0617d\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85200\nReviewed-by: Loko Kung \u003clokokung@google.com\u003e\nCommit-Queue: Austin Eng \u003cenga@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "c7664363d80e03f5aab90f5a5ed88a48d57d13e3",
      "old_mode": 33188,
      "old_path": "src/dawn/native/Texture.cpp",
      "new_id": "0e64f62486f24e3c01afeb17ed8229c6fff35d99",
      "new_mode": 33188,
      "new_path": "src/dawn/native/Texture.cpp"
    },
    {
      "type": "modify",
      "old_id": "0ad7f62dc350db35301644c26bca2b70ab72205c",
      "old_mode": 33188,
      "old_path": "src/dawn/tests/end2end/MultisampledRenderingTests.cpp",
      "new_id": "5c00237be1261cc71a5d8d757ecb4376c5563e82",
      "new_mode": 33188,
      "new_path": "src/dawn/tests/end2end/MultisampledRenderingTests.cpp"
    },
    {
      "type": "modify",
      "old_id": "f56243ddc3612bada1ef3bec4f83a772c6b98580",
      "old_mode": 33188,
      "old_path": "src/dawn/tests/unittests/validation/TextureViewValidationTests.cpp",
      "new_id": "b10973038cb34ecc49954bf0ad51d190654b2745",
      "new_mode": 33188,
      "new_path": "src/dawn/tests/unittests/validation/TextureViewValidationTests.cpp"
    }
  ]
}