tree 7de3ec24653f285ce9941149ce61c3a74e1d05b6
parent 48886872a28bae958e1f9cd5b85de52b6cabcf23
author Brandon Jones <bajones@chromium.org> 1751485881 -0700
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1751485881 -0700

Cache VkFramebuffers (reland)

Creation of VkFramebuffers is more expensive than expected on mobile
devices, so this introduces a framebuffer cache to reduce that
overhead.

Previous attempt at landing was reverted after crashes reported in
https://crbug.com/425093010, which seem limited to devices with Samsung
Xclipse GPUs (AMD-based).

Discovered that the likely reason for the crashes was that Vulkan may
reuse handle values for things like image views, making them
inappropriate for use as cache keys, as I was doing previously.
Refactored this CL to use explicit unique IDs instead, which resolved
the problems on the hardware I tested against.

Bug: 416088623
Change-Id: I3fcbf374d530ecc2be0db87ee70d781e1b249699
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/249354
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>