tree 6a73969831703bc0e6f7278875645b4035f9b8e7
parent 2817c2b745ffb971bee36bc006a37dfce07c64b1
author Stephen White <senorblanco@chromium.org> 1707150585 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1707150585 +0000

GLSL: move the AddBlockAttribute transform before OffsetFirstIndex.

This will allow OffsetFirstIndex to play nice with existing
push constants in the future.

Since this also moves AddBlockAttribute before PadStructs, it also
causes any non-struct variables in host-visible address space
to have tail-padding added. This is a bit noisy, but harmless.
(Struct variables in host-visible address space were already
getting tail padding.)

Also change PadStruct to copy any existing attributes in order to
prevent the BlockAttribute from being stripped on padding.

Bug: dawn:2185
Change-Id: Ic2849c8e383b7ce89edbc7f7c60fc7cca2cd2b84
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/172180
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>