)]}'
{
  "commit": "1c70866fbfb047ec5f606e4b06d205e8bd2e6a9e",
  "tree": "77e3d1f4f7ba8f1147b816fe2e64b9a537cc16c9",
  "parents": [
    "66bf143b8ac648b928248d97a7dd845ae655937c"
  ],
  "author": {
    "name": "Gregg Tavares",
    "email": "gman@chromium.org",
    "time": "Mon Mar 31 11:24:43 2025 -0700"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Mon Mar 31 11:24:43 2025 -0700"
  },
  "message": "Compat: unlower limits\n\nBecause we excluded Mali-T624,T628,T720 we can make the\nlower limit of maxStorageBuffersPerShaderStage be 8,\nmaxStorageBuffersInFragmentShaders be 4,\nand maxStorageTexturesInFragmentShaders be 4\n\nI removed 2 tests because AFAICT they are hard to fix AND, they\nare tested in the CTS so they\u0027ll still be tested.\n\nThe issue is the tests were testing that, in compat, when\nmaxStorageTexturesInFragmentStage is less than\nmaxStorageTexturesPerShaderStage and you try to use\nmore than maxStorageTexturesInFragmentStage you get an\nerror. This only happens in compat because in core the\n2 limits are always the max of the 2.\n\nWith the change so that maxStorageTextureInFragmentStage\nis 4 it\u0027s not, by default, lower than maxStorageTexturesPerShaderStage\nwhich is also 4.\n\nThe testing infra for the dawn_unittests doesn\u0027t appear to\nhave any easy way to change this. To test you\u0027d need some way\nto tell dawn to return an adapter with maxStorageTexturesPerShaderStage\ngreater than 4. Setting that all up seems like a waste of time given\nthe CTS can and does test this already.\n\nIf it is important it can be done in a different CL.\n\nNote: tested this with a CTS that expects the new limits.\nNote: this will have to wait for a CTS roll or suppressions\nadded to expectations.\n\nBug: 406729256,406729255\nFixed: 406729256,406729255\nChange-Id: I9c1ddbba8d1a9e65a899ef978e3b214ae6affd28\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/233398\nCommit-Queue: Gregg Tavares \u003cgman@chromium.org\u003e\nReviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "79f799c09200a7b537ba5b7a4c361269d3dddc18",
      "old_mode": 33188,
      "old_path": "src/dawn/native/Limits.cpp",
      "new_id": "8bacc9a9954ef5f471f4ad253d3163772e2921af",
      "new_mode": 33188,
      "new_path": "src/dawn/native/Limits.cpp"
    },
    {
      "type": "modify",
      "old_id": "eaa04448ff391d98dac1064461a9221485940397",
      "old_mode": 33188,
      "old_path": "src/dawn/tests/unittests/native/LimitsTests.cpp",
      "new_id": "f51a08c78a231dda0d6cb4d542a22a0f50ade72d",
      "new_mode": 33188,
      "new_path": "src/dawn/tests/unittests/native/LimitsTests.cpp"
    },
    {
      "type": "modify",
      "old_id": "447374b0ef36c5c5720acc533b94289d6994b0c4",
      "old_mode": 33188,
      "old_path": "src/dawn/tests/unittests/validation/CompatValidationTests.cpp",
      "new_id": "0aaacc5caa6883fd78953a9b4266cf691018065c",
      "new_mode": 33188,
      "new_path": "src/dawn/tests/unittests/validation/CompatValidationTests.cpp"
    },
    {
      "type": "modify",
      "old_id": "28388fc553c5028429f6e3f7c095abf104ad4c29",
      "old_mode": 33188,
      "old_path": "webgpu-cts/compat-expectations.txt",
      "new_id": "c5bb0bb33b2a83abfb902bd991bbba84daff1474",
      "new_mode": 33188,
      "new_path": "webgpu-cts/compat-expectations.txt"
    }
  ]
}