tree cef3294dbdd3c3c92d4dbb4604dadec725ec4ad3
parent 0cdf9e09c42e439e63592a57c7a73c2fed887f5a
author Corentin Wallez <cwallez@chromium.org> 1551441898 +0000
committer Commit Bot service account <commit-bot@chromium.org> 1551441898 +0000

Fix overflow in CommandAllocator

It was essentially checking "currentPtr + commandSize <= endPtr" and
commandSize could make currentPtr overflow, making the comparison
succeed when it shouldn't have. This was caught through flakiness of the
LargeCommands allocator test.

Added a test provoking an overflow in Allocate and checking nullptr is
returned.

BUG=

Change-Id: I8ae4dad5b33c9d2005027c4d45b110ee0c65dd9a
Reviewed-on: https://dawn-review.googlesource.com/c/2841
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>