)]}'
{
  "commit": "21fb99445f32855d3f3f213f2bcd1fa1baca1f59",
  "tree": "05e5b4edc9b6c6ff110b45d3a463d18294ce0ff3",
  "parents": [
    "45b4e0ab199d1fc95ca523bf48e81b39755dc1c7"
  ],
  "author": {
    "name": "Peter McNeeley",
    "email": "petermcneeley@google.com",
    "time": "Mon Jan 13 10:38:11 2025 -0800"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Mon Jan 13 10:38:11 2025 -0800"
  },
  "message": "[dawn] Minor fix for redundant move\n\nRedundant move is a warning for some compilers as it can under\nvery specific situations cause a copy [1].\n\nWe cannot simply fix all these warnings by removing all the\nredundant moves because some returns are conversions and will not\ncompile due to move only objects. Such move only objects must\nspecifically be moved on return.\n\nAn example of wholesale attempt (failed):\nhttps://dawn-review.googlesource.com/c/dawn/+/220014?tab\u003dchecks\n\nAn example of this in dawn can be found here:\nhttps://source.chromium.org/chromium/chromium/src/+/main:third_party/dawn/src/dawn/native/ShaderModule.cpp;l\u003d371?q\u003dShaderModule.cpp:371\n\nGodbolt attempt can be found here:\nhttps://godbolt.org/z/sjrW77brY\n\n[1]\nhttps://developers.redhat.com/blog/2019/04/12/understanding-when-not-to-stdmove-in-c\n\nChange-Id: I7757a9f5435b903645a236946c04047f1951fe8c\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/220254\nReviewed-by: dan sinclair \u003cdsinclair@chromium.org\u003e\nReviewed-by: James Price \u003cjrprice@google.com\u003e\nCommit-Queue: Peter McNeeley \u003cpetermcneeley@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "b56105973efa321cbede7c93a4b835a29ed785c8",
      "old_mode": 33188,
      "old_path": "src/dawn/native/vulkan/ResourceMemoryAllocatorVk.cpp",
      "new_id": "0cf92040b3993a8ef9098238a683b754d39a0265",
      "new_mode": 33188,
      "new_path": "src/dawn/native/vulkan/ResourceMemoryAllocatorVk.cpp"
    }
  ]
}
