commit 2b28c269f35f6f135f55bb1ed688ac0b08b41385
author Peng Huang <penghuang@chromium.org> Tue Nov 07 17:40:59 2023 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Nov 07 17:40:59 2023 +0000
tree fddf9866412b6813a3a02cf1fd5ba09f1d8e49da
parent b0aaa01872fa254948abaa5dbf07111872bdfedc

Metal: add .CacheMiss suffix for several pipeline related metrics

Bug: chromium:1494342
Change-Id: I49b3cedb99040b0151ad5506426c55699e2fe3bc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/159560
Auto-Submit: Peng Huang <penghuang@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Peng Huang <penghuang@chromium.org>

src/dawn/native/metal/ComputePipelineMTL.mm

diff --git a/src/dawn/native/metal/ComputePipelineMTL.mm b/src/dawn/native/metal/ComputePipelineMTL.mm
index baf96b9..37d2e9b 100644
--- a/src/dawn/native/metal/ComputePipelineMTL.mm
+++ b/src/dawn/native/metal/ComputePipelineMTL.mm
@@ -81,7 +81,7 @@
                                    std::string([error.localizedDescription UTF8String]));
     }
     DAWN_ASSERT(mMtlComputePipelineState != nil);
-    timer.RecordMicroseconds("Metal.newComputePipelineStateWithDescriptor");
+    timer.RecordMicroseconds("Metal.newComputePipelineStateWithDescriptor.CacheMiss");
 
     // Copy over the local workgroup size as it is passed to dispatch explicitly in Metal
     mLocalWorkgroupSize = computeData.localWorkgroupSize;

src/dawn/native/metal/RenderPipelineMTL.mm

diff --git a/src/dawn/native/metal/RenderPipelineMTL.mm b/src/dawn/native/metal/RenderPipelineMTL.mm
index 10d492f..124ad5d 100644
--- a/src/dawn/native/metal/RenderPipelineMTL.mm
+++ b/src/dawn/native/metal/RenderPipelineMTL.mm
@@ -466,7 +466,7 @@
                                    [error.localizedDescription UTF8String]);
     }
     DAWN_ASSERT(mMtlRenderPipelineState != nil);
-    timer.RecordMicroseconds("Metal.newRenderPipelineStateWithDescriptor");
+    timer.RecordMicroseconds("Metal.newRenderPipelineStateWithDescriptor.CacheMiss");
 
     // Create depth stencil state and cache it, fetch the cached depth stencil state when we
     // call setDepthStencilState() for a given render pipeline in CommandEncoder, in order

src/dawn/native/metal/ShaderModuleMTL.mm

diff --git a/src/dawn/native/metal/ShaderModuleMTL.mm b/src/dawn/native/metal/ShaderModuleMTL.mm
index a91d119..a1553fb 100644
--- a/src/dawn/native/metal/ShaderModuleMTL.mm
+++ b/src/dawn/native/metal/ShaderModuleMTL.mm
@@ -389,7 +389,7 @@
                         [error.localizedDescription UTF8String]);
     }
     DAWN_ASSERT(library != nil);
-    timer.RecordMicroseconds("Metal.newLibraryWithSource");
+    timer.RecordMicroseconds("Metal.newLibraryWithSource.CacheMiss");
 
     NSRef<NSString> name = AcquireNSRef(
         [[NSString alloc] initWithUTF8String:mslCompilation->remappedEntryPointName.c_str()]);