Add perf test on shader robustness
Bug: dawn:594
Change-Id: I003ddf41123a060fcc371eb6f67740dc8898dc8b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/49305
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Jiawei Shao <jiawei.shao@intel.com>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
diff --git a/src/tests/BUILD.gn b/src/tests/BUILD.gn
index 284cc41c..abe03b3 100644
--- a/src/tests/BUILD.gn
+++ b/src/tests/BUILD.gn
@@ -521,6 +521,7 @@
"perf_tests/DawnPerfTestPlatform.cpp",
"perf_tests/DawnPerfTestPlatform.h",
"perf_tests/DrawCallPerf.cpp",
+ "perf_tests/ShaderRobustnessPerf.cpp",
"perf_tests/SubresourceTrackingPerf.cpp",
]
diff --git a/src/tests/perf_tests/ShaderRobustnessPerf.cpp b/src/tests/perf_tests/ShaderRobustnessPerf.cpp
new file mode 100644
index 0000000..c15e4a2
--- /dev/null
+++ b/src/tests/perf_tests/ShaderRobustnessPerf.cpp
@@ -0,0 +1,429 @@
+// Copyright 2021 The Dawn Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "tests/perf_tests/DawnPerfTest.h"
+
+#include "tests/ParamGenerator.h"
+#include "utils/WGPUHelpers.h"
+
+namespace {
+ constexpr uint32_t kTileSize = 64u;
+
+ constexpr char kMatMulFloat[] = R"(
+ [[block]] struct Uniforms {
+ dimAOuter : u32;
+ dimInner : u32;
+ dimBOuter : u32;
+ };
+ [[block]] struct Matrix {
+ numbers: array<f32>;
+ };
+
+ [[group(0), binding(0)]] var<storage> firstMatrix : [[access(read)]] Matrix;
+ [[group(0), binding(1)]] var<storage> secondMatrix : [[access(read)]] Matrix;
+ [[group(0), binding(2)]] var<storage> resultMatrix : [[access(write)]] Matrix;
+ [[group(0), binding(3)]] var<uniform> uniforms : Uniforms;
+
+ fn mm_readA(row : u32, col : u32) -> f32 {
+ if (row < uniforms.dimAOuter && col < uniforms.dimInner)
+ {
+ let result : f32 = firstMatrix.numbers[row * uniforms.dimInner + col];
+ return result;
+ }
+ return 0.;
+ }
+
+ fn mm_readB(row : u32, col : u32) -> f32 {
+ if (row < uniforms.dimInner && col < uniforms.dimBOuter)
+ {
+ let result : f32 = secondMatrix.numbers[row * uniforms.dimBOuter + col];
+ return result;
+ }
+ return 0.;
+ }
+
+ fn mm_write(row : u32, col : u32, value : f32) {
+ if (row < uniforms.dimAOuter && col < uniforms.dimBOuter)
+ {
+ let index : u32 = col + row * uniforms.dimBOuter;
+ resultMatrix.numbers[index] = value;
+ }
+ }
+
+ let RowPerThread : u32 = 4u;
+ let ColPerThread : u32 = 4u;
+ let TileAOuter : u32 = 64u;
+ let TileBOuter : u32 = 64u;
+ let TileInner : u32 = 64u;
+
+ var<workgroup> mm_Asub : array<f32, 4096>;
+ var<workgroup> mm_Bsub : array<f32, 4096>;
+
+ [[stage(compute), workgroup_size(16, 16, 1)]]
+ fn main([[builtin(local_invocation_id)]] local_id : vec3<u32>,
+ [[builtin(global_invocation_id)]] global_id : vec3<u32>) {
+ let tileRow : u32 = local_id.y * RowPerThread;
+ let tileCol : u32 = local_id.x * ColPerThread;
+
+ let globalRow : u32 = global_id.y * RowPerThread;
+ let globalCol : u32 = global_id.x * ColPerThread;
+
+ let numTiles : u32 = (uniforms.dimInner - 1u) / TileInner + 1u;
+
+ var acc: array<f32, 16>;
+ var ACached : f32;
+ var BCached : array<f32, 4>;
+
+ // Without this initialization strange values show up in acc.
+ // TODO: Remove it once the following bug is fixed.
+ // https://bugs.chromium.org/p/tint/issues/detail?id=759
+ for (var index : u32 = 0u; index < RowPerThread * ColPerThread; index = index + 1u) {
+ acc[index] = 0.;
+ }
+
+ let ColPerThreadA : u32 = TileInner / 16u;
+ let tileColA : u32 = local_id.x * ColPerThreadA;
+ let RowPerThreadB : u32 = TileInner / 16u;
+ let tileRowB : u32 = local_id.y * RowPerThreadB;
+
+ // Loop over shared dimension.
+ for (var t : u32 = 0u; t < numTiles; t = t + 1u) {
+ // Load one tile of A into local memory.
+ for (var innerRow : u32 = 0u; innerRow < RowPerThread; innerRow = innerRow + 1u) {
+ for (var innerCol : u32 = 0u; innerCol < ColPerThreadA; innerCol = innerCol + 1u) {
+ let inputRow : u32 = tileRow + innerRow;
+ let inputCol : u32 = tileColA + innerCol;
+ let index : u32 = inputRow * TileInner + inputCol;
+ mm_Asub[index] = mm_readA(globalRow + innerRow, t * TileInner + inputCol);
+ }
+ }
+ // Load one tile of B into local memory.
+ for (var innerRow : u32 = 0u; innerRow < RowPerThreadB; innerRow = innerRow + 1u) {
+ for (var innerCol : u32 = 0u; innerCol < ColPerThread; innerCol = innerCol + 1u) {
+ let inputRow : u32 = tileRowB + innerRow;
+ let inputCol : u32 = tileCol + innerCol;
+ let index : u32 = inputRow * TileBOuter + inputCol;
+
+ mm_Bsub[index] = mm_readB(t * TileInner + inputRow, globalCol + innerCol);;
+ }
+ }
+
+ workgroupBarrier();
+
+ // Compute acc values for a single thread.
+ for (var k : u32 = 0u; k < TileInner; k = k + 1u) {
+ for (var inner : u32 = 0u; inner < ColPerThread; inner = inner + 1u) {
+ BCached[inner] = mm_Bsub[k * TileBOuter + tileCol + inner];
+ }
+
+ for (var innerRow : u32 = 0u; innerRow < RowPerThread; innerRow = innerRow + 1u) {
+ ACached = mm_Asub[(tileRow + innerRow) * TileInner + k];
+ for (var innerCol : u32 = 0u; innerCol < ColPerThread; innerCol = innerCol + 1u) {
+ let index : u32 = innerRow * ColPerThread + innerCol;
+ acc[index] = acc[index] + ACached * BCached[innerCol];
+ }
+ }
+ }
+
+ workgroupBarrier();
+ }
+
+ for (var innerRow : u32 = 0u; innerRow < RowPerThread; innerRow = innerRow + 1u) {
+ for (var innerCol : u32 = 0u; innerCol < ColPerThread; innerCol = innerCol + 1u) {
+ let index : u32 = innerRow * ColPerThread + innerCol;
+ mm_write(globalRow + innerRow,
+ globalCol + innerCol,
+ acc[index]);
+ }
+ }
+ })";
+
+ // The vec4 version requires that dimInner and dimBOuter are divisible by 4.
+ constexpr char kMatMulVec4[] = R"(
+ [[block]] struct Uniforms {
+ dimAOuter : u32;
+ dimInner : u32;
+ dimBOuter : u32;
+ };
+ [[block]] struct Matrix {
+ numbers: array<vec4<f32>>;
+ };
+
+ [[group(0), binding(0)]] var<storage> firstMatrix : [[access(read)]] Matrix;
+ [[group(0), binding(1)]] var<storage> secondMatrix : [[access(read)]] Matrix;
+ [[group(0), binding(2)]] var<storage> resultMatrix : [[access(write)]] Matrix;
+ [[group(0), binding(3)]] var<uniform> uniforms : Uniforms;
+
+ fn mm_readA(row : u32, col : u32) -> vec4<f32> {
+ if (row < uniforms.dimAOuter && col < uniforms.dimInner)
+ {
+ let result : vec4<f32> = firstMatrix.numbers[row * uniforms.dimInner / 4u + col];
+ return result;
+ }
+ return vec4<f32>(0.0, 0.0, 0.0, 0.0);
+ }
+
+ fn mm_readB(row : u32, col : u32) -> vec4<f32> {
+ if (row < uniforms.dimInner && col < uniforms.dimBOuter)
+ {
+ let result : vec4<f32> = secondMatrix.numbers[row * uniforms.dimBOuter / 4u + col];
+ return result;
+ }
+ return vec4<f32>(0.0, 0.0, 0.0, 0.0);
+ }
+
+ fn mm_write(row : u32, col : u32, value : vec4<f32>) {
+ if (row < uniforms.dimAOuter && col < uniforms.dimBOuter)
+ {
+ let index : u32 = col + row * uniforms.dimBOuter / 4u;
+ resultMatrix.numbers[index] = value;
+ }
+ }
+
+ let RowPerThread : u32 = 4u;
+ let ColPerThread : u32 = 4u;
+ let TileAOuter : u32 = 64u;
+ let TileBOuter : u32 = 64u;
+ let TileInner : u32 = 64u;
+
+ var<workgroup> mm_Asub : array<vec4<f32>, 1024>;
+ var<workgroup> mm_Bsub : array<vec4<f32>, 1024>;
+
+ [[stage(compute), workgroup_size(16, 16, 1)]]
+ fn main([[builtin(local_invocation_id)]] local_id : vec3<u32>,
+ [[builtin(global_invocation_id)]] global_id : vec3<u32>) {
+ let tileRow : u32 = local_id.y * RowPerThread;
+ let tileCol : u32 = local_id.x;
+
+ let globalRow : u32 = global_id.y * RowPerThread;
+ let globalCol : u32 = global_id.x;
+
+ let numTiles : u32 = (uniforms.dimInner - 1u) / TileInner + 1u;
+
+ var acc: array<vec4<f32>, 4>;
+ var ACached : vec4<f32>;
+ var BCached : array<vec4<f32>, 4>;
+
+ // Without this initialization strange values show up in acc.
+ // TODO: Remove it once the following bug is fixed.
+ // https://bugs.chromium.org/p/tint/issues/detail?id=759
+ for (var index : u32 = 0u; index < RowPerThread; index = index + 1u) {
+ acc[index] = vec4<f32>(0.0, 0.0, 0.0, 0.0);
+ }
+
+ var globalColA : u32 = tileCol;
+ let RowPerThreadB : u32 = TileInner / 16u;
+ let tileRowB : u32 = local_id.y * RowPerThreadB;
+
+ // Loop over shared dimension.
+ for (var t : u32 = 0u; t < numTiles; t = t + 1u) {
+ // Load one tile of A into local memory.
+ for (var innerRow : u32 = 0u; innerRow < RowPerThread; innerRow = innerRow + 1u) {
+ let inputRow : u32 = tileRow + innerRow;
+ let inputCol : u32 = tileCol;
+ let index : u32 = inputRow * TileInner / ColPerThread + inputCol;
+ mm_Asub[index] = mm_readA(globalRow + innerRow, globalColA);
+ }
+ globalColA = globalColA + TileInner / ColPerThread;
+
+ // Load one tile of B into local memory.
+ for (var innerRow : u32 = 0u; innerRow < RowPerThreadB; innerRow = innerRow + 1u) {
+ let inputRow : u32 = tileRowB + innerRow;
+ let inputCol : u32 = tileCol;
+ let index : u32 = inputRow * TileBOuter / ColPerThread + inputCol;
+ mm_Bsub[index] = mm_readB(t * TileInner + inputRow, globalCol);;
+ }
+
+ workgroupBarrier();
+
+ // Compute acc values for a single thread.
+ for (var k : u32 = 0u; k < TileInner / ColPerThread; k = k + 1u) {
+ BCached[0] = mm_Bsub[(k * ColPerThread) * (TileBOuter / ColPerThread) + tileCol];
+ BCached[1] = mm_Bsub[(k * ColPerThread + 1u) * (TileBOuter / ColPerThread) + tileCol];
+ BCached[2] = mm_Bsub[(k * ColPerThread + 2u) * (TileBOuter / ColPerThread) + tileCol];
+ BCached[3] = mm_Bsub[(k * ColPerThread + 3u) * (TileBOuter / ColPerThread) + tileCol];
+
+ for (var i : u32 = 0u; i < RowPerThread; i = i + 1u) {
+ ACached = mm_Asub[(tileRow + i) * (TileInner / ColPerThread) + k];
+ acc[i] = BCached[0] * ACached.x + acc[i];
+ acc[i] = BCached[1] * ACached.y + acc[i];
+ acc[i] = BCached[2] * ACached.z + acc[i];
+ acc[i] = BCached[3] * ACached.w + acc[i];
+ }
+ }
+
+ workgroupBarrier();
+ }
+
+ for (var innerRow : u32 = 0u; innerRow < RowPerThread; innerRow = innerRow + 1u) {
+ mm_write(globalRow + innerRow,
+ globalCol,
+ acc[innerRow]);
+ }
+ })";
+ constexpr unsigned int kNumIterations = 50;
+
+ enum class MatMulMethod {
+ MatMulFloat,
+ MatMulVec4,
+ };
+
+ struct ShaderRobustnessParams : AdapterTestParam {
+ ShaderRobustnessParams(const AdapterTestParam& param,
+ MatMulMethod matmulMethod,
+ uint32_t dimAOuter,
+ uint32_t dimInner,
+ uint32_t dimBOuter)
+ : AdapterTestParam(param),
+ matmulMethod(matmulMethod),
+ dimAOuter(dimAOuter),
+ dimInner(dimInner),
+ dimBOuter(dimBOuter) {
+ }
+
+ MatMulMethod matmulMethod;
+ uint32_t dimAOuter;
+ uint32_t dimInner;
+ uint32_t dimBOuter;
+ };
+
+ std::ostream& operator<<(std::ostream& ostream, const ShaderRobustnessParams& param) {
+ ostream << static_cast<const AdapterTestParam&>(param);
+ switch (param.matmulMethod) {
+ case MatMulMethod::MatMulFloat:
+ ostream << "_MatMulFloat";
+ break;
+ case MatMulMethod::MatMulVec4:
+ ostream << "_MatMulVec4";
+ break;
+ }
+
+ ostream << "_" << param.dimAOuter << "_" << param.dimInner << "_" << param.dimBOuter;
+
+ return ostream;
+ }
+
+} // namespace
+
+// Test the execution time of matrix multiplication (A [dimAOuter, dimInner] * B [dimInner,
+// dimBOuter]) on the GPU and see the difference between robustness on and off.
+class ShaderRobustnessPerf : public DawnPerfTestWithParams<ShaderRobustnessParams> {
+ public:
+ ShaderRobustnessPerf()
+ : DawnPerfTestWithParams(kNumIterations, 1),
+ mDimAOuter(GetParam().dimAOuter),
+ mDimInner(GetParam().dimInner),
+ mDimBOuter(GetParam().dimBOuter) {
+ }
+ ~ShaderRobustnessPerf() override = default;
+
+ void SetUp() override;
+
+ private:
+ void Step() override;
+
+ wgpu::BindGroup mBindGroup;
+ wgpu::ComputePipeline mPipeline;
+ uint32_t mDimAOuter;
+ uint32_t mDimInner;
+ uint32_t mDimBOuter;
+};
+
+void ShaderRobustnessPerf::SetUp() {
+ DawnPerfTestWithParams<ShaderRobustnessParams>::SetUp();
+ const size_t dataASize = mDimAOuter * mDimInner;
+ std::vector<float> dataA(dataASize);
+ uint64_t byteASize = sizeof(float) * dataA.size();
+ // It's ok to use all zeros to do the matrix multiplication for performance test.
+ wgpu::Buffer bufA =
+ utils::CreateBufferFromData(device, dataA.data(), byteASize, wgpu::BufferUsage::Storage);
+
+ const size_t dataBSize = mDimInner * mDimBOuter;
+ std::vector<float> dataB(dataBSize);
+ uint64_t byteBSize = sizeof(float) * dataB.size();
+ wgpu::Buffer bufB =
+ utils::CreateBufferFromData(device, dataB.data(), byteBSize, wgpu::BufferUsage::Storage);
+
+ uint64_t byteDstSize = sizeof(float) * mDimAOuter * mDimBOuter;
+ wgpu::BufferDescriptor desc = {};
+ desc.usage = wgpu::BufferUsage::Storage;
+ desc.size = byteDstSize;
+ wgpu::Buffer dst = device.CreateBuffer(&desc);
+
+ uint32_t uniformData[] = {mDimAOuter, mDimInner, mDimBOuter};
+ wgpu::Buffer uniformBuffer = utils::CreateBufferFromData(
+ device, uniformData, sizeof(uniformData), wgpu::BufferUsage::Uniform);
+
+ wgpu::ShaderModule module;
+ switch (GetParam().matmulMethod) {
+ case MatMulMethod::MatMulFloat: {
+ module = utils::CreateShaderModule(device, kMatMulFloat);
+ break;
+ }
+
+ case MatMulMethod::MatMulVec4: {
+ module = utils::CreateShaderModule(device, kMatMulVec4);
+ break;
+ }
+ }
+
+ wgpu::ComputePipelineDescriptor csDesc;
+ csDesc.computeStage.module = module;
+ csDesc.computeStage.entryPoint = "main";
+ mPipeline = device.CreateComputePipeline(&csDesc);
+
+ mBindGroup = utils::MakeBindGroup(device, mPipeline.GetBindGroupLayout(0),
+ {
+ {0, bufA, 0, byteASize},
+ {1, bufB, 0, byteBSize},
+ {2, dst, 0, byteDstSize},
+ {3, uniformBuffer, 0, sizeof(uniformData)},
+ });
+}
+
+void ShaderRobustnessPerf::Step() {
+ wgpu::CommandBuffer commands;
+ {
+ wgpu::CommandEncoder encoder = device.CreateCommandEncoder();
+ wgpu::ComputePassEncoder pass = encoder.BeginComputePass();
+ pass.SetPipeline(mPipeline);
+ pass.SetBindGroup(0, mBindGroup);
+ for (unsigned int i = 0; i < kNumIterations; ++i) {
+ pass.Dispatch(ceil(float(mDimBOuter) / float(kTileSize)),
+ ceil(float(mDimAOuter) / float(kTileSize)), 1);
+ }
+ pass.EndPass();
+
+ commands = encoder.Finish();
+ }
+
+ queue.Submit(1, &commands);
+}
+
+TEST_P(ShaderRobustnessPerf, Run) {
+ RunTest();
+}
+
+DAWN_INSTANTIATE_PERF_TEST_SUITE_P(ShaderRobustnessPerf,
+ // TODO: Remove "use_tint_generator" once the following bug is
+ // fixed https://bugs.chromium.org/p/tint/issues/detail?id=744.
+ {D3D12Backend({}, {"use_tint_generator"}),
+ D3D12Backend({"disable_robustness"}, {"use_tint_generator"}),
+ MetalBackend(), MetalBackend({"disable_robustness"}, {}),
+ OpenGLBackend(), OpenGLBackend({"disable_robustness"}, {}),
+ VulkanBackend(), VulkanBackend({"disable_robustness"}, {})},
+ {MatMulMethod::MatMulFloat, MatMulMethod::MatMulVec4},
+ {512},
+ {512},
+ {512});
