commit 38197e7b134d5f47f9de9573f1e6e5b209f730ba
author James Price <jrprice@google.com> Tue Jan 11 16:34:55 2022 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jan 11 16:34:55 2022 +0000
tree 7d8a7b622290e598b86c5a8cf353c87729b1c91c
parent 9b0008a6d6ff43549d5bf7d35b7bc4374761e366

cmake: Always build Tint as a static library

The shared library build of Tint is currently broken with CMake, since
we set -fvisibility=hidden and do not export any of Tint's publicly
used APIs.

Change-Id: I63518fbd13e2adbf17aba79114c66d1567b8268b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/75780
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: James Price <jrprice@google.com>

third_party/CMakeLists.txt

diff --git a/third_party/CMakeLists.txt b/third_party/CMakeLists.txt
index c20fbbf..ab6ffab 100644
--- a/third_party/CMakeLists.txt
+++ b/third_party/CMakeLists.txt
@@ -56,7 +56,12 @@
     # building the GLSL writer, but currently Dawn does not provide this
     # third_party dependency. Disable the GLSL writer for now.
     set(TINT_BUILD_GLSL_WRITER OFF)
+    # TODO(crbug.com/tint/455): Tint does not currently build with CMake when
+    # BUILD_SHARED_LIBS=1, so always build it as static for now.
+    set(BUILD_SHARED_LIBS_SAVED ${BUILD_SHARED_LIBS})
+    set(BUILD_SHARED_LIBS 0)
     add_subdirectory(${DAWN_TINT_DIR} "${CMAKE_CURRENT_BINARY_DIR}/tint")
+    set(BUILD_SHARED_LIBS ${BUILD_SHARED_LIBS_SAVED})
 endif()
 
 if (NOT TARGET libabsl)