)]}'
{
  "commit": "385ebc792cd6b94d844bab9da601e91ed737635b",
  "tree": "b71082c99a6b8ce9451e508d92ff924ef0b618d9",
  "parents": [
    "dd550b8f95d49264b072fed4c9bfe6ba8b5c9edf"
  ],
  "author": {
    "name": "dan sinclair",
    "email": "dsinclair@chromium.org",
    "time": "Thu Nov 13 08:28:31 2025 -0800"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Thu Nov 13 08:28:31 2025 -0800"
  },
  "message": "[spirv] Make all access chain indices unsigned.\n\nFor any `OpAccessChain` in SPIR-V it is a validation error to have a\nnegative constant index value. In order to make sure we never emit\nnegative indices, always bitcast the index to an unsigned value before\npassing to the access chain.\n\nThere are currently only two ways this can happen, by disabling\nrobustness or but the disabling of runtime array robustness. In the case\nof the former, robustness has been disabled, so it\u0027s on the caller to\nmake sure the index was never negative. In the case of the latter we\nonly do this when we have RobustBufferAccess2 enabled and it will\nhandling the clamping for us.\n\nFixed: 459509275\nChange-Id: I784cb3c8dbc3e3c907402094940fabed16138827\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/273294\nReviewed-by: James Price \u003cjrprice@google.com\u003e\nCommit-Queue: dan sinclair \u003cdsinclair@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "9acf3d91075dcba9912b564248bab72144fe379d",
      "old_mode": 33188,
      "old_path": "src/tint/lang/spirv/writer/access_test.cc",
      "new_id": "2170ff559bdd8659bb7fa1c438dfcc7479e26a46",
      "new_mode": 33188,
      "new_path": "src/tint/lang/spirv/writer/access_test.cc"
    },
    {
      "type": "modify",
      "old_id": "571a9187ed5bca52179092f72d957c3f96ac024f",
      "old_mode": 33188,
      "old_path": "src/tint/lang/spirv/writer/printer/printer.cc",
      "new_id": "855de299b2dd800fd180ae6b4a996a39ce8fd3cc",
      "new_mode": 33188,
      "new_path": "src/tint/lang/spirv/writer/printer/printer.cc"
    },
    {
      "type": "modify",
      "old_id": "4e9f76e6104bb5e7e8c2b0be310adbd4a5b658fa",
      "old_mode": 33188,
      "old_path": "test/tint/binding_array/access_as_function_argument.wgsl.expected.spvasm",
      "new_id": "fe26cae0a4fa7fa1fccd1ed4c39cf86a889e3ac1",
      "new_mode": 33188,
      "new_path": "test/tint/binding_array/access_as_function_argument.wgsl.expected.spvasm"
    },
    {
      "type": "modify",
      "old_id": "accff41aac3394aeec8508d284428c4afde8240c",
      "old_mode": 33188,
      "old_path": "test/tint/binding_array/access_constant.wgsl.expected.spvasm",
      "new_id": "e2c4aeb2d4fdbdd59ee31a947b34407c960ab0d7",
      "new_mode": 33188,
      "new_path": "test/tint/binding_array/access_constant.wgsl.expected.spvasm"
    },
    {
      "type": "modify",
      "old_id": "a8ab21ee91d5a6badbc978d5c3d336df3ce0050c",
      "old_mode": 33188,
      "old_path": "test/tint/bug/chromium/344265982.wgsl.expected.spvasm",
      "new_id": "bfb429428604b6923c8080921f9603b87d827d07",
      "new_mode": 33188,
      "new_path": "test/tint/bug/chromium/344265982.wgsl.expected.spvasm"
    },
    {
      "type": "modify",
      "old_id": "123fd7f359499a80764c706a1e6c88ce2899e41e",
      "old_mode": 33188,
      "old_path": "test/tint/bug/fxc/vector_assignment_in_loop/loop_call_with_loop.wgsl.expected.spvasm",
      "new_id": "8e06ef80f8484930613c4c57d8e5a65f8c959a9b",
      "new_mode": 33188,
      "new_path": "test/tint/bug/fxc/vector_assignment_in_loop/loop_call_with_loop.wgsl.expected.spvasm"
    },
    {
      "type": "modify",
      "old_id": "433e407e908fae75d5a781f6ebe13c3364f8ff3e",
      "old_mode": 33188,
      "old_path": "test/tint/bug/fxc/vector_assignment_in_loop/loop_types_all.wgsl.expected.spvasm",
      "new_id": "26838bb29d29dd0248ab373b8ffab699daa4906b",
      "new_mode": 33188,
      "new_path": "test/tint/bug/fxc/vector_assignment_in_loop/loop_types_all.wgsl.expected.spvasm"
    },
    {
      "type": "modify",
      "old_id": "ffa4bc267fbc263466425c7aec230699e7e912d7",
      "old_mode": 33188,
      "old_path": "test/tint/bug/fxc/vector_assignment_in_loop/loop_types_repeated.wgsl.expected.spvasm",
      "new_id": "6a51a0b36f0f51514f99ff01b2cad70a8ee8390d",
      "new_mode": 33188,
      "new_path": "test/tint/bug/fxc/vector_assignment_in_loop/loop_types_repeated.wgsl.expected.spvasm"
    },
    {
      "type": "modify",
      "old_id": "45a330e81299a16cf95f34795a7d9c1f09d65101",
      "old_mode": 33188,
      "old_path": "test/tint/bug/fxc/vector_assignment_in_loop/loop_types_some.wgsl.expected.spvasm",
      "new_id": "f9d07b383875aaab5da113ac3aef60ca8aa22cfd",
      "new_mode": 33188,
      "new_path": "test/tint/bug/fxc/vector_assignment_in_loop/loop_types_some.wgsl.expected.spvasm"
    },
    {
      "type": "modify",
      "old_id": "f68f76b16c1e34db89e24ab86d6e38137d72e255",
      "old_mode": 33188,
      "old_path": "test/tint/bug/tint/1641.wgsl.expected.spvasm",
      "new_id": "631413668c8e35507d665657796fff58a2ecb407",
      "new_mode": 33188,
      "new_path": "test/tint/bug/tint/1641.wgsl.expected.spvasm"
    },
    {
      "type": "modify",
      "old_id": "024f01793de2113f2518cb6558dfc900f1cf2ccd",
      "old_mode": 33188,
      "old_path": "test/tint/expressions/index/let/let/literal/array.wgsl.expected.spvasm",
      "new_id": "ad426e386f3e0f879cae56038f84fec7302b84da",
      "new_mode": 33188,
      "new_path": "test/tint/expressions/index/let/let/literal/array.wgsl.expected.spvasm"
    },
    {
      "type": "modify",
      "old_id": "526ffa74b39290dae62e85ca97ee53be7eb0aa44",
      "old_mode": 33188,
      "old_path": "test/tint/expressions/index/let/let/literal/matrix.wgsl.expected.spvasm",
      "new_id": "dcb4aa2e7d59b4702325c5fe5f13ac5bd5ea8e1b",
      "new_mode": 33188,
      "new_path": "test/tint/expressions/index/let/let/literal/matrix.wgsl.expected.spvasm"
    },
    {
      "type": "modify",
      "old_id": "70104954ed8788b7774696c73656a75cb4b1d09c",
      "old_mode": 33188,
      "old_path": "test/tint/expressions/index/var/let/literal/array.wgsl.expected.spvasm",
      "new_id": "3af26cf530e8245f5d3a69bbf747bdc9e8d56eb4",
      "new_mode": 33188,
      "new_path": "test/tint/expressions/index/var/let/literal/array.wgsl.expected.spvasm"
    },
    {
      "type": "modify",
      "old_id": "f11e8c1e45cab600a78e3b4323db4729ec4ca4b8",
      "old_mode": 33188,
      "old_path": "test/tint/expressions/index/var/let/literal/matrix.wgsl.expected.spvasm",
      "new_id": "810a0f42f3c1177c3a0e5b7a17c990f9d2c70530",
      "new_mode": 33188,
      "new_path": "test/tint/expressions/index/var/let/literal/matrix.wgsl.expected.spvasm"
    },
    {
      "type": "modify",
      "old_id": "2f65cbe2c692bbe32b3f7fac9335eb91fb3323a1",
      "old_mode": 33188,
      "old_path": "test/tint/expressions/index/var/let/literal/vector.wgsl.expected.spvasm",
      "new_id": "7fa9655c78b7dd79671f4802cada44539d8ff319",
      "new_mode": 33188,
      "new_path": "test/tint/expressions/index/var/let/literal/vector.wgsl.expected.spvasm"
    },
    {
      "type": "modify",
      "old_id": "8e96dbf3344b55cf5311750b392339f93bf847a3",
      "old_mode": 33188,
      "old_path": "test/tint/ptr_sugar/array.wgsl.expected.spvasm",
      "new_id": "02477305be6866277df0849866852e4bc88b2dbf",
      "new_mode": 33188,
      "new_path": "test/tint/ptr_sugar/array.wgsl.expected.spvasm"
    },
    {
      "type": "modify",
      "old_id": "e00951920c1a6961be0f914611cbf05a2f651036",
      "old_mode": 33188,
      "old_path": "test/tint/ptr_sugar/vector_index.wgsl.expected.spvasm",
      "new_id": "e1528e432140c8411db800e45118d04527889483",
      "new_mode": 33188,
      "new_path": "test/tint/ptr_sugar/vector_index.wgsl.expected.spvasm"
    }
  ]
}