commit | 3f06587542d5859aa8031facf1801efd79f57e65 | [log] [tgz] |
---|---|---|
author | Stephen White <senorblanco@chromium.org> | Fri Oct 26 11:49:12 2018 +0000 |
committer | Commit Bot service account <commit-bot@chromium.org> | Fri Oct 26 11:49:12 2018 +0000 |
tree | 51a8faf52d0c981006df54420c0dee5123a2fef2 | |
parent | 56e5974c2c973d2450f32671810ea8db6414718f [diff] |
Fix D3D12 Buffer::UnmapImpl() for MapWriteAsync(). d3d12::Buffer::UnmapImpl() was passing an empty range to ID3D12Resource::Unmap(). This causes it to be a no-op when writing a buffer. The fix is to store the entire mapped range in the Buffer, and use it during Unmap(). Note: this doesn't seem to actually cause an issue on the D3D12 drivers I have, so I have been unable to write a test for it. However, it does cause an issue in RenderDoc: the buffer data appears unmodifed after the Map/memcpy/Unmap calls. The hypothesis is that RenderDoc notices the empty range at the API level, and leaves its shadow buffer contents unmodified. Because I feel this change is correct regardless, I'm landing it without a test. Bug: dawn:25 Change-Id: Ie5dd5fcfedbe1d80c75a3d8094c97af27653ee00 Reviewed-on: https://dawn-review.googlesource.com/c/1920 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Dawn (formerly NXT) is an open-source and cross-platform implementation of the work-in-progress WebGPU standard. It exposes a C/C++ API that maps almost one-to-one to the WebGPU IDL and can be managed as part of a larger system such as a Web browser.
Dawn provides several WebGPU building blocks:
dawn.json
: description of the API used to drive code generators.examples
: examples showing how Dawn is used.generator
: code generator for files produces from dawn.json
templates
: Jinja2 templates for the generatorscripts
: scripts to support things like continuous testing, build files, etc.src
:common
: helper code shared between core Dawn libraries and tests/samplesdawn_native
: native implementation of WebGPU, one subfolder per backenddawn_wire
: client-server implementation of WebGPUinclude
: public headers for Dawntests
: internal Dawn testsend2end
: WebGPU tests performing GPU operationsunittests
: unittests and by extension tests not using the GPUvalidation
: WebGPU validation tests not using the GPU (frontend tests)utils
: helper code to use Dawn used by tests and samplesthird_party
: directory where dependencies live as well as their buildfiles.Dawn uses the Chromium build system and dependency management so you need to [install depot_tools] and add it to the PATH. Then get the source as follows:
# Clone the repo as "dawn" git clone https://dawn.googlesource.com/dawn dawn && cd dawn # Bootstrap the gclient configuration cp scripts/standalone.gclient .gclient # Fetch external dependencies and toolchains with gclient gclient sync
Then generate build files using gn args out/Debug
or gn args out/Release
. A text editor will appear asking build options, the most common option is is_debug=true/false
; otherwise gn args out/Release --list
shows all the possible options.
Then use ninja -C out/Release
to build dawn and for example ./out/Release/dawn_end2end_tests
to run the tests.
Please read and follow CONTRIBUTING.md. Dawn doesn‘t have a formal coding style yet, except what’s defined by our clang format style. Overall try to use the same style and convention as code around your change.
If you find issues with Dawn, please feel free to report them on the bug tracker.
Please see LICENSE.
This is not an officially supported Google product.