)]}' { "commit": "44eb10814e2aa8b07c96573bd268cf2ea15d97b7", "tree": "b36b28975f4b301f4bf408352ab957a097f2c356", "parents": [ "b6c150d6e0bc03e808ec8beced5ba1306cef380c" ], "author": { "name": "Ben Clayton", "email": "bclayton@google.com", "time": "Tue Jun 21 22:56:33 2022 +0000" }, "committer": { "name": "Dawn LUCI CQ", "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Jun 21 22:56:33 2022 +0000" }, "message": "tint/resolver: Change return type of EvaluateConstantValue()\n\nThese functions do not return an error - however they might return an\ninvalid Constant value (if a constant cannot be evaluated), which is\ncorrectly handled by the resolver. So, drop the Result, just emit a\nsem::Constant.\n\nChange-Id: I0dd37125c0dba4ba6dcace5ee5f8b1c53cb34d33\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/94326\nReviewed-by: Dan Sinclair \u003cdsinclair@chromium.org\u003e\nCommit-Queue: Ben Clayton \u003cbclayton@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "d222d1dbbdadf36dd3b7bc0479b1e0f59510d372", "old_mode": 33188, "old_path": "src/tint/resolver/resolver.cc", "new_id": "d19f9bda6db1ac2d808aa243d5c4c1bd2625f69c", "new_mode": 33188, "new_path": "src/tint/resolver/resolver.cc" }, { "type": "modify", "old_id": "5b73e9d819602bddf3aa125d312c967e966c51c6", "old_mode": 33188, "old_path": "src/tint/resolver/resolver.h", "new_id": "0b52ec9c50c8290fcfd9c8b52f44a412abb205ef", "new_mode": 33188, "new_path": "src/tint/resolver/resolver.h" }, { "type": "modify", "old_id": "24c57d4460e876e9e965a32aa44618c648b1f3ea", "old_mode": 33188, "old_path": "src/tint/resolver/resolver_constants.cc", "new_id": "95b494ed36848c432c7e0dae2aa9cea3a37f835a", "new_mode": 33188, "new_path": "src/tint/resolver/resolver_constants.cc" } ] }