)]}'
{
  "commit": "4c086b03bdfc55eef19124017dd56b410fb2e0ec",
  "tree": "cb20f23f011b46728ad475833fe454a471d6f217",
  "parents": [
    "3b9b7369a743717689dbe1dfe57d91164e5ecaf8"
  ],
  "author": {
    "name": "Kai Ninomiya",
    "email": "kainino@chromium.org",
    "time": "Fri Oct 17 13:11:27 2025 -0700"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Fri Oct 17 13:11:27 2025 -0700"
  },
  "message": "[cmake] Disable vptr sanitizer on old Clang\n\nThe vptr sanitizer is enabled by -fsanitize\u003dundefined only on older\nversions of Clang. We want to enable it (GN enables it along with\nis_ubsan), but tint_unittests fails with the version of Clang on our\nLinux CMake bots (19.0.0) which seems to be a buggy old version, as the\nerror it produces seems to be incorrect (see bug).\n\ntint_unittests passes locally on my machine with Clang 19.1.7, so gate\nthe vptr sanitizer on that version. Verified locally that the check\ncontrols the flag as expected.\n\nWhenever the bots\u0027 Clang gets upgraded, the sanitizer will turn back on\nautomatically. Or, using a hermetic toolchain (like HermeticXcode.cmake\nbut for Linux) would also fix it, but it\u0027s difficult to set up.\n\nAdditionally:\n- Fix one more missing RTTI flag control.\n- Document why we have the float-divide-by-zero sanitizer, since GN\n  doesn\u0027t.\n\nFixed: 452389542\nBug: b:434977307\nCq-Include-Trybots: luci.dawn.try:cmake-linux-clang-dbg-x64-ubsan,cmake-linux-clang-rel-x64-ubsan\nChange-Id: Ifcdbe04a3588db3543ac269d53471ce561551b20\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/267317\nCommit-Queue: Kai Ninomiya \u003ckainino@chromium.org\u003e\nReviewed-by: Brandon Jones \u003cbajones@chromium.org\u003e\nAuto-Submit: Kai Ninomiya \u003ckainino@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "2b4acbec7545d413a8b9d2bfa3d58867b750997c",
      "old_mode": 33188,
      "old_path": "CMakeLists.txt",
      "new_id": "9005588a51156a40756e7883de4f760be5dd4864",
      "new_mode": 33188,
      "new_path": "CMakeLists.txt"
    },
    {
      "type": "modify",
      "old_id": "7031e7d120738d9117eddd5f6d3eea816f28d4a4",
      "old_mode": 33188,
      "old_path": "src/cmake/DawnCompilerExtraFlags.cmake",
      "new_id": "caaf850ab896d7e26d79831c6a130a57f2b33191",
      "new_mode": 33188,
      "new_path": "src/cmake/DawnCompilerExtraFlags.cmake"
    },
    {
      "type": "modify",
      "old_id": "bb9057ec0830502742a4f7e45ac46f14905340e7",
      "old_mode": 33188,
      "old_path": "third_party/protobuf.cmake",
      "new_id": "78806b3f530bde66bd00868ca15b9698901a586e",
      "new_mode": 33188,
      "new_path": "third_party/protobuf.cmake"
    }
  ]
}