commit | 4a858a0cbd6d280d2ba7135014deaa6c4c765bef | [log] [tgz] |
---|---|---|
author | Jiawei Shao <jiawei.shao@intel.com> | Tue Mar 24 00:56:53 2020 +0000 |
committer | Commit Bot service account <commit-bot@chromium.org> | Tue Mar 24 00:56:53 2020 +0000 |
tree | bc118d890c8b53560eab21b94483aa9b7cca74e8 | |
parent | 80a1868f335d3f560a30550fae7edee93dbc7f08 [diff] |
Reland "Check bind group layout with storage texture in pipeline descriptors" This reverts commit 7c24b6b2ff192927720a2cfa0fdd2dae1614ee96. Reason for revert: We can reland this CL now as the fix in shaderc has been merged. Note that the declaration whether a storage texture is multisampled or not cannot be extracted correctly in SPVC. The fix in Dawn will be added after it is fixed in shaderc. Original change's description: > Revert "Check bind group layout with storage texture in pipeline descriptors" > > This reverts commit 63f2666ee77c987a56c6be5bfc6bbb10d12a9f63. > > Reason for revert: causes failures in dawn_unittests after Dawn uses SPVC by default. We need a fix in both SPVC and this CL before re-landing. > > Original change's description: > > Check bind group layout with storage texture in pipeline descriptors > > > > This patch adds all the validations on the use of bind group layout with > > read-only storage texture and write-only storage texture in the creation > > of pipeline objects. > > > > 1. GPUBindGroupLayout.bindingType must match the type of the storage > > texture variable (read-only or write-only) in shader. > > 2. GPUBindGroupLayout.storageTextureFormat must be a valid texture > > format that supports STORAGE usage. > > 3. GPUBindGroupLayout.storageTextureFormat must match the storage > > texture format declaration in shader. > > 4. GPUBindGroupLayout.textureDimension must match the storage texture > > dimension declared in shader. > > > > BUG=dawn:267 > > TEST=dawn_unittests > > > > Change-Id: Ifa3c2194dc76de14f790a0a73868e69bbb31c814 > > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/17167 > > Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> > > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > > TBR=cwallez@chromium.org,kainino@chromium.org,yunchao.he@intel.com,jiawei.shao@intel.com,shaobo.yan@intel.com,hao.x.li@intel.com,enga@chromium.org,jiajie.hu@intel.com > > Change-Id: Idb4083b11f22fa7e4c5c8477bc4b65b58900746e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: dawn:267 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/17380 > Reviewed-by: Jiawei Shao <jiawei.shao@intel.com> > Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> TBR=cwallez@chromium.org,kainino@chromium.org,yunchao.he@intel.com,jiawei.shao@intel.com,shaobo.yan@intel.com,hao.x.li@intel.com,enga@chromium.org,jiajie.hu@intel.com Bug: dawn:267, chromium:1063570 Change-Id: If762cbb206e738f4e54e75c88d506fdf3a44f280 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/17461 Reviewed-by: Jiawei Shao <jiawei.shao@intel.com> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Dawn is an open-source and cross-platform implementation of the work-in-progress WebGPU standard. More precisely it implements webgpu.h
that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.
Dawn provides several WebGPU building blocks:
webgpu.h
version that Dawn implements.webgpu.h
.Helpful links:
Developer documentation:
User documentation: (TODO, figure out what overlaps with webgpu.h docs)
(TODO)
Apache 2.0 Public License, please see LICENSE.
This is not an officially supported Google product.