)]}'
{
  "commit": "511eb80847afe6bded34ec491a38d5d78ba2d604",
  "tree": "e2296d848f64a0506f0523c7e942b2fa37abbfca",
  "parents": [
    "737d5d8e967be13c9e9f6a3201ce841eb9529082"
  ],
  "author": {
    "name": "Jiawei Shao",
    "email": "jiawei.shao@intel.com",
    "time": "Thu Aug 29 00:57:50 2024 +0000"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Thu Aug 29 00:57:50 2024 +0000"
  },
  "message": "Tint: Support `clip_distances` on HLSL\n\nThis patch implements the translation of built-in value `clip_distances`\non HLSL. We should take different ways to do the translation according\nto the array length of `clip_distances`:\n- Array length is 1:\n  float clipDistance : SV_ClipDistance0\n- Array length is 2 to 4:\n  floatN clipDistance : SV_ClipDistance0\n- Array length is 5:\n  float4 clipDistance : SV_ClipDistance0\n  float clipDistance1 : SV_ClipDistance1\n- Array length is 6 to 8:\n  float4 clipDistance : SV_ClipDistance0\n  floatN clipDistance1 : SV_ClipDistance1\n\nTo correctly translate in HLSL backend we have to use\n`core::BuiltinValue::kClipDistances` as `SV_ClipDistance0` and the\ninternal attribute `HLSLClipDistance1` as `SV_ClipDistance1`.\n\nBug: chromium:358408571\nChange-Id: I5d0843cc846190c60a028e48fb8e13ae9a88a5bb\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/203775\nReviewed-by: James Price \u003cjrprice@google.com\u003e\nCommit-Queue: Jiawei Shao \u003cjiawei.shao@intel.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "e7fd33aa5b44c3058cd0587cdf503327354fce98",
      "old_mode": 33188,
      "old_path": "src/tint/lang/hlsl/writer/ast_printer/ast_printer.cc",
      "new_id": "ce29693365f333e4f7766c934d65125558d9209a",
      "new_mode": 33188,
      "new_path": "src/tint/lang/hlsl/writer/ast_printer/ast_printer.cc"
    },
    {
      "type": "modify",
      "old_id": "3a16948eb3887e68ce4f4e4bdcb8de1e7ae1f3a6",
      "old_mode": 33188,
      "old_path": "src/tint/lang/hlsl/writer/ast_printer/ast_printer.h",
      "new_id": "81ebfd717e5148701f7fffd166e2be6660a9f214",
      "new_mode": 33188,
      "new_path": "src/tint/lang/hlsl/writer/ast_printer/ast_printer.h"
    },
    {
      "type": "modify",
      "old_id": "1e607bb4e135828a68272a0ab1c937c29fa9d188",
      "old_mode": 33188,
      "old_path": "src/tint/lang/wgsl/ast/disable_validation_attribute.cc",
      "new_id": "59f1ad20b7bb3919eaa7cb329903cd37284126a5",
      "new_mode": 33188,
      "new_path": "src/tint/lang/wgsl/ast/disable_validation_attribute.cc"
    },
    {
      "type": "modify",
      "old_id": "4591ba9d783711e7e5fce8e662076fb8c7fa96e5",
      "old_mode": 33188,
      "old_path": "src/tint/lang/wgsl/ast/disable_validation_attribute.h",
      "new_id": "c6127bcaffabc6fd68bbd90e3034477ef6059a47",
      "new_mode": 33188,
      "new_path": "src/tint/lang/wgsl/ast/disable_validation_attribute.h"
    },
    {
      "type": "modify",
      "old_id": "c9361e93add653d0a41ece6c405b95f042456a84",
      "old_mode": 33188,
      "old_path": "src/tint/lang/wgsl/ast/transform/canonicalize_entry_point_io.cc",
      "new_id": "e31f686292b12c1f5d326100d8626f48a0fbefd6",
      "new_mode": 33188,
      "new_path": "src/tint/lang/wgsl/ast/transform/canonicalize_entry_point_io.cc"
    },
    {
      "type": "modify",
      "old_id": "9899e3d5cacee1e0d223da990ffd0079b81773e9",
      "old_mode": 33188,
      "old_path": "src/tint/lang/wgsl/ast/transform/canonicalize_entry_point_io.h",
      "new_id": "928fe56be229523bb67b3d137b505b56641e79ae",
      "new_mode": 33188,
      "new_path": "src/tint/lang/wgsl/ast/transform/canonicalize_entry_point_io.h"
    },
    {
      "type": "modify",
      "old_id": "4cf6a62bc8691c7730fd8c9fc543fcec17719af2",
      "old_mode": 33188,
      "old_path": "src/tint/lang/wgsl/resolver/validator.cc",
      "new_id": "90566646085319c911f15aa2c3c879170da68272",
      "new_mode": 33188,
      "new_path": "src/tint/lang/wgsl/resolver/validator.cc"
    },
    {
      "type": "modify",
      "old_id": "82f311254e886170f4bcc7145330aa00ab6af19b",
      "old_mode": 33188,
      "old_path": "src/tint/lang/wgsl/resolver/validator.h",
      "new_id": "1db8f641928ce69657636b15ae524cd5e1a74e3f",
      "new_mode": 33188,
      "new_path": "src/tint/lang/wgsl/resolver/validator.h"
    },
    {
      "type": "modify",
      "old_id": "6d69a54b69a61fcc0b49a7fad48669ff7e54c480",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/clip_distances/clip_distances_size_1.wgsl.expected.dxc.hlsl",
      "new_id": "8a9a6d36fed590cd18453f805d9721b9d12f880f",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_1.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "6d69a54b69a61fcc0b49a7fad48669ff7e54c480",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/clip_distances/clip_distances_size_1.wgsl.expected.fxc.hlsl",
      "new_id": "8a9a6d36fed590cd18453f805d9721b9d12f880f",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_1.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "7d7ee0096aae2a9ea19153ddfdf6d0f2384c1d33",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/clip_distances/clip_distances_size_1.wgsl.expected.glsl",
      "new_id": "1db6fd3af6736d6e31744a68ea0400c21ebfee08",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_1.wgsl.expected.glsl"
    },
    {
      "type": "modify",
      "old_id": "10e52d9f51702c9f4f6f2a3e20eae92bfb9a604d",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/clip_distances/clip_distances_size_1.wgsl.expected.ir.msl",
      "new_id": "af78b7278d589fd3397d48c2f7df389293507a42",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_1.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "fd5ca2364648c290de63aeace08a53bd92fe82cc",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/clip_distances/clip_distances_size_1.wgsl.expected.msl",
      "new_id": "05ce84e724aa47007db00ba39a094a8fa3e656db",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_1.wgsl.expected.msl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "5e0487bdd67be3cac1840521f3f5d08ae52fda85",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_3.wgsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "8b76aeb0cd771852b2c864c2c39013a9c5c54460",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_3.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "8b76aeb0cd771852b2c864c2c39013a9c5c54460",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_3.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "39bbe86f21bafce0b77e39ead687ba43be60aa41",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_3.wgsl.expected.glsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "b0160ea1ee9f001e993784bb1d45692e79eaaf18",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_3.wgsl.expected.ir.dxc.hlsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "b0160ea1ee9f001e993784bb1d45692e79eaaf18",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_3.wgsl.expected.ir.fxc.hlsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "23310a1940e1d6618a19b66063e655480dcfacd4",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_3.wgsl.expected.ir.msl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "972fd0e9db6d4f026f4afe840e82e27193ef6472",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_3.wgsl.expected.msl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "f3e7b9e66732721902a862d04e43c0bb7fa2633d",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_3.wgsl.expected.spvasm"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "5e0487bdd67be3cac1840521f3f5d08ae52fda85",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_3.wgsl.expected.wgsl"
    },
    {
      "type": "modify",
      "old_id": "e5d4dce8e67aac500efe7b8c139f3fa3c1a8d502",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/clip_distances/clip_distances_size_4.wgsl.expected.dxc.hlsl",
      "new_id": "9d8db7682cdfc7eb3bd357dca5a4e850a972be6a",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_4.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "e5d4dce8e67aac500efe7b8c139f3fa3c1a8d502",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/clip_distances/clip_distances_size_4.wgsl.expected.fxc.hlsl",
      "new_id": "9d8db7682cdfc7eb3bd357dca5a4e850a972be6a",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_4.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "88551af21def0bb486403a3635ee2c5c67e910d5",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/clip_distances/clip_distances_size_4.wgsl.expected.glsl",
      "new_id": "e4cdf124b81063732870d2ff6203b846ae8074bb",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_4.wgsl.expected.glsl"
    },
    {
      "type": "modify",
      "old_id": "917e0b241b49f04c01c6207ddc6ad4b67e72236f",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/clip_distances/clip_distances_size_4.wgsl.expected.ir.msl",
      "new_id": "ff0637df8359b5bf201babb474d2a95e0cf1f79b",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_4.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "8f88332e8e5f90a80ea624c0119ce5d1a6b81ade",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/clip_distances/clip_distances_size_4.wgsl.expected.msl",
      "new_id": "e1c3a437bdc6e07b4b73f69ba4024ddc9fb0e360",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_4.wgsl.expected.msl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "b82ef45b0846b70f994a91f61a7fe1f4c15ecb73",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_5.wgsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "398a16a0e63614d970645dcf595aee4860ba1a9b",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_5.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "398a16a0e63614d970645dcf595aee4860ba1a9b",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_5.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "3801310bd8b687d707ab03adc97cad91748e6c58",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_5.wgsl.expected.glsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "b0160ea1ee9f001e993784bb1d45692e79eaaf18",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_5.wgsl.expected.ir.dxc.hlsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "b0160ea1ee9f001e993784bb1d45692e79eaaf18",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_5.wgsl.expected.ir.fxc.hlsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "c5090989ac4f6c47cb3afa85f13f00170379f8ac",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_5.wgsl.expected.ir.msl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "872384f2b985d15c8b1352ad53b88f723d1e55e9",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_5.wgsl.expected.msl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "202845d95b1e1128bf5e8d91770078f4e522fb5f",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_5.wgsl.expected.spvasm"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "b82ef45b0846b70f994a91f61a7fe1f4c15ecb73",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_5.wgsl.expected.wgsl"
    },
    {
      "type": "modify",
      "old_id": "33be9e067a0ab27358b6a105e2fcac0042224155",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/clip_distances/clip_distances_size_8.wgsl.expected.dxc.hlsl",
      "new_id": "a693a6aba8fbec31a03ec4b8ddbdffa9ba2733a7",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_8.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "33be9e067a0ab27358b6a105e2fcac0042224155",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/clip_distances/clip_distances_size_8.wgsl.expected.fxc.hlsl",
      "new_id": "a693a6aba8fbec31a03ec4b8ddbdffa9ba2733a7",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_8.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "4eaae782e79aacf824ee78eb4e812ed17e4ca735",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/clip_distances/clip_distances_size_8.wgsl.expected.glsl",
      "new_id": "f89ccc0663346c035613ef51a98b6d781254cac9",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_8.wgsl.expected.glsl"
    },
    {
      "type": "modify",
      "old_id": "9df70b1ec9a470fe5d9202d1178b3d941760cb92",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/clip_distances/clip_distances_size_8.wgsl.expected.ir.msl",
      "new_id": "d1697c84ec422c8198d84d9e60f46b9b267087ce",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_8.wgsl.expected.ir.msl"
    },
    {
      "type": "modify",
      "old_id": "952455ec5ff046728ee3fa058815d844203cbd54",
      "old_mode": 33188,
      "old_path": "test/tint/extensions/clip_distances/clip_distances_size_8.wgsl.expected.msl",
      "new_id": "400aabd718cb9d07f30bbf6c2eff817c43bb2c7c",
      "new_mode": 33188,
      "new_path": "test/tint/extensions/clip_distances/clip_distances_size_8.wgsl.expected.msl"
    }
  ]
}