tree 7aae9da4449345e70d94ad4e1dee47de3d767f5e
parent 47ae7fb823b74ba1e9e0c9afc7b500bb26adcccf
author Daniel Cheng <dcheng@chromium.org> 1719956480 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1719956480 +0000

[MSan] Fix use-after-dtor issues in generated C++ APIs.

The move assignment operator manually invokes the destructor, to ensure
any data owned by pointer fields is cleaned up instead of leaked.
However, manually invoking the destructor also ends the lifetime of
`this`, and future attempts to use the field become an error when MSan's
use-after-dtor check is enabled.

The fix is to move the cleanup logic into a private helper function and
invoke the helper from both the destructor and the move assignment
operator.

Bug: 40222690
Change-Id: I1c31a1f2c342b0768ecc02f4f84c63b7e3a9160c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/196554
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>