commit 527080ff03ce4541a12c2648b6a44e53a1d6384e
author Xinghua Cao <xinghua.cao@intel.com> Wed Jun 10 03:29:34 2020 +0000
committer Commit Bot service account <commit-bot@chromium.org> Wed Jun 10 03:29:34 2020 +0000
tree 0d890a7e4c49a5fdeb43f9a837bc9f57154d3346
parent 14f20b0ab38d5996d2c2716156912491783d93fa

Check FP16 support on Metal backend

Metal supports FP16 on both macOS and iOS, so we can
unconditionally enable this extension on Metal backend.

BUG=dawn:426
TEST=dawn_end2end_tests

Change-Id: I16c9c907bb112a66e76506ede9bc89a04313d7b3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/22882
Reviewed-by: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Xinghua Cao <xinghua.cao@intel.com>

src/dawn_native/metal/BackendMTL.mm

diff --git a/src/dawn_native/metal/BackendMTL.mm b/src/dawn_native/metal/BackendMTL.mm
index 093cceb..a5e7c47 100644
--- a/src/dawn_native/metal/BackendMTL.mm
+++ b/src/dawn_native/metal/BackendMTL.mm
@@ -220,6 +220,8 @@
                 mSupportedExtensions.EnableExtension(Extension::TimestampQuery);
             }
 #endif
+
+            mSupportedExtensions.EnableExtension(Extension::ShaderFloat16);
         }
 
         id<MTLDevice> mDevice = nil;

src/tests/end2end/ShaderFloat16Tests.cpp

diff --git a/src/tests/end2end/ShaderFloat16Tests.cpp b/src/tests/end2end/ShaderFloat16Tests.cpp
index 57d94be..fa0fd47 100644
--- a/src/tests/end2end/ShaderFloat16Tests.cpp
+++ b/src/tests/end2end/ShaderFloat16Tests.cpp
@@ -108,4 +108,4 @@
     EXPECT_BUFFER_U16_RANGE_EQ(expected, bufferOut, 0, 2);
 }
 
-DAWN_INSTANTIATE_TEST(ShaderFloat16Tests, VulkanBackend());
\ No newline at end of file
+DAWN_INSTANTIATE_TEST(ShaderFloat16Tests, MetalBackend(), VulkanBackend());