)]}'
{
  "commit": "532be50b761b660e2e5e354bbffb5b020df9afef",
  "tree": "beba8b0a7b01eb4099613235a4f534a92cf16b48",
  "parents": [
    "7d20b4450182b8e25dfd315019623d7a746cc290"
  ],
  "author": {
    "name": "Jiawei Shao",
    "email": "jiawei.shao@intel.com",
    "time": "Mon Mar 09 00:45:18 2020 +0000"
  },
  "committer": {
    "name": "Commit Bot service account",
    "email": "commit-bot@chromium.org",
    "time": "Mon Mar 09 00:45:18 2020 +0000"
  },
  "message": "Check bindingType with shader stage when creating default pipeline layout\n\nThis patch intends to fix a crash issue when creating a rendering\npipeline with storage buffer declared in vertex shader and pipeline\nlayout is not set.\n\nWithout this patch, in PipelineLayoutBase::CreateDefault() the\nbindingSlot.visibility is always set to Fragment and Compute when it is\na storage buffer, therefore a crash happens at the failure of the\nassertion modules-\u003eIsCompatibleWithPipelineLayout() when the storage\nbuffer is actually declared in the vertex shader.\n\nBUG\u003ddawn:276\nTEST\u003ddawn_unittests\n\nChange-Id: I56876a97d53ead5ed226dc1b9bbed1a77156b2b2\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/16564\nReviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\nReviewed-by: Austin Eng \u003cenga@chromium.org\u003e\nCommit-Queue: Jiawei Shao \u003cjiawei.shao@intel.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "0ab3f1c3dd71166f9991c96043aa5ae83fc529c3",
      "old_mode": 33188,
      "old_path": "src/dawn_native/BindGroupLayout.cpp",
      "new_id": "d16330aeabf8668cf31230c9de60243ef4f74bb4",
      "new_mode": 33188,
      "new_path": "src/dawn_native/BindGroupLayout.cpp"
    },
    {
      "type": "modify",
      "old_id": "4c0dd7aae8d8e6ffaa0c29c8862c60dff30e11a0",
      "old_mode": 33188,
      "old_path": "src/dawn_native/BindGroupLayout.h",
      "new_id": "02d8453ac7fc95d77d235de6140a6ba79905e391",
      "new_mode": 33188,
      "new_path": "src/dawn_native/BindGroupLayout.h"
    },
    {
      "type": "modify",
      "old_id": "a810f37435ac5b091064b86288297c61eea0d8d8",
      "old_mode": 33188,
      "old_path": "src/dawn_native/PipelineLayout.cpp",
      "new_id": "5cdf781a353258d2909f9fc5b4bfbad91804b1ad",
      "new_mode": 33188,
      "new_path": "src/dawn_native/PipelineLayout.cpp"
    },
    {
      "type": "modify",
      "old_id": "f8b3d42415d15e341c677bd324525eb4792fe183",
      "old_mode": 33188,
      "old_path": "src/tests/unittests/validation/RenderPipelineValidationTests.cpp",
      "new_id": "9ffbbc91ea83ae23498949b45437a585184257f9",
      "new_mode": 33188,
      "new_path": "src/tests/unittests/validation/RenderPipelineValidationTests.cpp"
    }
  ]
}