tree bd4f7bd99d15e81b53640868f6fb7caa08fa58e4
parent 39b4b38f4f36b8a74e351febe5617fb0c2e36d6a
author Rafael Cintron <rafael.cintron@microsoft.com> 1573249620 +0000
committer Commit Bot service account <commit-bot@chromium.org> 1573249620 +0000

Fix ResourceHeapAllocation Memory Leak

ResourceAllocatorManager::DeallocateMemory was correctly invalidating the
passed in allocation object. However, since the subclass
ResourceHeapAllocation class was not overriding the Invalidate method and
clearing out the D3D12Resource pointer, the resource ended up being tied
to the lifetime of the Texture object instead of being released on Destroy.

In Chromium, this bug was particularly egregious as it meant swap chain
texture cleanup was at the whims of the Javascript garbage collector.

Bug: dawn:242
Change-Id: Ia5856c61c8d3b92a2247a9aaa5f91c5de0a99dcb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/13200
Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Austin Eng <enga@chromium.org>