tree 37f25b3fbfc09a9e3e4239e9daa6c12b41399e6d
parent 020e317f38755e80d0ffb20e95aae5b47869c1ee
author Corentin Wallez <cwallez@chromium.org> 1728551073 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1728551073 +0000

Revert "[dawn][webgpu.h] Use wgpu::StringView for strings in output structs."

This reverts commit 980e48de901e70a01ca96fcc30032492bfc1468f.

Reason for revert: breaks compilation of MLDrift in branded Chrome.

Original change's description:
> [dawn][webgpu.h] Use wgpu::StringView for strings in output structs.
>
> These are wgpu::AdapterInfo and wgpu::CompilationMessage.
>
>  - Adds a deprecation #define for a few code changes in Skia and
>    Chromium.
>  - Fixup the FreeMembers logic for StringView that 1) doesn't need a
>    FreeMembers method itself, 2) should have .data checked when deciding
>    whether to auto-free members in the C++ header.
>  - For convenience, add StringView support to webgpu_cpp_print.h
>  - During conversion of dawn::native, try to simplify the handling of
>    allocation and returning of output strings in Adapter and
>    CompilationMessages.
>  - Likewise for dawn::wire.
>  - Simplify GPUCompilationMessages in dawn.node to compute all members
>    in its constructor.
>  - Fixup various other files for compilation errors after the change.
>
> Bug: 42241188
> Change-Id: I6db839a6b8862b4a55c1ea9911ed3725b465c2f3
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/208534
> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
> Reviewed-by: Kai Ninomiya <kainino@chromium.org>

TBR=cwallez@chromium.org,kainino@chromium.org,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com,lokokung@google.com

Change-Id: Ib0e16a9c9486b931f3e1dca7744635a394bf5aeb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 42241188
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/210434
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>