commit 6681114e5e03398ddc1def0a4ae359c2ebb677c9
author James Price <jrprice@google.com> Mon Jun 14 08:39:02 2021 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jun 14 08:39:02 2021 +0000
tree 1b081500f00b076cc0b0ad0a9ac7d028c6c07bc2
parent 2ee28d304f29f2e6cc87e694dafb4fb0865bcde7

Update usage of arrayLength() intrinsic

The runtime array parameter is now passed as a pointer, instead of by
value.

Change-Id: I632814d2a2890dbe4476c2b01023a5ff8de42d21
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/54485
Auto-Submit: James Price <jrprice@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

src/tests/end2end/OpArrayLengthTests.cpp

diff --git a/src/tests/end2end/OpArrayLengthTests.cpp b/src/tests/end2end/OpArrayLengthTests.cpp
index 581143c..3a219b4 100644
--- a/src/tests/end2end/OpArrayLengthTests.cpp
+++ b/src/tests/end2end/OpArrayLengthTests.cpp
@@ -131,9 +131,9 @@
         [[group(1), binding(0)]] var<storage, read_write> result : ResultBuffer;
         )" + mShaderInterface + R"(
         [[stage(compute)]] fn main() {
-            result.data[0] = arrayLength(buffer1.data);
-            result.data[1] = arrayLength(buffer2.data);
-            result.data[2] = arrayLength(buffer3.data);
+            result.data[0] = arrayLength(&buffer1.data);
+            result.data[1] = arrayLength(&buffer2.data);
+            result.data[2] = arrayLength(&buffer3.data);
         })")
                                                                         .c_str());
     wgpu::ComputePipeline pipeline = device.CreateComputePipeline(&pipelineDesc);
@@ -171,9 +171,9 @@
     wgpu::ShaderModule fsModule = utils::CreateShaderModule(device, (mShaderInterface + R"(
         [[stage(fragment)]] fn main() -> [[location(0)]] vec4<f32> {
             var fragColor : vec4<f32>;
-            fragColor.r = f32(arrayLength(buffer1.data)) / 255.0;
-            fragColor.g = f32(arrayLength(buffer2.data)) / 255.0;
-            fragColor.b = f32(arrayLength(buffer3.data)) / 255.0;
+            fragColor.r = f32(arrayLength(&buffer1.data)) / 255.0;
+            fragColor.g = f32(arrayLength(&buffer2.data)) / 255.0;
+            fragColor.b = f32(arrayLength(&buffer3.data)) / 255.0;
             fragColor.a = 0.0;
             return fragColor;
         })")
@@ -223,9 +223,9 @@
 
         [[stage(vertex)]] fn main() -> VertexOut {
             var output : VertexOut;
-            output.color.r = f32(arrayLength(buffer1.data)) / 255.0;
-            output.color.g = f32(arrayLength(buffer2.data)) / 255.0;
-            output.color.b = f32(arrayLength(buffer3.data)) / 255.0;
+            output.color.r = f32(arrayLength(&buffer1.data)) / 255.0;
+            output.color.g = f32(arrayLength(&buffer2.data)) / 255.0;
+            output.color.b = f32(arrayLength(&buffer3.data)) / 255.0;
             output.color.a = 0.0;
 
             output.position = vec4<f32>(0.0, 0.0, 0.0, 1.0);