)]}'
{
  "commit": "6c167a0dc78380dfc5d60623aa435af80066b910",
  "tree": "db9eeda208b1fb14fb5af1a5f747e59410e832b7",
  "parents": [
    "1a758d8cebdab8fe5a3a9d330c1689903a0c0fe7"
  ],
  "author": {
    "name": "dan sinclair",
    "email": "dsinclair@chromium.org",
    "time": "Tue Jun 28 02:06:05 2022 +0000"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Tue Jun 28 02:06:05 2022 +0000"
  },
  "message": "msl: Promote local private vars to function scope\n\nIf a module-scope private variable is only referenced within a single\nfunction, promote it to a function scope declaration instead of\npassing it as a parameter. This reduces the number of a function\nparameters that are needed in some cases.\n\nBug: tint:1509\nChange-Id: I8951f6216bc7e4cf5abfda314bea1e9ed3ded560\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/94002\nReviewed-by: Antonio Maiorano \u003camaiorano@google.com\u003e\nCommit-Queue: Dan Sinclair \u003cdsinclair@chromium.org\u003e\nKokoro: Kokoro \u003cnoreply+kokoro@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "e61c56e239b1e52cf7dbc9a17335517ac6f8c524",
      "old_mode": 33188,
      "old_path": "src/tint/transform/module_scope_var_to_entry_point_param.cc",
      "new_id": "5a7eecc32835f0bc47d211dcc709e7011d01ec98",
      "new_mode": 33188,
      "new_path": "src/tint/transform/module_scope_var_to_entry_point_param.cc"
    },
    {
      "type": "modify",
      "old_id": "6a8d5eca28055f10dfa120b0ecba5efc9b42a087",
      "old_mode": 33188,
      "old_path": "src/tint/transform/module_scope_var_to_entry_point_param_test.cc",
      "new_id": "dcf89126e535d640a52170c72495309dff0930fc",
      "new_mode": 33188,
      "new_path": "src/tint/transform/module_scope_var_to_entry_point_param_test.cc"
    },
    {
      "type": "modify",
      "old_id": "dabd986a88dcb00cf5e45d79caf68f72cbacec7a",
      "old_mode": 33188,
      "old_path": "test/tint/array/assign_to_function_var.wgsl.expected.msl",
      "new_id": "216648e39ae56c8c8ab66e5357612aa01a288714",
      "new_mode": 33188,
      "new_path": "test/tint/array/assign_to_function_var.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "8ec45d8a697d3e9fa9640ca98877ed542e5c7ad9",
      "old_mode": 33188,
      "old_path": "test/tint/array/assign_to_private_var.wgsl.expected.msl",
      "new_id": "d7d5f421c902030c4b2f1385978a56924d3c8e7f",
      "new_mode": 33188,
      "new_path": "test/tint/array/assign_to_private_var.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "3165ec8e6353495cb388ce6603da8e5ea4b34723",
      "old_mode": 33188,
      "old_path": "test/tint/array/assign_to_storage_var.wgsl.expected.msl",
      "new_id": "5628bba3b9fc5d790e1a9d7828376412187af82f",
      "new_mode": 33188,
      "new_path": "test/tint/array/assign_to_storage_var.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "74df1bbfb75642fb82353794d15d95edbe646e90",
      "old_mode": 33188,
      "old_path": "test/tint/array/assign_to_workgroup_var.wgsl.expected.msl",
      "new_id": "6ea152229c1ae0d0d8c2d47db392502a0b11b3f7",
      "new_mode": 33188,
      "new_path": "test/tint/array/assign_to_workgroup_var.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "1e1cbee3959f2c38b91c8f106dc4c2ee19296342",
      "old_mode": 33188,
      "old_path": "test/tint/bug/fxc/vector_assignment_in_loop/loop_call_with_loop.wgsl.expected.msl",
      "new_id": "e30b1c16c8b20cce0f69556355e88bba3588463a",
      "new_mode": 33188,
      "new_path": "test/tint/bug/fxc/vector_assignment_in_loop/loop_call_with_loop.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "ec498ee0141b36e9f636197f6f53a288bb4c888e",
      "old_mode": 33188,
      "old_path": "test/tint/bug/fxc/vector_assignment_in_loop/loop_call_with_no_loop.wgsl.expected.msl",
      "new_id": "920f566342c1c2626711b0bb56af7c30ccbfd512",
      "new_mode": 33188,
      "new_path": "test/tint/bug/fxc/vector_assignment_in_loop/loop_call_with_no_loop.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "b75a05c9aebfb53d962ba85e107671936cb894d9",
      "old_mode": 33188,
      "old_path": "test/tint/bug/tint/1086.wgsl.expected.msl",
      "new_id": "8ea0e8973d5058ee2639ad9ae210a1e26bb0bb5b",
      "new_mode": 33188,
      "new_path": "test/tint/bug/tint/1086.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "392fd22e5def80278826e4e6db743131bc5ddc60",
      "old_mode": 33188,
      "old_path": "test/tint/bug/tint/1088.spvasm.expected.msl",
      "new_id": "5970249e5e32c12087a9182c93fd402318523666",
      "new_mode": 33188,
      "new_path": "test/tint/bug/tint/1088.spvasm.expected.msl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "0ba56e0d05168d7960af336c6d3f417535daf1a7",
      "new_mode": 33188,
      "new_path": "test/tint/bug/tint/1509.wgsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "30dbc951a982220fbd33e02cf9304cab452ee2f8",
      "new_mode": 33188,
      "new_path": "test/tint/bug/tint/1509.wgsl.expected.glsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "2f03ad7ccf641a152480dea3ca413363371058be",
      "new_mode": 33188,
      "new_path": "test/tint/bug/tint/1509.wgsl.expected.hlsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "65784033b8780e0fa36727a3b8315dfb60e8d5ac",
      "new_mode": 33188,
      "new_path": "test/tint/bug/tint/1509.wgsl.expected.msl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "eaf2f4bf6610f18bddb791a07cb505ed1d76a8ef",
      "new_mode": 33188,
      "new_path": "test/tint/bug/tint/1509.wgsl.expected.spvasm"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "0ba56e0d05168d7960af336c6d3f417535daf1a7",
      "new_mode": 33188,
      "new_path": "test/tint/bug/tint/1509.wgsl.expected.wgsl"
    },
    {
      "type": "modify",
      "old_id": "a556deeab63e1ec66ca5f6ee118ee6cbc34fc7ff",
      "old_mode": 33188,
      "old_path": "test/tint/bug/tint/1520.spvasm.expected.msl",
      "new_id": "030f92f3b821d05accd5be805c354cc186f702ae",
      "new_mode": 33188,
      "new_path": "test/tint/bug/tint/1520.spvasm.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "8da55f652a11bb031aeeaf0a233df6c1649b89e5",
      "old_mode": 33188,
      "old_path": "test/tint/bug/tint/926.wgsl.expected.msl",
      "new_id": "34e8d8da5867b267898ffcc1a4f2a33623560416",
      "new_mode": 33188,
      "new_path": "test/tint/bug/tint/926.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "c21d89fbad8850ae12f13f4bd81accf4fb6df5f9",
      "old_mode": 33188,
      "old_path": "test/tint/bug/tint/948.wgsl.expected.msl",
      "new_id": "b36650f538ef5945073bfdfe4c0ffa9aa7297acc",
      "new_mode": 33188,
      "new_path": "test/tint/bug/tint/948.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "9b8daf4bcfff90111531d63356d7b150b8725edc",
      "old_mode": 33188,
      "old_path": "test/tint/bug/tint/949.wgsl.expected.msl",
      "new_id": "2cd37f5bd0d693e7ffabae871b78b8898c1c8add",
      "new_mode": 33188,
      "new_path": "test/tint/bug/tint/949.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "85b1790824d7621a208cd275faaaeb970b3990b3",
      "old_mode": 33188,
      "old_path": "test/tint/expressions/swizzle/read/vec3/f32.wgsl.expected.msl",
      "new_id": "a682cd481e29acdb895d55cd09be120f1a4f6dfe",
      "new_mode": 33188,
      "new_path": "test/tint/expressions/swizzle/read/vec3/f32.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "ddcd693ad468cd37f9ff8db721ba4ea22f812053",
      "old_mode": 33188,
      "old_path": "test/tint/expressions/swizzle/read/vec3/i32.wgsl.expected.msl",
      "new_id": "63e124b61e7c0e2c3413c678cefcd2ecbeba4d55",
      "new_mode": 33188,
      "new_path": "test/tint/expressions/swizzle/read/vec3/i32.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "61bc87d07893de958df95a14ca32d1d53891b1f1",
      "old_mode": 33188,
      "old_path": "test/tint/expressions/swizzle/read/vec3/u32.wgsl.expected.msl",
      "new_id": "62ca0b30e5ddca5b5a2f572953502e9eee1e0fd0",
      "new_mode": 33188,
      "new_path": "test/tint/expressions/swizzle/read/vec3/u32.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "17624cfcf939e4a0967b20e14bb59493dbad4b86",
      "old_mode": 33188,
      "old_path": "test/tint/expressions/swizzle/write/vec3/f32.wgsl.expected.msl",
      "new_id": "7122f543519dcffb27ad0c49f5e90a2ae13a4d83",
      "new_mode": 33188,
      "new_path": "test/tint/expressions/swizzle/write/vec3/f32.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "bbd4748e6032f97310f4e992a4eef70a920c5830",
      "old_mode": 33188,
      "old_path": "test/tint/expressions/swizzle/write/vec3/i32.wgsl.expected.msl",
      "new_id": "1e4aee136e3d087379a069d5e9197acc5954b755",
      "new_mode": 33188,
      "new_path": "test/tint/expressions/swizzle/write/vec3/i32.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "f665ab6387d27cd99ce2bafaffadaf23cf9b21a7",
      "old_mode": 33188,
      "old_path": "test/tint/expressions/swizzle/write/vec3/u32.wgsl.expected.msl",
      "new_id": "5b5f76943dda2ede2f6d026162ffbb72e89a3af7",
      "new_mode": 33188,
      "new_path": "test/tint/expressions/swizzle/write/vec3/u32.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "3feee1fb8398bbeae14d30b0d19117619f4eaac6",
      "old_mode": 33188,
      "old_path": "test/tint/identifiers/underscore/double/var.wgsl.expected.msl",
      "new_id": "6d12124fe220ac07a5f95c97d635379235102197",
      "new_mode": 33188,
      "new_path": "test/tint/identifiers/underscore/double/var.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "4b5a7c869fbb02346f4ec0cf2c9aec61694e07a9",
      "old_mode": 33188,
      "old_path": "test/tint/identifiers/underscore/prefix/lower/var.wgsl.expected.msl",
      "new_id": "d700a2a19c887ec6eb27755dd7218b7870134d37",
      "new_mode": 33188,
      "new_path": "test/tint/identifiers/underscore/prefix/lower/var.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "f889d4df125912195545d188424dfb47af882b6b",
      "old_mode": 33188,
      "old_path": "test/tint/identifiers/underscore/prefix/upper/var.wgsl.expected.msl",
      "new_id": "da05cb2df9c907c8570645ef000b82bb7a4c5926",
      "new_mode": 33188,
      "new_path": "test/tint/identifiers/underscore/prefix/upper/var.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "178b0a5e2555a5a58d8a9ec7011619623b007909",
      "old_mode": 33188,
      "old_path": "test/tint/ptr_ref/load/global/i32.spvasm.expected.msl",
      "new_id": "7e3e1024d66c045fb4d3bed6fc2bdece674fd3f0",
      "new_mode": 33188,
      "new_path": "test/tint/ptr_ref/load/global/i32.spvasm.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "5ac35523441ae5063d8b3fb4dcc6535feb50d893",
      "old_mode": 33188,
      "old_path": "test/tint/ptr_ref/load/global/struct_field.spvasm.expected.msl",
      "new_id": "211485e551f349080a59c78dca01be747a6cbfba",
      "new_mode": 33188,
      "new_path": "test/tint/ptr_ref/load/global/struct_field.spvasm.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "c27b618d1aee99e2d0c29b1e010be5bc0d1bac34",
      "old_mode": 33188,
      "old_path": "test/tint/ptr_ref/store/global/i32.spvasm.expected.msl",
      "new_id": "b2d21430854c4e8c38b9ac584fb46b05f35d8e00",
      "new_mode": 33188,
      "new_path": "test/tint/ptr_ref/store/global/i32.spvasm.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "451a322e55b2f71567e624931f9afa4db17c93bb",
      "old_mode": 33188,
      "old_path": "test/tint/ptr_ref/store/global/struct_field.spvasm.expected.msl",
      "new_id": "08486b5b1dba99b5e0684a5738a5f2208b63d24c",
      "new_mode": 33188,
      "new_path": "test/tint/ptr_ref/store/global/struct_field.spvasm.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "76c3cca2cf312a8c5e2ecc4a2d2d0cefb049604c",
      "old_mode": 33188,
      "old_path": "test/tint/statements/assign/indexed_assign_to_array_in_struct/indexing_with_side_effect_func.wgsl.expected.msl",
      "new_id": "7b606ba7e6dae37438eb90c2faec525289ef8f6b",
      "new_mode": 33188,
      "new_path": "test/tint/statements/assign/indexed_assign_to_array_in_struct/indexing_with_side_effect_func.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "a6e7d861441f85830dc6db6832e5fd5bfdef8828",
      "old_mode": 33188,
      "old_path": "test/tint/statements/compound_assign/divide_by_zero.wgsl.expected.msl",
      "new_id": "aa0605fc58b43fcf14855f075a583fecdd3e930d",
      "new_mode": 33188,
      "new_path": "test/tint/statements/compound_assign/divide_by_zero.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "19fdb2fd3638800b9550d62d1d634fb768426552",
      "old_mode": 33188,
      "old_path": "test/tint/statements/compound_assign/private.wgsl.expected.msl",
      "new_id": "327107f7908cc57f66ea9c00fef0bc0e156a5ffd",
      "new_mode": 33188,
      "new_path": "test/tint/statements/compound_assign/private.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "ad64e49a9a7a5a6a605f5236f95a67ac7553818e",
      "old_mode": 33188,
      "old_path": "test/tint/statements/decrement/private.wgsl.expected.msl",
      "new_id": "2c423330897a70dfeb52c8b6ff60cad31f875b4b",
      "new_mode": 33188,
      "new_path": "test/tint/statements/decrement/private.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "4cf93e4c0fd40989d652bd2a3791de5ee54a21c9",
      "old_mode": 33188,
      "old_path": "test/tint/statements/increment/private.wgsl.expected.msl",
      "new_id": "019bc09dc707b000290420d058b372e6507dd2a2",
      "new_mode": 33188,
      "new_path": "test/tint/statements/increment/private.wgsl.expected.msl"
    }
  ]
}