)]}'
{
  "commit": "6e852f8fa88ca2e9e9bc3500552d7bc547c49caa",
  "tree": "3631521eef96b8338688e0d3888398bcd21f94cc",
  "parents": [
    "21acc62bb268c959b7dfbe8fc308b4ec34f5ad87"
  ],
  "author": {
    "name": "Corentin Wallez",
    "email": "cwallez@chromium.org",
    "time": "Wed Sep 20 13:34:19 2023 +0000"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Wed Sep 20 13:34:19 2023 +0000"
  },
  "message": "vulkan::Device: Don\u0027t rely on the queue during DestroyImpl\n\nIt was only used to get the completed serial, which is basically\nkMaxExecutionSerial, so just use that. DestroyImpl\u0027s full logic might\nneed to run without a queue if the following happens:\n\n - DeviceVk::Initialize runs partially, enough to have a VkDevice, and\n   fails before the call to DeviceBase::Initialize.\n - DeviceBase::Initialize IS NOT called and so mQueue IS NOT set.\n - DeviceBase::~DeviceBase calls DeviceBase::Destroy which calls\n   Device::DestroyImpl.\n - Device::DestroyImpl sees there is a VkDevice so full deinitialization\n   is needed, and that used to call GetQueue(), which this CL fixes.\n\nBug: chromium:1484300\nChange-Id: I66ae8a2c7eeccffb4212323ef21b1670efcc762f\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/152404\nKokoro: Kokoro \u003cnoreply+kokoro@google.com\u003e\nCommit-Queue: Corentin Wallez \u003ccwallez@chromium.org\u003e\nReviewed-by: Loko Kung \u003clokokung@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "99db74df89ae0a94c45c0ded08e838715cbfc9d1",
      "old_mode": 33188,
      "old_path": "src/dawn/native/Device.cpp",
      "new_id": "ffa524fef463fff91266e7cff05ba0537bae9a8a",
      "new_mode": 33188,
      "new_path": "src/dawn/native/Device.cpp"
    },
    {
      "type": "modify",
      "old_id": "d831c31cc212795d6f778e336538e2f7800f9817",
      "old_mode": 33188,
      "old_path": "src/dawn/native/vulkan/DeviceVk.cpp",
      "new_id": "87312411aed5bc46583dab50d07592130cb45f0e",
      "new_mode": 33188,
      "new_path": "src/dawn/native/vulkan/DeviceVk.cpp"
    },
    {
      "type": "modify",
      "old_id": "dcae126f46d23a259fdad32393b27e5784813e51",
      "old_mode": 33188,
      "old_path": "src/dawn/native/vulkan/DeviceVk.h",
      "new_id": "9376d766394418a62fd1a89021ce0a41c6dd0dfd",
      "new_mode": 33188,
      "new_path": "src/dawn/native/vulkan/DeviceVk.h"
    }
  ]
}