)]}'
{
  "commit": "7092786f313d07d3c73ba02bbe3139d4ecc6ed8e",
  "tree": "219bb056f0f23edf35a828e11ac072dca340aee0",
  "parents": [
    "5dd9d1dee8b5efe50450b85919932fb10d6e6aef"
  ],
  "author": {
    "name": "dan sinclair",
    "email": "dsinclair@chromium.org",
    "time": "Wed Jan 11 13:18:29 2023 +0000"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Wed Jan 11 13:18:29 2023 +0000"
  },
  "message": "Fixup return of HLSL sign to match WGSL.\n\nThe HLSL `sign` method returns an `int` result (scalar or vector). The\nWGSL `sign` expects the result to be the same type as the argument. This\nCL injects a cast to the correct type after the `sign` call in the HLSL\ngenerated source.\n\nBug: tint:1795\nChange-Id: I51fed24b5b8b752b6b27fdfb5dd47eb803902793\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116692\nKokoro: Kokoro \u003cnoreply+kokoro@google.com\u003e\nCommit-Queue: Ben Clayton \u003cbclayton@google.com\u003e\nReviewed-by: Ben Clayton \u003cbclayton@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "8e8f1ede1c5e0f9142e64b3fb05dffb5307fb436",
      "old_mode": 33188,
      "old_path": "src/tint/writer/hlsl/generator_impl.cc",
      "new_id": "fe10b2b93041b9b073451c45e0427ce1862d3916",
      "new_mode": 33188,
      "new_path": "src/tint/writer/hlsl/generator_impl.cc"
    },
    {
      "type": "modify",
      "old_id": "1558fa59719084b0fbdca3b76e7529243899df50",
      "old_mode": 33188,
      "old_path": "src/tint/writer/hlsl/generator_impl.h",
      "new_id": "76b9042952c6fa1a8b07a29e6177bbc4b3656361",
      "new_mode": 33188,
      "new_path": "src/tint/writer/hlsl/generator_impl.h"
    },
    {
      "type": "modify",
      "old_id": "8b5fe0704b773ad47861c9ab98b53eaaaf60451b",
      "old_mode": 33188,
      "old_path": "src/tint/writer/hlsl/generator_impl_builtin_test.cc",
      "new_id": "785e1fd9a9e824f3b06796bbc9a3a98352194803",
      "new_mode": 33188,
      "new_path": "src/tint/writer/hlsl/generator_impl_builtin_test.cc"
    },
    {
      "type": "modify",
      "old_id": "96ed7ee052a0300ef2ca8b3b71bc98f534dafcf7",
      "old_mode": 33188,
      "old_path": "src/tint/writer/hlsl/generator_impl_import_test.cc",
      "new_id": "3e9e5911bafd80e0643e550048d5d573dd9795bc",
      "new_mode": 33188,
      "new_path": "src/tint/writer/hlsl/generator_impl_import_test.cc"
    },
    {
      "type": "modify",
      "old_id": "8f9f2ce525bbf881dcfa8f041b7891869f099fcb",
      "old_mode": 33188,
      "old_path": "test/tint/bug/tint/1739.wgsl.expected.dxc.hlsl",
      "new_id": "d0f098eaa57757da0522392e78894563e3e4b969",
      "new_mode": 33188,
      "new_path": "test/tint/bug/tint/1739.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "8f9f2ce525bbf881dcfa8f041b7891869f099fcb",
      "old_mode": 33188,
      "old_path": "test/tint/bug/tint/1739.wgsl.expected.fxc.hlsl",
      "new_id": "d0f098eaa57757da0522392e78894563e3e4b969",
      "new_mode": 33188,
      "new_path": "test/tint/bug/tint/1739.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "edecf62d43c6f022fd7f40332b213a165494d767",
      "old_mode": 33188,
      "old_path": "test/tint/bug/tint/977.spvasm.expected.dxc.hlsl",
      "new_id": "6fca35affcd7ad96e0d8acc93fcae0dadad86b2a",
      "new_mode": 33188,
      "new_path": "test/tint/bug/tint/977.spvasm.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "edecf62d43c6f022fd7f40332b213a165494d767",
      "old_mode": 33188,
      "old_path": "test/tint/bug/tint/977.spvasm.expected.fxc.hlsl",
      "new_id": "6fca35affcd7ad96e0d8acc93fcae0dadad86b2a",
      "new_mode": 33188,
      "new_path": "test/tint/bug/tint/977.spvasm.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "bcec5f7aaa90e113ebb58142fd2d6d6acba4d2ca",
      "old_mode": 33188,
      "old_path": "test/tint/bug/tint/980.wgsl.expected.dxc.hlsl",
      "new_id": "9401dcb838e864e367f46e0a241fe6348ab3e2d8",
      "new_mode": 33188,
      "new_path": "test/tint/bug/tint/980.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "bcec5f7aaa90e113ebb58142fd2d6d6acba4d2ca",
      "old_mode": 33188,
      "old_path": "test/tint/bug/tint/980.wgsl.expected.fxc.hlsl",
      "new_id": "9401dcb838e864e367f46e0a241fe6348ab3e2d8",
      "new_mode": 33188,
      "new_path": "test/tint/bug/tint/980.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "17bf1dd4dcabe6bf20bbfe70787c20b2a397995f",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/literal/textureLoad/1bfdfb.wgsl.expected.dxc.hlsl",
      "new_id": "efe4f1a72f71f8f909b2800641b4b43f89ccbf90",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/literal/textureLoad/1bfdfb.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "17bf1dd4dcabe6bf20bbfe70787c20b2a397995f",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/literal/textureLoad/1bfdfb.wgsl.expected.fxc.hlsl",
      "new_id": "efe4f1a72f71f8f909b2800641b4b43f89ccbf90",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/literal/textureLoad/1bfdfb.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "fd0e466b1e9d59e8368549ed669d49e50df8cb6d",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/literal/textureLoad/8acf41.wgsl.expected.dxc.hlsl",
      "new_id": "8c1ebf33df589fbb9206c4ba4cb14dd4183dbe30",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/literal/textureLoad/8acf41.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "fd0e466b1e9d59e8368549ed669d49e50df8cb6d",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/literal/textureLoad/8acf41.wgsl.expected.fxc.hlsl",
      "new_id": "8c1ebf33df589fbb9206c4ba4cb14dd4183dbe30",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/literal/textureLoad/8acf41.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "b6bbc70b370d5a785717ce5a92de92b3c0c22a96",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/literal/textureSampleBaseClampToEdge/7c04e6.wgsl.expected.dxc.hlsl",
      "new_id": "6a15bfbcf1071c5571d520a05e5729f80959e3fc",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/literal/textureSampleBaseClampToEdge/7c04e6.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "b6bbc70b370d5a785717ce5a92de92b3c0c22a96",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/literal/textureSampleBaseClampToEdge/7c04e6.wgsl.expected.fxc.hlsl",
      "new_id": "6a15bfbcf1071c5571d520a05e5729f80959e3fc",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/literal/textureSampleBaseClampToEdge/7c04e6.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "0f5abe888e21c22635184efb65742a20816decb6",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/sign/159665.wgsl.expected.dxc.hlsl",
      "new_id": "66f2d8c5738d8e4a9a991eddea7be14877e0f939",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/sign/159665.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "0f5abe888e21c22635184efb65742a20816decb6",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/sign/159665.wgsl.expected.fxc.hlsl",
      "new_id": "66f2d8c5738d8e4a9a991eddea7be14877e0f939",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/sign/159665.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "a7f7d6a4a0e2ce86db73461caa91d99bec16ddb6",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/sign/160933.wgsl.expected.dxc.hlsl",
      "new_id": "0f56714e7b1b5945821b925812eb3f571673e15e",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/sign/160933.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "edc661b9fdd01c6cfa8d0696f611a09f7e1d012b",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/sign/3233fa.wgsl.expected.dxc.hlsl",
      "new_id": "0cc495e075a3c30c1499166a5a0b8bb14b3a9b5c",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/sign/3233fa.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "edc661b9fdd01c6cfa8d0696f611a09f7e1d012b",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/sign/3233fa.wgsl.expected.fxc.hlsl",
      "new_id": "0cc495e075a3c30c1499166a5a0b8bb14b3a9b5c",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/sign/3233fa.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "f9df2fbd96f233ecc15c11278195e2d8dfba2d9e",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/sign/58d779.wgsl.expected.dxc.hlsl",
      "new_id": "6e66a1bcae4da4438081ffda166c74b9113c0a3a",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/sign/58d779.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "f9df2fbd96f233ecc15c11278195e2d8dfba2d9e",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/sign/58d779.wgsl.expected.fxc.hlsl",
      "new_id": "6e66a1bcae4da4438081ffda166c74b9113c0a3a",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/sign/58d779.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "ba4ea8efd8e144e8979bbd6c8218ebc3108406f2",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/sign/5d283a.wgsl.expected.dxc.hlsl",
      "new_id": "1b7200df020c58ea9374dc902f58b3fcdd1d8ed6",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/sign/5d283a.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "2a3c8695785f839f031367d841771461808a4187",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/sign/7c85ea.wgsl.expected.dxc.hlsl",
      "new_id": "17807f9deab7236dfa638c0b6ae43669ddc3f4ac",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/sign/7c85ea.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "48233dcae8cb620842cd68355ef18dfbe5665b0c",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/sign/926015.wgsl.expected.dxc.hlsl",
      "new_id": "5421ab23df4c5f33e46c51835845c7120a2c6e3c",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/sign/926015.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "48233dcae8cb620842cd68355ef18dfbe5665b0c",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/sign/926015.wgsl.expected.fxc.hlsl",
      "new_id": "5421ab23df4c5f33e46c51835845c7120a2c6e3c",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/sign/926015.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "e3bd74cb9b02048c05f0eacf39126b99bfa75425",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/sign/9603b1.wgsl.expected.dxc.hlsl",
      "new_id": "1a54c841b3e7f287316d7be37f49a94ab38c180a",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/sign/9603b1.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "e3bd74cb9b02048c05f0eacf39126b99bfa75425",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/sign/9603b1.wgsl.expected.fxc.hlsl",
      "new_id": "1a54c841b3e7f287316d7be37f49a94ab38c180a",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/sign/9603b1.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "dd79825e0c91b303bad750f46b5430900b20d04a",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/sign/b8f634.wgsl.expected.dxc.hlsl",
      "new_id": "61cd17f4011cb0c5047df2d695b8fc31e792e9dc",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/sign/b8f634.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "dd79825e0c91b303bad750f46b5430900b20d04a",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/sign/b8f634.wgsl.expected.fxc.hlsl",
      "new_id": "61cd17f4011cb0c5047df2d695b8fc31e792e9dc",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/sign/b8f634.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "8ec5c58856c79f5bccc573d561e549c11b6a05c1",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/sign/ccdb3c.wgsl.expected.dxc.hlsl",
      "new_id": "cf827fd066478be69c9615033e57c3e5accaacf8",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/sign/ccdb3c.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "1c42f9a7d6c09b57339194f4505f144460503528",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/sign/d065d8.wgsl.expected.dxc.hlsl",
      "new_id": "514562e5b02b4c56261f49d858dbb73066301f39",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/sign/d065d8.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "1c42f9a7d6c09b57339194f4505f144460503528",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/sign/d065d8.wgsl.expected.fxc.hlsl",
      "new_id": "514562e5b02b4c56261f49d858dbb73066301f39",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/sign/d065d8.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "d0ef005da9eb5b24fac09fd55bac47ecaffdff8a",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/sign/dd790e.wgsl.expected.dxc.hlsl",
      "new_id": "7a84431e30243b0136abc693602cc5353fc80122",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/sign/dd790e.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "d0ef005da9eb5b24fac09fd55bac47ecaffdff8a",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/sign/dd790e.wgsl.expected.fxc.hlsl",
      "new_id": "7a84431e30243b0136abc693602cc5353fc80122",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/sign/dd790e.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "a90f55cb12327c4f58c1529ca62b4b019e1b85e0",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/textureLoad/1bfdfb.wgsl.expected.dxc.hlsl",
      "new_id": "93cec7b8998009f8cc8157b5102d02e1b9ca29dd",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/textureLoad/1bfdfb.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "a90f55cb12327c4f58c1529ca62b4b019e1b85e0",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/textureLoad/1bfdfb.wgsl.expected.fxc.hlsl",
      "new_id": "93cec7b8998009f8cc8157b5102d02e1b9ca29dd",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/textureLoad/1bfdfb.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "55e0aa30b9f9cc000d744c79b8161deb3b735374",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/textureLoad/8acf41.wgsl.expected.dxc.hlsl",
      "new_id": "062af5567d02a76825b587fb6d17cdc9ec75aea0",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/textureLoad/8acf41.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "55e0aa30b9f9cc000d744c79b8161deb3b735374",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/textureLoad/8acf41.wgsl.expected.fxc.hlsl",
      "new_id": "062af5567d02a76825b587fb6d17cdc9ec75aea0",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/textureLoad/8acf41.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "9322a94fc445b829a62331119ff9549e6f443e3d",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/textureSampleBaseClampToEdge/7c04e6.wgsl.expected.dxc.hlsl",
      "new_id": "678344ff299ae01c427f9bf1728c7c5447ca827c",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/textureSampleBaseClampToEdge/7c04e6.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "9322a94fc445b829a62331119ff9549e6f443e3d",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/gen/var/textureSampleBaseClampToEdge/7c04e6.wgsl.expected.fxc.hlsl",
      "new_id": "678344ff299ae01c427f9bf1728c7c5447ca827c",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/gen/var/textureSampleBaseClampToEdge/7c04e6.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "ca1acb36b725a708035f5077cfa899a2f38ff12a",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/textureLoad/texture_external_param.wgsl.expected.dxc.hlsl",
      "new_id": "c61c15ddc00d543356fd0dfc5ee2f35f32df99af",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/textureLoad/texture_external_param.wgsl.expected.dxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "ca1acb36b725a708035f5077cfa899a2f38ff12a",
      "old_mode": 33188,
      "old_path": "test/tint/builtins/textureLoad/texture_external_param.wgsl.expected.fxc.hlsl",
      "new_id": "c61c15ddc00d543356fd0dfc5ee2f35f32df99af",
      "new_mode": 33188,
      "new_path": "test/tint/builtins/textureLoad/texture_external_param.wgsl.expected.fxc.hlsl"
    },
    {
      "type": "modify",
      "old_id": "3dfe1470f71108615f5afef900d76b99abdc428d",
      "old_mode": 33188,
      "old_path": "webgpu-cts/expectations.txt",
      "new_id": "71919a86b99c1bd73885a1e54104426aab435759",
      "new_mode": 33188,
      "new_path": "webgpu-cts/expectations.txt"
    }
  ]
}