tree 2f73b51e4171a5db1ff5aa7e24d214038cbd9322
parent d95180deded12701abc5e13ee7fa9bd1bcdbb9cb
author Corentin Wallez <cwallez@chromium.org> 1597753806 +0000
committer Commit Bot service account <commit-bot@chromium.org> 1597753806 +0000

OpenGL: Unconditionally set glFrontFace

Previously glFrontFace was called only if some cull mode was set. This
was incorrect because the front face also influences whether a triangle
uses stencilFront or stencilBack.

Because OpenGL default to GL_CCW (which with the Y-flip is the inverse
of wgpu::FrontFace::CCW that's default in the descriptor), if
stencilFront != stencilBack and cull mode is none, then the incorrect
stencil face descriptor was used.

Also adds a regression test for this issue.

Bug: dawn:508
Change-Id: I00d93bda6d4f030cf9db472a9f2b0deefc72707f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/26880
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>