tree 1f9b710223fb9eb39991cda03cc87bb17ab489aa
parent 68be1b2f70bec0e8b5c023ef2baeafc17370a652
author Brandon Jones <bajones@chromium.org> 1707779543 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1707779543 +0000

Revert "[toggles] Set labels on backend objects only if toggle is set"

This reverts commit 99ccab7256a68fb9a42eb7b239e92f09cd1e6266.

Reason for revert: Breaks Vulkan device loss handling and possibly is preventing a roll into Chromium.

Unfortunately the setting of debug labels for the Vulkan backend isn't purely for developer convenience. We embed a device ID (from GetDebugPrefix()) in the label so that if a device loss is detected (which Vulkan exposes with a generic callback listing the associated objects but not device) we can link it back to the device in question via the ID embedded in the object name.

See:
 - https://source.chromium.org/chromium/chromium/src/+/main:third_party/dawn/src/dawn/native/vulkan/BackendVk.cpp;l=254?q=GetDeviceDebugPrefixFromDebugName&ss=chromium
 - https://source.chromium.org/chromium/chromium/src/+/main:third_party/dawn/src/dawn/native/vulkan/UtilsVulkan.cpp;l=261?q=GetDeviceDebugPrefixFromDebugName&ss=chromium

This isn't a great system (and it really needs some better comments in the area of the code that was edited to explain it) but it works and I haven't found a good alternative so far. Suggestions welcome!

Also, it's not clear to me how or if it's related, but Dawn->Chromium rolls have been failing since this landed. 

See:
 - https://chromium-review.googlesource.com/c/chromium/src/+/5285356?tab=checks
 - https://autoroll.skia.org/r/dawn-chromium-autoroll

The errors don't look explicitly WebGPU related, but it also doesn't appear to be a failure that's showing up in builds outside of the roll. I wouldn't want to revert this just on speculation of the roll failure, but given that it also has a known issue with the Vulkan backend I'd prefer to revert in order to fix that and see if it clears up the roll at the same time.

Original change's description:
> [toggles] Set labels on backend objects only if toggle is set
>
> We have found that in Chrome, setting these labels can be a source of
> non-trivial overhead on performance benchmarks. This CL guards setting
> of these labels with the `use_user_defined_labels_in_backend` toggle.
> Note that labels will still be set on frontend objects, and hence will
> still be available in e.g. Dawn error messages. The labels on the
> backend objects are relevant only when debugging via platform-specific
> facilities (e.g., XCode).
>
> This CL also changes the `use_user_defined_labels_in_backend` toggle to
> default to true if validation is enabled. This is necessary as at least
> on Vulkan Dawn's debugging facilities assume that these labels are
> set [1]. It is consistent in any case, as a client enabling validation
> indicates that they are more concerned about debuggability than
> performance.
>
> [1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/dawn/src/dawn/native/vulkan/BackendVk.cpp;l=263?q=BackendVk.cpp&ss=chromium
>
> NOTE: This CL is a reland following the suppression of a pre-existing
> failure that was tickled by this CL (a Vulkan backend error message was
> previously swallowed in Dawn backend code, but the lack of a debug label
> for devices meant that the error was now surfaced). The reland is
> unchanged save for incorporating
> https://dawn-review.googlesource.com/c/dawn/+/173820.
>
> Bug: dawn:2383
> Change-Id: I8196c6ec165add0d5e9e73952be77df20e1c2dc3
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/174280
> Kokoro: Kokoro <noreply+kokoro@google.com>
> Commit-Queue: Colin Blundell <blundell@chromium.org>
> Reviewed-by: Corentin Wallez <cwallez@chromium.org>

TBR=cwallez@chromium.org,blundell@chromium.org,noreply+kokoro@google.com,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: Ie118cb6aff04635e2e6fe11481f456f980f0560b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: dawn:2383
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/174740
Reviewed-by: Shrek Shao <shrekshao@google.com>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>