)]}'
{
  "commit": "7b5df898b667de4e7e25dd5a0876e4bf4516a443",
  "tree": "3ca77199f2adaa927ac5a041fe93a189578e4175",
  "parents": [
    "e2c7a2a0b8ba71134362bc75c3989c6c006b5fb4"
  ],
  "author": {
    "name": "Zhaoming Jiang",
    "email": "zhaoming.jiang@microsoft.com",
    "time": "Sat Apr 19 00:42:58 2025 -0700"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Sat Apr 19 00:42:58 2025 -0700"
  },
  "message": "Reland \"Dawn: Use no Tint Program at all in shader compilation cache checking\"\n\nThis reverts commit 22ee238376b8b5be900c802598e6e2514547ad37.\n\nReason for revert:\n\nThe right-shifting rhs not less than bits of lhs issue that cause the\nroll into Skia is fixed in this CL.\n\nBug: 402772740, 402772408\nOriginal change\u0027s description:\n\u003e Revert \"Dawn: Use no Tint Program at all in shader compilation cache checking\"\n\u003e\n\u003e This reverts commit 7fcdc9036915542a08d5b213bb717fea33a125ef.\n\u003e\n\u003e Reason for revert: This broke the roll into Skia due to UB caused by a right-shift of 64 in the Rotl function:\n\u003e https://logs.chromium.org/logs/skia/705dbe4282a5c611/+/steps/dm/0/stdout\n\u003e\n\u003e Bug: 402772740, 402772408\n\u003e Original change\u0027s description:\n\u003e \u003e Dawn: Use no Tint Program at all in shader compilation cache checking\n\u003e \u003e\n\u003e \u003e This CL remove Tint Program from all backends\u0027 shader compilation cache\n\u003e \u003e key and replace it with SHA3-512 hash of shader module. With this CL,\n\u003e \u003e Tint Program might not be need until actual cache miss in backend shader\n\u003e \u003e compilation or front end WGSL parsing cache miss.\n\u003e \u003e\n\u003e \u003e Bug: 402772740, 402772408\n\u003e \u003e Change-Id: I76ec38c03b15cd3dc4ba8c294dafb3ce9cc61dce\n\u003e \u003e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/232375\n\u003e \u003e Reviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\n\u003e \u003e Commit-Queue: Zhaoming Jiang \u003czhaoming.jiang@microsoft.com\u003e\n\u003e \u003e Auto-Submit: Zhaoming Jiang \u003czhaoming.jiang@microsoft.com\u003e\n\u003e\n\u003e TBR\u003dcwallez@chromium.org,geofflang@chromium.org,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com,zhaoming.jiang@microsoft.com\n\u003e\n\u003e No-Presubmit: true\n\u003e No-Tree-Checks: true\n\u003e No-Try: true\n\u003e Bug: 402772740, 402772408\n\u003e Change-Id: I39f25c1a45b02eb42d10374a67a94e53dfb09300\n\u003e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/237734\n\u003e Reviewed-by: James Price \u003cjrprice@google.com\u003e\n\u003e Reviewed-by: dan sinclair \u003cdsinclair@chromium.org\u003e\n\u003e Commit-Queue: James Price \u003cjrprice@google.com\u003e\n\nBug: 402772740, 402772408\nChange-Id: Ia98ced1fdbbcd7822b656886d9ea660bb2899c1c\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/237894\nReviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\nAuto-Submit: Zhaoming Jiang \u003czhaoming.jiang@microsoft.com\u003e\nCommit-Queue: Zhaoming Jiang \u003czhaoming.jiang@microsoft.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "fd15e8193f8ea50201cbb7dddedbf484689c92fb",
      "old_mode": 33188,
      "old_path": "src/dawn/common/Sha3.cpp",
      "new_id": "f727e45d194e14b066a572ba247964e68a4a72f8",
      "new_mode": 33188,
      "new_path": "src/dawn/common/Sha3.cpp"
    },
    {
      "type": "modify",
      "old_id": "f54f056f2f9a4b172741f1f41788e2a3512c3c27",
      "old_mode": 33188,
      "old_path": "src/dawn/common/Sha3.h",
      "new_id": "1f226dd50876045e45782cf62e137a5c7bf3754b",
      "new_mode": 33188,
      "new_path": "src/dawn/common/Sha3.h"
    },
    {
      "type": "modify",
      "old_id": "993fdf2bee4a8e8d083928b3860058f75e2571b5",
      "old_mode": 33188,
      "old_path": "src/dawn/native/ObjectContentHasher.h",
      "new_id": "a838998ef3059e51252ec5c2d5a12a56cbd4520d",
      "new_mode": 33188,
      "new_path": "src/dawn/native/ObjectContentHasher.h"
    },
    {
      "type": "modify",
      "old_id": "f7c7a90dfaea6098a705d5654b7d97097ae707bd",
      "old_mode": 33188,
      "old_path": "src/dawn/native/ShaderModule.cpp",
      "new_id": "a61d41a4bee6fa37bc2bc23e7365ed22d019deeb",
      "new_mode": 33188,
      "new_path": "src/dawn/native/ShaderModule.cpp"
    },
    {
      "type": "modify",
      "old_id": "6579c895e2a053361440cdcb1966cb8f9c725679",
      "old_mode": 33188,
      "old_path": "src/dawn/native/ShaderModule.h",
      "new_id": "992a1e7b6b128bd5b14296b1f73db17e676e9d7e",
      "new_mode": 33188,
      "new_path": "src/dawn/native/ShaderModule.h"
    },
    {
      "type": "modify",
      "old_id": "69bbbf2a9c7678103864edead70738a5fbdb57c6",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d/D3DCompilationRequest.h",
      "new_id": "a8d04d89f165cc1ed23941ef4df7a79436d48547",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d/D3DCompilationRequest.h"
    },
    {
      "type": "modify",
      "old_id": "db35157f4c1153dc44f8e0200702492542883881",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d/ShaderUtils.cpp",
      "new_id": "1c1a4abe5bb53e18abdf96676c591290b3d651e8",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d/ShaderUtils.cpp"
    },
    {
      "type": "modify",
      "old_id": "57f5a3afeb5c333b5b6067c0d253134ab31087d0",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d11/ShaderModuleD3D11.cpp",
      "new_id": "20ae98cf1e8e73393f9a959b5b9b87e3707d67aa",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d11/ShaderModuleD3D11.cpp"
    },
    {
      "type": "modify",
      "old_id": "c5ffcca7be331a5d51d3edf489301ff5a1d33123",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d12/ShaderModuleD3D12.cpp",
      "new_id": "4adf5d58a7525bad573c96bf6498dbfd2b75f79c",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d12/ShaderModuleD3D12.cpp"
    },
    {
      "type": "modify",
      "old_id": "d8c0361eabf7829c63e152415a1300a391fc5443",
      "old_mode": 33188,
      "old_path": "src/dawn/native/metal/ShaderModuleMTL.mm",
      "new_id": "8047db982161673f146162e6ad7b6e848f4f5f5e",
      "new_mode": 33188,
      "new_path": "src/dawn/native/metal/ShaderModuleMTL.mm"
    },
    {
      "type": "modify",
      "old_id": "ee9adbdd903868b031b3dcd1e35e7961b05ea4ef",
      "old_mode": 33188,
      "old_path": "src/dawn/native/opengl/ShaderModuleGL.cpp",
      "new_id": "5727c9344a332d7cb2e9aa7c29e7365ea5a3ce18",
      "new_mode": 33188,
      "new_path": "src/dawn/native/opengl/ShaderModuleGL.cpp"
    },
    {
      "type": "modify",
      "old_id": "8dde2be24b59a896ef8abf3652d7b552d5c91ff3",
      "old_mode": 33188,
      "old_path": "src/dawn/native/stream/Stream.h",
      "new_id": "77106f9aa4a52ee480aea7910b4e5e673d8fcbba",
      "new_mode": 33188,
      "new_path": "src/dawn/native/stream/Stream.h"
    },
    {
      "type": "modify",
      "old_id": "5792978507cd57404d1685ab37faa0f7f8812d9a",
      "old_mode": 33188,
      "old_path": "src/dawn/native/vulkan/ShaderModuleVk.cpp",
      "new_id": "b7ca147937df3156f0ae254381af6f54f11903f5",
      "new_mode": 33188,
      "new_path": "src/dawn/native/vulkan/ShaderModuleVk.cpp"
    },
    {
      "type": "modify",
      "old_id": "c100f39d61afb6cc4c4dc1165e6e6d75634bf866",
      "old_mode": 33188,
      "old_path": "src/dawn/tests/unittests/native/StreamTests.cpp",
      "new_id": "4bc3a82e24bf03e8f5f825fbc9a215d41bc1fa3d",
      "new_mode": 33188,
      "new_path": "src/dawn/tests/unittests/native/StreamTests.cpp"
    }
  ]
}
