)]}'
{
  "commit": "7bc95566d35e4786a9e25a7bcfe57c16e2948c01",
  "tree": "cb633d7741fab6a03b9bbc0d3bf4f59801addbc8",
  "parents": [
    "c534e5d5d6087fd4bec624da8a6a9d3b640a1090"
  ],
  "author": {
    "name": "Quyen Le",
    "email": "lehoangquyen@chromium.org",
    "time": "Mon Jul 14 14:11:37 2025 -0700"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Mon Jul 14 14:11:37 2025 -0700"
  },
  "message": "Revert \"Reland \"Reland \"Improve DX compiler library loading\"\"\"\n\nThis reverts commit a45d5b2b40d12d0f650e3f8cdd70a20c853ff5a0.\n\nReason for revert: Causing dawn_end2end_*validation_layers_tests to\ntime out on UHD 770 bots\nhttps://ci.chromium.org/ui/p/chromium/builders/luci.chromium.ci/Dawn%20Win10%20x64%20Release%20%28Intel%20UHD%20770%29\n\nBug: 356665092\nOriginal change\u0027s description:\n\u003e Reland \"Reland \"Improve DX compiler library loading\"\"\n\u003e\n\u003e This is a reland of commit e579b628e5d5276086b6a2eaefa1718586bc7e18\n\u003e\n\u003e Add dawn_force_system_component_load for projects (like Skia) which\n\u003e require that Dawn load all compiler DLL from System32. Best security\n\u003e is to leave the default value which (now) loads compiler DLLs from the\n\u003e same directory as Dawn code.\n\u003e\n\u003e On Chromium builds (such as x86) which do not build DXC, place the\n\u003e DLLs from the SDK into the build folder to appease infra tools that\n\u003e copy the DLLs unconditionally.\n\u003e\n\u003e Improve DAWN_USE_BUILT_DXC to use the #define to skip loading the DLLs\n\u003e altogether.\n\u003e\n\u003e Original change\u0027s description:\n\u003e \u003e Reland \"Improve DX compiler library loading\"\n\u003e \u003e\n\u003e \u003e This is a reland of commit e4d4669d79501b1acdd2bf017ba491b611d741da\n\u003e \u003e\n\u003e \u003e Remove build_with_chromium statements in test GN files that copy\n\u003e \u003e DLLs. Rely on copies instructions which already exist with the D3D12\n\u003e \u003e files.\n\u003e \u003e\n\u003e \u003e To appease Skia builds which do not depend on the Windows SDK,\n\u003e \u003e fallback to system FXC if the local directory version is not found.\n\u003e \u003e\n\u003e \u003e Original change\u0027s description:\n\u003e \u003e \u003e Improve DX compiler library loading\n\u003e \u003e \u003e\n\u003e \u003e \u003e Previously, DX compiler DLLs were loaded using LoadLibrary with no path.\n\u003e \u003e \u003e D3D12 compiler DLLs were further sourced from the local user\u0027s SDK\n\u003e \u003e \u003e directory as a fallback.\n\u003e \u003e \u003e\n\u003e \u003e \u003e For better security, load DX compiler DLLs using full paths, with\n\u003e \u003e \u003e SEARCH_DLL_LOAD_DIR | SEARCH_DEFAULT_DIRS for better security. Scenarios\n\u003e \u003e \u003e such as Skia and x86 builds where we need dawn_use_built_dxc will\n\u003e \u003e \u003e fallback to FXC. No fallbacks to local user SDK directories.\n\u003e \u003e \u003e\n\u003e \u003e \u003e Bug:356665092\n\u003e \u003e \u003e Change-Id: Ib4148f9b89da694e3868b4f3c3c329a4b06ce922\n\u003e \u003e \u003e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/229754\n\u003e \u003e \u003e Reviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\n\u003e \u003e \u003e Commit-Queue: Rafael Cintron \u003crafael.cintron@microsoft.com\u003e\n\u003e \u003e \u003e Reviewed-by: Antonio Maiorano \u003camaiorano@google.com\u003e\n\u003e \u003e\n\u003e \u003e Bug: 356665092\n\u003e \u003e Change-Id: Ic05d20c47c5db3021f9e38b724bf527bfba52a5e\n\u003e \u003e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/233216\n\u003e \u003e Reviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\n\u003e \u003e Reviewed-by: Antonio Maiorano \u003camaiorano@google.com\u003e\n\u003e \u003e Commit-Queue: Rafael Cintron \u003crafael.cintron@microsoft.com\u003e\n\u003e\n\u003e Bug: 356665092\n\u003e Change-Id: I83db06312db28123f9d5aee29617a8746768bb3d\n\u003e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/234919\n\u003e Reviewed-by: Antonio Maiorano \u003camaiorano@google.com\u003e\n\u003e Reviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\n\u003e Commit-Queue: Rafael Cintron \u003crafael.cintron@microsoft.com\u003e\n\n# Not skipping CQ checks because original CL landed \u003e 1 day ago.\n\nBug: 356665092\nChange-Id: I1b193762bc185cf55ce8141ae9b39d33e73c204c\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/252494\nCommit-Queue: dan sinclair \u003cdsinclair@chromium.org\u003e\nAuto-Submit: Quyen Le \u003clehoangquyen@chromium.org\u003e\nReviewed-by: dan sinclair \u003cdsinclair@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "8dc8c3cbd6cf65833f29a2b5333222c7d6d66d09",
      "old_mode": 33188,
      "old_path": "CMakeLists.txt",
      "new_id": "baca383a81982dd88b2d62a0e7e9b3b4fe7826f2",
      "new_mode": 33188,
      "new_path": "CMakeLists.txt"
    },
    {
      "type": "modify",
      "old_id": "f4f375f95e90f0c196b44d85516ef6a68ebcbcbe",
      "old_mode": 33188,
      "old_path": "scripts/dawn_features.gni",
      "new_id": "873d516366a5ee52963b663e931163c3236dfdce",
      "new_mode": 33188,
      "new_path": "scripts/dawn_features.gni"
    },
    {
      "type": "modify",
      "old_id": "3bf65f0a90294a1f42936a8dc058683b9ee5ce81",
      "old_mode": 33188,
      "old_path": "src/dawn/common/BUILD.gn",
      "new_id": "92eff1a57b5bd62594337358cb8f54dea4c67f65",
      "new_mode": 33188,
      "new_path": "src/dawn/common/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "f7db34c59879f6c8e4e06a25d16a3c63227b8bb6",
      "old_mode": 33188,
      "old_path": "src/dawn/common/DynamicLib.cpp",
      "new_id": "c1457dfb677cf4e82d0a69713fda2a99fb0bfaca",
      "new_mode": 33188,
      "new_path": "src/dawn/common/DynamicLib.cpp"
    },
    {
      "type": "modify",
      "old_id": "04c40564ecac53d593427e8f38e7dbc1bc4d3e52",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d/D3DCompilationRequest.h",
      "new_id": "ebe654d4e1005fadb75ca205bebc0b3a55f6432f",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d/D3DCompilationRequest.h"
    },
    {
      "type": "modify",
      "old_id": "635b9db9ac3f930790abfec5f820f5ed893c2dcb",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d/PlatformFunctions.cpp",
      "new_id": "2c414ca2a50a2cb20ed541bddf65862f332f2e13",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d/PlatformFunctions.cpp"
    },
    {
      "type": "modify",
      "old_id": "d9f835075f86b0c0a2b671fb4f760e677f966381",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d11/ShaderModuleD3D11.cpp",
      "new_id": "f02ab30dca339bbacd83858e56d0c50fa9f08d98",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d11/ShaderModuleD3D11.cpp"
    },
    {
      "type": "modify",
      "old_id": "92636bee058424d9e282735a77779920992abe87",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d12/BackendD3D12.cpp",
      "new_id": "a94fb139ee7f2d2665868fcab56ea6abe54aa78f",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d12/BackendD3D12.cpp"
    },
    {
      "type": "modify",
      "old_id": "edfa645f75a06b39601b8564730925cad42f4ff1",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d12/BackendD3D12.h",
      "new_id": "57dd2e520051b77f6406099a67082f98d3ffb730",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d12/BackendD3D12.h"
    },
    {
      "type": "modify",
      "old_id": "d498fd487419a600a348910582c38d33b8e60332",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d12/DeviceD3D12.cpp",
      "new_id": "9f55937faa639ee3af129e51b2e6711c2963629b",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d12/DeviceD3D12.cpp"
    },
    {
      "type": "modify",
      "old_id": "d6db845d403f3d5740bc34ca5a47a0b760833ea1",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d12/PhysicalDeviceD3D12.cpp",
      "new_id": "7a9818a437e430a5fa9eadd0cb891e5e5c421ea5",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d12/PhysicalDeviceD3D12.cpp"
    },
    {
      "type": "modify",
      "old_id": "f135ccfb8f9c91437979348be32887e73fa758cd",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d12/PlatformFunctionsD3D12.cpp",
      "new_id": "c84c8e47c5a5f9670667835816116328961f3a3a",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d12/PlatformFunctionsD3D12.cpp"
    },
    {
      "type": "modify",
      "old_id": "0f06a698f672f9d02f9399d51116a88b3eaa085f",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d12/PlatformFunctionsD3D12.h",
      "new_id": "b242deee97f6112f44fab1bd8180c8a1be82fef3",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d12/PlatformFunctionsD3D12.h"
    },
    {
      "type": "modify",
      "old_id": "56ced4f0148e9e9c4850fd5c7a5560f828d9efb9",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d12/ShaderModuleD3D12.cpp",
      "new_id": "644951ee648389a94cf899f2aec486b9956efef5",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d12/ShaderModuleD3D12.cpp"
    },
    {
      "type": "modify",
      "old_id": "d164ea9402f15ebefb46de4f01da7adc188a6a33",
      "old_mode": 33188,
      "old_path": "src/dawn/tests/BUILD.gn",
      "new_id": "f580f2678130b9a3dc3d3436ad2f7f152cf3f105",
      "new_mode": 33188,
      "new_path": "src/dawn/tests/BUILD.gn"
    }
  ]
}