commit | 872c1d7fe98a41359364e96609231f9700160d7a | [log] [tgz] |
---|---|---|
author | Jiawei Shao <jiawei.shao@intel.com> | Tue Jun 18 01:06:09 2019 +0000 |
committer | Commit Bot service account <commit-bot@chromium.org> | Tue Jun 18 01:06:09 2019 +0000 |
tree | fc6be74546139f88968194c7229d936459019ff0 | |
parent | 8f4046b0b66765d2cb00c9a477e757c4e3e99fe9 [diff] |
Add validations to the texture copies with BC formats This patch adds the validation on the texture copies with BC formats. 1. BufferCopyView.offset in B2T and T2B copies must be a multiple of the compressed texel block size in bytes. 2. BufferCopyView.rowPitch in B2T and T2B copies refers to the number of bytes from the start of one row of blocks to the start of the next row of blocks. 3. BufferCopyView.imageHeight must be a multiple of the compressed texel block height (4 for BC formats). 4. All members in TextureCopyView.origin must be a multiple of the corresponding dimensions of the compressed texel block (4x4x1 for BC formats). 5. All the mumbers in 'copySize' must be a multiple of the corresponding dimensions of the compressed texel block (4x4x1 for BC formats) because D3D12 requires the width and height of a texture in BC formats must be multiples of 4. 6. Compute the texture size in non-zero mipmap levels with paddings for textures in BC formats when necessary. BUG=dawn:42 TEST=dawn_unittests Change-Id: Iac8d6c93ab8b37bb46becffd4175339722ab6016 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7860 Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Dawn (formerly NXT) is an open-source and cross-platform implementation of the work-in-progress WebGPU standard. It exposes a C/C++ API that maps almost one-to-one to the WebGPU IDL and can be managed as part of a larger system such as a Web browser.
Dawn provides several WebGPU building blocks:
dawn.json
: description of the API used to drive code generators.examples
: examples showing how Dawn is used.generator
: code generator for files produces from dawn.json
templates
: Jinja2 templates for the generatorscripts
: scripts to support things like continuous testing, build files, etc.src
:common
: helper code shared between core Dawn libraries and tests/samplesdawn_native
: native implementation of WebGPU, one subfolder per backenddawn_wire
: client-server implementation of WebGPUinclude
: public headers for Dawntests
: internal Dawn testsend2end
: WebGPU tests performing GPU operationsunittests
: unittests and by extension tests not using the GPUvalidation
: WebGPU validation tests not using the GPU (frontend tests)utils
: helper code to use Dawn used by tests and samplesthird_party
: directory where dependencies live as well as their buildfiles.Dawn uses the Chromium build system and dependency management so you need to install depot_tools and add it to the PATH.
On Linux you need to have the pkg-config
command:
# Install pkg-config on Ubuntu sudo apt-get install pkg-config
Then get the source as follows:
# Clone the repo as "dawn" git clone https://dawn.googlesource.com/dawn dawn && cd dawn # Bootstrap the gclient configuration cp scripts/standalone.gclient .gclient # Fetch external dependencies and toolchains with gclient gclient sync
Then generate build files using gn args out/Debug
or gn args out/Release
. A text editor will appear asking build options, the most common option is is_debug=true/false
; otherwise gn args out/Release --list
shows all the possible options.
Then use ninja -C out/Release
to build dawn and for example ./out/Release/dawn_end2end_tests
to run the tests.
Please read and follow CONTRIBUTING.md. Dawn doesn‘t have a formal coding style yet, except what’s defined by our clang format style. Overall try to use the same style and convention as code around your change.
If you find issues with Dawn, please feel free to report them on the bug tracker. For other discussions, please post to Dawn's mailing list.
Please see LICENSE.
This is not an officially supported Google product.