tree 02b87b81e6b051a02abc4e1fc8dec31566d71f13
parent 4874ce46ae35589e138798552750e50b458827cc
author Ben Clayton <bclayton@google.com> 1707515828 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1707515828 +0000

[tint][ast] Fix DemoteToHelper with atomicCompareExchangeWeak()

Since the resolver was able to parse 'untypable' builtin structures with https://dawn-review.googlesource.com/c/dawn/+/129482, some transforms (like PromoteInitializersToLet) are able to create lets of these 'untypeable' builtin types.

The DemoteToHelper transform had its own workaround for the 'untypeable' atomicCompareExchangeWeak() result type, by creating a user-declared structure with the same shape. This workaround can fail if a previous transform builds a variable with the 'untypeable' result type, as the user-declared type cannot be assigned to it.

Fortunately the fix here is simple - we can just remove the workaround in DemoteToHelper, which makes the transform emit the 'untypeable' result type, and so the assignment matches types.

Bug: chromium:324439761
Fixed: tint:2147
Change-Id: I89ca496c60ce140bfb7c5d6de54f4931afc85fbf
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/173180
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
(cherry picked from commit f83de0f6583483d76b647ad716702723ec276a42)
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/174024
Reviewed-by: David Neto <dneto@google.com>
Kokoro: Ben Clayton <bclayton@google.com>