)]}' { "commit": "8c58491d25e5079fbda8ebc948bc39773e21542e", "tree": "6dd2778b1fec24c726873ca9131c7f16a77483c0", "parents": [ "3639186e7e6ae8fb83a46b796f3ca3b896bdc5ae" ], "author": { "name": "Austin Eng", "email": "enga@chromium.org", "time": "Thu Jan 14 00:51:58 2021 +0000" }, "committer": { "name": "Commit Bot service account", "email": "commit-bot@chromium.org", "time": "Thu Jan 14 00:51:58 2021 +0000" }, "message": "dawn_wire: Skip device inject error if the client drops the device\n\nIf the client drops the last reference to the device, it would\ndereference an invalid pointer upon calling InjectError. So, skip the\ncall. We can\u0027t keep the device alive if the Buffer is still alive\nbecause we intend to make all objects internally null if you delete\ntheir device.\n\nIt is ok to skip error injection because if the client deletes the\ndevice, it should not expect to receive any more error callbacks.\n\nBug: dawn:384\nChange-Id: I4c694310e4395b06cd49603fc5d4cd846799decb\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/37580\nReviewed-by: Jiawei Shao \u003cjiawei.shao@intel.com\u003e\nReviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\nCommit-Queue: Austin Eng \u003cenga@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "40b575971278fb7e8aff689ed726c28244682104", "old_mode": 33188, "old_path": "src/dawn_wire/client/Buffer.cpp", "new_id": "da3691c5848de88827d52ddcc8526c279a5a950e", "new_mode": 33188, "new_path": "src/dawn_wire/client/Buffer.cpp" }, { "type": "modify", "old_id": "d6a275c15d1986693de25d19bcc9af91ba7ebc69", "old_mode": 33188, "old_path": "src/dawn_wire/client/Buffer.h", "new_id": "5e0d5ec2a342e0849acda58911b545c10c16e97e", "new_mode": 33188, "new_path": "src/dawn_wire/client/Buffer.h" }, { "type": "modify", "old_id": "08a3e33831cf98012c350d6e6f04b60814f8ab08", "old_mode": 33188, "old_path": "src/dawn_wire/client/Device.cpp", "new_id": "b6ee4fceeacb8a604438c20c0cfc291bd90163ea", "new_mode": 33188, "new_path": "src/dawn_wire/client/Device.cpp" }, { "type": "modify", "old_id": "6862bb3d3b7fd240d95a5cc60962d1fbe63496e6", "old_mode": 33188, "old_path": "src/dawn_wire/client/Device.h", "new_id": "3f167004a8be4dc7c9faeae31a84d453b53193ee", "new_mode": 33188, "new_path": "src/dawn_wire/client/Device.h" }, { "type": "modify", "old_id": "9bb40b3e4a5ddb11cf3c22e3dade595ab47f4970", "old_mode": 33188, "old_path": "src/dawn_wire/client/Fence.cpp", "new_id": "d9a858a245810349603696d1403d8bf5e3f2ad12", "new_mode": 33188, "new_path": "src/dawn_wire/client/Fence.cpp" }, { "type": "modify", "old_id": "a8fb5f47220872b353e1c3e42bec4f91d3b4abae", "old_mode": 33188, "old_path": "src/dawn_wire/client/Fence.h", "new_id": "7c09948e566107f4618df7a076eb221fac362304", "new_mode": 33188, "new_path": "src/dawn_wire/client/Fence.h" }, { "type": "modify", "old_id": "37ae3fa6f4d9be2514f3ec31beaba6f4ab631125", "old_mode": 33188, "old_path": "src/dawn_wire/client/Queue.cpp", "new_id": "f5f68f782befb799f87e0c13263b932651cc17dd", "new_mode": 33188, "new_path": "src/dawn_wire/client/Queue.cpp" }, { "type": "modify", "old_id": "f5e16b7b30636780d09f984bc2b7b5c798b2e3cc", "old_mode": 33188, "old_path": "src/tests/unittests/wire/WireDestroyObjectTests.cpp", "new_id": "34b976dcc92cb8add4f30bad18bb9b03ea26bf8f", "new_mode": 33188, "new_path": "src/tests/unittests/wire/WireDestroyObjectTests.cpp" } ] }