[ir] Allow `i8` and `u8` as valid subgroup matrix element types
This patch allows `i8` and `u8` as valid subgroup matrix element
types in IR validator. With this patch all the tests about subgroup
matrix int8/uint8 can pass again.
Fixed: 403609083
Test: dawn_end2end_tests
Change-Id: I1cc93c1e62626b6f8702853e6ec03566ef048827
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/267094
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
diff --git a/src/tint/lang/core/ir/validator.cc b/src/tint/lang/core/ir/validator.cc
index 2b499af..2ae0c67 100644
--- a/src/tint/lang/core/ir/validator.cc
+++ b/src/tint/lang/core/ir/validator.cc
@@ -2324,8 +2324,6 @@
return true;
},
[&](const core::type::SubgroupMatrix* m) {
- CheckType(m->Type(), diag, ignore_caps);
-
if (!m->Type()
->IsAnyOf<core::type::F16, core::type::F32, core::type::I8,
core::type::I32, core::type::U8, core::type::U32>()) {
diff --git a/src/tint/lang/core/ir/validator_type_test.cc b/src/tint/lang/core/ir/validator_type_test.cc
index 6975a1b..5a075e8 100644
--- a/src/tint/lang/core/ir/validator_type_test.cc
+++ b/src/tint/lang/core/ir/validator_type_test.cc
@@ -838,7 +838,7 @@
b.Return(f);
});
- auto res = ir::Validate(mod, Capabilities{Capability::kAllow8BitIntegers});
+ auto res = ir::Validate(mod);
if (allowed) {
ASSERT_EQ(res, Success) << res.Failure();
} else {
