tree 676a4f0384441d9ad1730a51073bf661f77bd389
parent 540d8a692ba7b0707133bf7bbb822283ff780b0d
author Corentin Wallez <cwallez@chromium.org> 1749652889 -0700
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1749652889 -0700

[dawn] Make BitSetRangeIterator::Advance simpler to reason about

The calls to ScanForwardAndShiftBits with mBits inversion interspersed
made it difficult to reason about what's happening. The second call
to ScanForwardAndShiftBits before the last mBits inversion introduced
extra 1 bits on the left that had to be cleaned up.

Instead inline ScanForwardAndShiftBits and use countr_one instead of
shifting all of mBits. Finally guard the loop to run only when the
bitset has more than 64 bits.

Simplifies test code mildly.

Bug: None
Change-Id: I81ad70f799e287e980fd1e994b239ec2f1c31e5c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/244815
Reviewed-by: Shaobo Yan <shaoboyan@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>