tree 65cf73a73d779984ad485ef935f3b8879f5212ca
parent 9178d9bf3500e0f03e9681a8d1df5be94c021d06
author Ben Clayton <bclayton@google.com> 1617992548 +0000
committer Commit Bot service account <commit-bot@chromium.org> 1617992548 +0000

ShaderModule: Keep the tint::Source::File alive

Tint diagnostics hold a raw pointer to the tint::Source::File, so that source snippets can be printed.
The tint::Source::File pointer was taken from a stack allocation, and the diagnostics were left with a dead pointer.
Have the ShaderModuleParseResult keep the tint::Source::File alive with a PIMPL unique_ptr.

Change-Id: I80d77516afd4012e15992821e060ef3038eba1c1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/47422
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>