)]}' { "commit": "9bf529ec9421dcd6a27b9d07fbe3edf6bea598d3", "tree": "0774c99e78357fc2a4b1568a86cb60ce9d7e0949", "parents": [ "8c1a90199a43f04f86539141b394f05014cea77a" ], "author": { "name": "Austin Eng", "email": "enga@chromium.org", "time": "Sat Mar 09 00:06:38 2019 +0000" }, "committer": { "name": "Commit Bot service account", "email": "commit-bot@chromium.org", "time": "Sat Mar 09 00:06:38 2019 +0000" }, "message": "Revert \"Destroy backend implementation for Buffers\"\n\nThis reverts commit b6a80b321e8fa0b79d9a947656ea0ad649ed5a3c.\n\nReason for revert: dawn_end2end_tests are failing on the Chromium GPU FYI bots. Example here: https://ci.chromium.org/p/chromium/builders/ci/Win10%20FYI%20Release%20%28NVIDIA%29/4226\n\nOriginal change\u0027s description:\n\u003e Destroy backend implementation for Buffers\n\u003e \n\u003e Destroy can be used to free the GPU memory associated with resources\n\u003e without waiting for javascript garbage collection to occur.\n\u003e The buffer is validated at submission to the queue.\n\u003e So any buffer that has been destroyed before submission, will then\n\u003e invalidate the submit and result in an error.\n\u003e \n\u003e Bug: dawn:46\n\u003e Change-Id: I40df56ce97baef01deea7552d7a6d40b558fc985\n\u003e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5320\n\u003e Reviewed-by: Kai Ninomiya \u003ckainino@chromium.org\u003e\n\u003e Commit-Queue: Natasha Lee \u003cnatlee@microsoft.com\u003e\n\nTBR\u003dcwallez@chromium.org,kainino@chromium.org,enga@chromium.org,rafael.cintron@microsoft.com,natlee@microsoft.com\n\n# Not skipping CQ checks because original CL landed \u003e 1 day ago.\n\nBug: dawn:46\nChange-Id: Iadf37a8a6675c744207ec7daaa3fd2fde7da3714\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5480\nReviewed-by: Austin Eng \u003cenga@chromium.org\u003e\nCommit-Queue: Austin Eng \u003cenga@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "ac84461540ad85f9c3e943106293462d0fb5ee51", "old_mode": 33188, "old_path": "BUILD.gn", "new_id": "024119edcb2778684713958b4db979ce03b10ad4", "new_mode": 33188, "new_path": "BUILD.gn" }, { "type": "modify", "old_id": "4a68302bdd55a7559a0a494a0b96a16e85e250b8", "old_mode": 33188, "old_path": "src/dawn_native/Buffer.cpp", "new_id": "d619fa4bd6c04231c6dad85c94fc94333a3dbad6", "new_mode": 33188, "new_path": "src/dawn_native/Buffer.cpp" }, { "type": "modify", "old_id": "28653dc2060e48357a185dc956d4ab54b7b33966", "old_mode": 33188, "old_path": "src/dawn_native/Buffer.h", "new_id": "22bd170f531e68b689708c5fe0986b5840c30d02", "new_mode": 33188, "new_path": "src/dawn_native/Buffer.h" }, { "type": "modify", "old_id": "307118d89fa77c92ed45f0db5919d07b6b706f28", "old_mode": 33188, "old_path": "src/dawn_native/d3d12/BufferD3D12.cpp", "new_id": "c24ce83a7d27158c13593e09f98655c14fa34de0", "new_mode": 33188, "new_path": "src/dawn_native/d3d12/BufferD3D12.cpp" }, { "type": "modify", "old_id": "9667085107696acf241f47df2877501937c3ed2c", "old_mode": 33188, "old_path": "src/dawn_native/d3d12/BufferD3D12.h", "new_id": "9398fb574b1e5ea8ef6a35c055e23ec882aafc1c", "new_mode": 33188, "new_path": "src/dawn_native/d3d12/BufferD3D12.h" }, { "type": "modify", "old_id": "4cdbb5a650b0baa2173514880ef69cf8122e7cbb", "old_mode": 33188, "old_path": "src/dawn_native/metal/BufferMTL.h", "new_id": "1d9a0117be3a010352c71aad870d5bfd7351b1b6", "new_mode": 33188, "new_path": "src/dawn_native/metal/BufferMTL.h" }, { "type": "modify", "old_id": "3e91b43fcc453218c12d617b340d9f6c0c5059b3", "old_mode": 33188, "old_path": "src/dawn_native/metal/BufferMTL.mm", "new_id": "6d0aa9c79c62eb11d89800b7c1c4aa2a870970fa", "new_mode": 33188, "new_path": "src/dawn_native/metal/BufferMTL.mm" }, { "type": "modify", "old_id": "9cf38245affebf26d1a7d0f0c0a1284b03f6819f", "old_mode": 33188, "old_path": "src/dawn_native/null/DeviceNull.cpp", "new_id": "f2832d08a7f3c9cb108056775b2bcb736f3c50a6", "new_mode": 33188, "new_path": "src/dawn_native/null/DeviceNull.cpp" }, { "type": "modify", "old_id": "e38f88eb1cd6411888ef963d2c5c269968a603f6", "old_mode": 33188, "old_path": "src/dawn_native/null/DeviceNull.h", "new_id": "0b5d40fe7f4ff76fcac6fd421875ae986ba96941", "new_mode": 33188, "new_path": "src/dawn_native/null/DeviceNull.h" }, { "type": "modify", "old_id": "50e2d0b0f4a5c26c259d77747d14c72c440cd392", "old_mode": 33188, "old_path": "src/dawn_native/opengl/BufferGL.cpp", "new_id": "348126e670ace28bbb2fe2dac08b4618f2e1f077", "new_mode": 33188, "new_path": "src/dawn_native/opengl/BufferGL.cpp" }, { "type": "modify", "old_id": "5a2b4a5cce1d63d3b3184c6064aa1582d4df17a6", "old_mode": 33188, "old_path": "src/dawn_native/opengl/BufferGL.h", "new_id": "ba84267cdc12514c11f11367505187dc928622ec", "new_mode": 33188, "new_path": "src/dawn_native/opengl/BufferGL.h" }, { "type": "modify", "old_id": "e38a716ac90372a04d960ace81174e44d1e4daa0", "old_mode": 33188, "old_path": "src/dawn_native/vulkan/BufferVk.cpp", "new_id": "3b7ef7820ddbd0c9ff61466a50cddd3843417539", "new_mode": 33188, "new_path": "src/dawn_native/vulkan/BufferVk.cpp" }, { "type": "modify", "old_id": "348f9be370b9c0d236ee8e0f8695dd08ce8b8abc", "old_mode": 33188, "old_path": "src/dawn_native/vulkan/BufferVk.h", "new_id": "ee703b40679b2191ff98ceee53b5d80ee41ab3f9", "new_mode": 33188, "new_path": "src/dawn_native/vulkan/BufferVk.h" }, { "type": "delete", "old_id": "37722fd60a204e54a8d6d7c33889e3d0fccf4225", "old_mode": 33188, "old_path": "src/tests/end2end/DestroyBufferTests.cpp", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" } ] }