)]}'
{
  "commit": "9e1a35c0e85bebd9dccbe32a483046fa7fbbdf1f",
  "tree": "83aeb982d9da1092c47d016a358518bf7448fd63",
  "parents": [
    "12f32d16818e76c3e18a5292fa5476b5b13ae1db"
  ],
  "author": {
    "name": "Yuly Novikov",
    "email": "ynovikov@chromium.org",
    "time": "Thu Jun 13 12:58:33 2024 +0000"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Thu Jun 13 12:58:33 2024 +0000"
  },
  "message": "Revert \"d3d: Change D3D references to PhysicalDevice to WeakRef instead of Ref\"\n\nThis reverts commit 3c05043f3c070f78b33b3f51124b661f97ec6512.\n\nReason for revert: slows dawn_end2end_tests by 1.4\nhttps://ci.chromium.org/ui/p/chromium/builders/try/win-dawn-rel/34838/overview\ndawn_end2end_tests on NVIDIA GPU on Windows (with patch) on Windows-10-18363\nShard runtime (19m 24s) + overhead (10s): 19m 34s\n\nvs.\nhttps://ci.chromium.org/ui/p/chromium/builders/ci/Dawn%20Win10%20x64%20Release%20(NVIDIA)/83040/overview\nShard runtime (13m 58s) + overhead (9s): 14m 7s\n\nOriginal change\u0027s description:\n\u003e d3d: Change D3D references to PhysicalDevice to WeakRef instead of Ref\n\u003e\n\u003e BackendD3D holds strong references to PhysicalDeviceD3D11/12, which\n\u003e are created when enumerating adapters. Once adapters are enumerated,\n\u003e these are kept alive indefinitely. Upon creation, PhysicalDeviceD3D\n\u003e has a reference to the D3D11/12Device, which means that the\n\u003e corresponding physical adapter is kept powered on indefinitely.\n\u003e\n\u003e This CL changes the strong Ref to a WeakRef and relies on the caller\n\u003e to keep a strong reference to the PhysicalDevice to keep it alive.\n\u003e All other unused devices are cleaned up, which releases the unused\n\u003e D3DDevices.\n\u003e\n\u003e Bug: 342299153\n\u003e Change-Id: I4ff6979abb175f9b737fb3ede4b26334d858d6a4\n\u003e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/189581\n\u003e Reviewed-by: Austin Eng \u003cenga@chromium.org\u003e\n\u003e Commit-Queue: Patrick To \u003cpatrto@microsoft.com\u003e\n\n# Not skipping CQ checks because original CL landed \u003e 1 day ago.\n\nBug: 342299153, 346717086\nChange-Id: I1c94259031ef2ce834a855ebe0ee961fdf4a406f\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/193480\nCommit-Queue: Yuly Novikov \u003cynovikov@chromium.org\u003e\nReviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\nAuto-Submit: Yuly Novikov \u003cynovikov@chromium.org\u003e\nCommit-Queue: Corentin Wallez \u003ccwallez@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "301b7d3a67c04b3e5fe556b33176f8f037071855",
      "old_mode": 33188,
      "old_path": "src/dawn/native/PhysicalDevice.h",
      "new_id": "dfc5bd4ca2a39934af89d74a2030365a4e0331e2",
      "new_mode": 33188,
      "new_path": "src/dawn/native/PhysicalDevice.h"
    },
    {
      "type": "modify",
      "old_id": "29291d5894539ef3994bb7a60dd436f3e0043678",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d/BackendD3D.cpp",
      "new_id": "478d60f81f4b2fec71c4c53701e8e6d9504b336b",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d/BackendD3D.cpp"
    },
    {
      "type": "modify",
      "old_id": "295b699da02f374fa7a83668657ae5958f332824",
      "old_mode": 33188,
      "old_path": "src/dawn/native/d3d/BackendD3D.h",
      "new_id": "7ae6fdb1658e428f3fd3d77af7387c5914183311",
      "new_mode": 33188,
      "new_path": "src/dawn/native/d3d/BackendD3D.h"
    }
  ]
}