)]}' { "commit": "9e55b8ca4eaf91710c68a8978a2bef4d98b3553f", "tree": "96dfb884a881eea639005ff9f74b7b6e54deed8a", "parents": [ "377c65c4a0a610aba5c5b03a1f99339fbefa037f" ], "author": { "name": "Corentin Wallez", "email": "cwallez@chromium.org", "time": "Wed Jun 24 10:28:29 2026 -0700" }, "committer": { "name": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com", "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jun 24 10:28:29 2026 -0700" }, "message": "[dawn][wire] Use MemoryHandle instead of Read/WriteHandle\n\nA few changes that were difficult to do separately from the\nusage of MemoryHandle in wire/{client, server} were:\n\n - Make DeserializeCreateRead/WriteHandle optional now that they are no\n longer used inside of Dawn. They will be removed once the Chromium\n implementation is deleted.\n - Use `std::byte` in dawn_wire.json for the serialized handle\n creation data and data updates: this matches the interface of\n MemoryHandle and avoids the need from conversions from spans of\n uint8_t to spans of std::byte. (required adding `std::byte` as a\n native type in dawn.json).\n - Change ChunkedCommandSerializer CommandExtensions to take a\n span\u003cstd::byte\u003e instead of a void* (further spanification is in a TODO).\n - Change server::MapUserData to use size_t for offset and size, the use\n of uint64_t was a leftover from a time when the MapAsync arguments\n where using uint64_t.\n\nChanges that make use of MemoryHandle are:\n\n - Implement MemoryHandle in both Client/ServerInlineMemoryTransferService.\n - Implement MemoryHandle in both Client/ServerMemoryTransferService_mock.\n - Use MemoryHandle instead of WriteHandle in client/Queue.cpp and\n ServerQueue.cpp.\n - Use a single MemoryHandle in client::Buffer instead of both ReadHandle\n and WriteHandle.\n - Use a single MemoryHandle in server::BufferMapState.\n - Update WireMemoryTransferServiceTests mock calls to expect\n MemoryHandle calls instead.\n\nBug: 492456046, 524776858, 512465980, 524406299, 526537224, 526537254, 526549345\nChange-Id: I3097d65bc282e93d75e53adf241221b146d32460\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/317635\nReviewed-by: Loko Kung \u003clokokung@google.com\u003e\nCommit-Queue: Loko Kung \u003clokokung@google.com\u003e\nReviewed-by: Shao, Jiawei \u003cjiawei.shao@intel.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "51691196f1a2b616dd1e915b84f6cc05c5718a90", "old_mode": 33188, "old_path": "include/dawn/wire/WireClient.h", "new_id": "b6438835b4ba026e4ad5795181871fd9e1b9e048", "new_mode": 33188, "new_path": "include/dawn/wire/WireClient.h" }, { "type": "modify", "old_id": "b21bebadb38febfe482eb534391513b63695c2b4", "old_mode": 33188, "old_path": "include/dawn/wire/WireServer.h", "new_id": "9b1d66fdb1beea3824385cc0007186e1d87e05b3", "new_mode": 33188, "new_path": "include/dawn/wire/WireServer.h" }, { "type": "modify", "old_id": "8fcf1e070bf38766d50a1962a3616a73195b7c70", "old_mode": 33188, "old_path": "src/dawn/dawn.json", "new_id": "55b42131a246ce151cc5eac9ebb7a406101abe82", "new_mode": 33188, "new_path": "src/dawn/dawn.json" }, { "type": "modify", "old_id": "b4e19553e76c2a4b97d31198a024eb66aeddd23d", "old_mode": 33188, "old_path": "src/dawn/dawn_wire.json", "new_id": "2debf7739de5a84e41c3424231f1a4b1f06c40b5", "new_mode": 33188, "new_path": "src/dawn/dawn_wire.json" }, { "type": "modify", "old_id": "3c79127438f532bc3e42ff3a48db02b466e3eaac", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/wire/WireMemoryTransferServiceTests.cpp", "new_id": "4a87b35d6bb247ecf6720b7c1235cc1b92ad43fd", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/wire/WireMemoryTransferServiceTests.cpp" }, { "type": "modify", "old_id": "cac63cb1f17a0f1245efd47f8fdd39022c5d62fc", "old_mode": 33188, "old_path": "src/dawn/wire/ChunkedCommandSerializer.h", "new_id": "81bfd14477435cf3658ea661c0ee1103889246e9", "new_mode": 33188, "new_path": "src/dawn/wire/ChunkedCommandSerializer.h" }, { "type": "modify", "old_id": "fc46136acee2785d50a90fc80667dca56bc192de", "old_mode": 33188, "old_path": "src/dawn/wire/client/Buffer.cpp", "new_id": "53805f144cf0a0f905867d517c0634282df8abb0", "new_mode": 33188, "new_path": "src/dawn/wire/client/Buffer.cpp" }, { "type": "modify", "old_id": "53d3a676fd7457f8e96c080ce91a987eda06fcaf", "old_mode": 33188, "old_path": "src/dawn/wire/client/Buffer.h", "new_id": "8e41b71edfaa042722b9c404c2e925492daf2da2", "new_mode": 33188, "new_path": "src/dawn/wire/client/Buffer.h" }, { "type": "modify", "old_id": "496b2a677458e0913e895ec27084f8cbf7bff855", "old_mode": 33188, "old_path": "src/dawn/wire/client/ClientInlineMemoryTransferService.cpp", "new_id": "1a24e8dd19e4d169dd64265669a2becc93122425", "new_mode": 33188, "new_path": "src/dawn/wire/client/ClientInlineMemoryTransferService.cpp" }, { "type": "modify", "old_id": "c7ce2fe48893828da8e8d9fe118d0772ad5b7c95", "old_mode": 33188, "old_path": "src/dawn/wire/client/ClientMemoryTransferService_mock.cpp", "new_id": "967a18d229161d72e14f20cfadabd033984fc58a", "new_mode": 33188, "new_path": "src/dawn/wire/client/ClientMemoryTransferService_mock.cpp" }, { "type": "modify", "old_id": "9782ccc0687159df34cd79d32181ac79fbdb6fa4", "old_mode": 33188, "old_path": "src/dawn/wire/client/ClientMemoryTransferService_mock.h", "new_id": "b9bc6150035d16eb447aea421c495dd0791294b5", "new_mode": 33188, "new_path": "src/dawn/wire/client/ClientMemoryTransferService_mock.h" }, { "type": "modify", "old_id": "69bed60cb3a51622f4cc1effc075e8062c3f6f23", "old_mode": 33188, "old_path": "src/dawn/wire/client/Queue.cpp", "new_id": "17fcdf1e64099175062a1d1a0d9710040c322d98", "new_mode": 33188, "new_path": "src/dawn/wire/client/Queue.cpp" }, { "type": "modify", "old_id": "ae162957ab52119907d66b3031e765e0bf335227", "old_mode": 33188, "old_path": "src/dawn/wire/server/ObjectStorage.h", "new_id": "084762418614f5d3fedf309c12c3298d5b48a5c4", "new_mode": 33188, "new_path": "src/dawn/wire/server/ObjectStorage.h" }, { "type": "modify", "old_id": "d9e95e5e361abd27dcc3e9038ec7f8a7d62a12f5", "old_mode": 33188, "old_path": "src/dawn/wire/server/Server.h", "new_id": "627884a6378bb747454d009bc572f10c9ff130cb", "new_mode": 33188, "new_path": "src/dawn/wire/server/Server.h" }, { "type": "modify", "old_id": "f7d8520369afa25ebc84b866cfcf32ba4633d43a", "old_mode": 33188, "old_path": "src/dawn/wire/server/ServerBuffer.cpp", "new_id": "053f39dae4dd0c54b857f5217f84d1d9f550097f", "new_mode": 33188, "new_path": "src/dawn/wire/server/ServerBuffer.cpp" }, { "type": "modify", "old_id": "17f2f15458ff2063e8a090fbc944468f3179b387", "old_mode": 33188, "old_path": "src/dawn/wire/server/ServerInlineMemoryTransferService.cpp", "new_id": "ac9fd71523d76bc9ac2547f24e9fe2dd2d9aaac3", "new_mode": 33188, "new_path": "src/dawn/wire/server/ServerInlineMemoryTransferService.cpp" }, { "type": "modify", "old_id": "dbaee67dcfef7e49418c03ff07a35909f311b884", "old_mode": 33188, "old_path": "src/dawn/wire/server/ServerMemoryTransferService_mock.cpp", "new_id": "a1ca4d3032bd7a1d0ff86767326ffed630d5bbef", "new_mode": 33188, "new_path": "src/dawn/wire/server/ServerMemoryTransferService_mock.cpp" }, { "type": "modify", "old_id": "bb6df9fa34779d18dca6e638db77e3a3e09e1382", "old_mode": 33188, "old_path": "src/dawn/wire/server/ServerMemoryTransferService_mock.h", "new_id": "8f26e883b8f32b8217a3d444c90a7034d9a179b9", "new_mode": 33188, "new_path": "src/dawn/wire/server/ServerMemoryTransferService_mock.h" }, { "type": "modify", "old_id": "8f34f5e16a4498eb8afa6da113e5073c829786d8", "old_mode": 33188, "old_path": "src/dawn/wire/server/ServerQueue.cpp", "new_id": "79464ad116153c858074ecde077e1ac4d388d1f5", "new_mode": 33188, "new_path": "src/dawn/wire/server/ServerQueue.cpp" } ] }