)]}' { "commit": "9e5a76a2d7dc42318bf313f1fb85b3dee39d4130", "tree": "25a46d5ace620122fdc6aa10b47d0189a0defef5", "parents": [ "1a3afc99a7ef7dacaab73b71d44575c4f1bf2dd7" ], "author": { "name": "Kai Ninomiya", "email": "kainino@chromium.org", "time": "Sun Feb 15 23:45:34 2026 -0800" }, "committer": { "name": "Dawn LUCI CQ", "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sun Feb 15 23:45:34 2026 -0800" }, "message": "Add DAWN_MULTILINE for minifying WGSL strings\n\nAnd use it instead of raw strings in most places.\n\nWhile doing that, also fixed the indentation of a bunch of strings (and\ntried to make them look nice in the surrounding context) and removed a\nbit of manually-added whitespace from generated strings, since generated\nshaders are no longer nicely formatted at all.\n\nBoth clang-format and cpplint have minor issues with this approach\nbecause they can\u0027t tell that the string is not C++ code.\n- clang-format\u0027s WhitespaceSensitiveMacros option is buggy, so we\n need to pepper blank comments in a few places to prevent it from\n reformatting things it\u0027s not supposed to touch.\n- cpplint has no option to disable for multiple lines, so one rule that\n triggers often on WGSL is easiest to just disable. Maybe this will\n not matter in the future, if we fully replace cpplint with clang-tidy.\n\nIn a local Skia build (with clang 17.0.0 from the system Xcode because\nSkia isn\u0027t using a hermetic build on my Mac), this saves 22.3k:\n -159255840 out/DawnVulkan/libdawn_combined.a\n +159233520 out/DawnVulkan/libdawn_combined.a\n\nFixed: 475274568\nChange-Id: Ibd70eefc7e314f8689bf06803e681a1ec10302d0\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/284555\nAuto-Submit: Kai Ninomiya \u003ckainino@chromium.org\u003e\nReviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\nReviewed-by: Kaylee Lubick \u003ckjlubick@google.com\u003e\nCommit-Queue: Kai Ninomiya \u003ckainino@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "2c33110a6fffc6ec91b5716f5831b299aca429c7", "old_mode": 33188, "old_path": ".clang-format", "new_id": "0f7160d3c0ad233a8b071a9f9d19ef1a93b998c1", "new_mode": 33188, "new_path": ".clang-format" }, { "type": "modify", "old_id": "9828bd4eaf08bcdf88485facd7f2432880b40a40", "old_mode": 33188, "old_path": "CPPLINT.cfg", "new_id": "c5222f92e200e5eb82ee1e735d7a79de5d34f739", "new_mode": 33188, "new_path": "CPPLINT.cfg" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "b54103cf37fb8bc1151927541676f71346daa278", "new_mode": 33188, "new_path": "src/dawn/common/Strings.h" }, { "type": "modify", "old_id": "73ebc7af03a0066fa623b426ebf76fd11ff4626a", "old_mode": 33188, "old_path": "src/dawn/native/ApplyClearColorValueWithDrawHelper.cpp", "new_id": "c78114288185022a565c95538ca9ff73e33728a3", "new_mode": 33188, "new_path": "src/dawn/native/ApplyClearColorValueWithDrawHelper.cpp" }, { "type": "modify", "old_id": "1555c55588306a97250c420c52c9f2da52a6bc2d", "old_mode": 33188, "old_path": "src/dawn/native/BlitBufferToDepthStencil.cpp", "new_id": "767e9d1517783b5a29907e075e3b45fc36fc02a8", "new_mode": 33188, "new_path": "src/dawn/native/BlitBufferToDepthStencil.cpp" }, { "type": "modify", "old_id": "bca1e3d65fe0b13d81311e3b5be8d423e3c9fab8", "old_mode": 33188, "old_path": "src/dawn/native/BlitBufferToTexture.cpp", "new_id": "55da4b57e112b457dc3d1020f07bf3ba1f624bd5", "new_mode": 33188, "new_path": "src/dawn/native/BlitBufferToTexture.cpp" }, { "type": "modify", "old_id": "3381dfd5bed51044b1e81725284655c2e709f93f", "old_mode": 33188, "old_path": "src/dawn/native/BlitColorToColorWithDraw.cpp", "new_id": "e4cbcd623208dc4e2fab04594acd728ccd05c83e", "new_mode": 33188, "new_path": "src/dawn/native/BlitColorToColorWithDraw.cpp" }, { "type": "modify", "old_id": "da615c4c2e66ccf51e1f97f6eed791f04de685e8", "old_mode": 33188, "old_path": "src/dawn/native/BlitDepthToDepth.cpp", "new_id": "ad93ec3d17c796e59cc27156e4332bf639641ae2", "new_mode": 33188, "new_path": "src/dawn/native/BlitDepthToDepth.cpp" }, { "type": "modify", "old_id": "49a0597820f7473f8d59e725d144b5546a091c21", "old_mode": 33188, "old_path": "src/dawn/native/BlitTextureToBuffer.cpp", "new_id": "b7c606ab52e5a861c182ef0456ac01b9a4318ca9", "new_mode": 33188, "new_path": "src/dawn/native/BlitTextureToBuffer.cpp" }, { "type": "modify", "old_id": "0aae819e4ff12cfdbdadf0e8aa536d82b2fefc4d", "old_mode": 33188, "old_path": "src/dawn/native/ComputePassEncoder.cpp", "new_id": "0d85ddcb5e775e8ecdc00d8d73b5afe9fc07216d", "new_mode": 33188, "new_path": "src/dawn/native/ComputePassEncoder.cpp" }, { "type": "modify", "old_id": "1a7490918c65389e8f60a93a0c4e3c3562c62c89", "old_mode": 33188, "old_path": "src/dawn/native/CopyTextureForBrowserHelper.cpp", "new_id": "47157c43db15df6b107d05cf43b03f40675fefac", "new_mode": 33188, "new_path": "src/dawn/native/CopyTextureForBrowserHelper.cpp" }, { "type": "modify", "old_id": "7f7df8048eda97ebf516073749535f22bc3a7575", "old_mode": 33188, "old_path": "src/dawn/native/Device.cpp", "new_id": "223f70ea6dfbebfa457e11da191de0e75d0d3c05", "new_mode": 33188, "new_path": "src/dawn/native/Device.cpp" }, { "type": "modify", "old_id": "7495e3b9571009d96557da8f6d988e9555e471fd", "old_mode": 33188, "old_path": "src/dawn/native/IndirectDrawValidationEncoder.cpp", "new_id": "fd2576b80d563a63f07b242fa0f8912a9c93808a", "new_mode": 33188, "new_path": "src/dawn/native/IndirectDrawValidationEncoder.cpp" }, { "type": "modify", "old_id": "c8dbdb00d1e4697c0a766ed46ee59089b0a54b86", "old_mode": 33188, "old_path": "src/dawn/native/QueryHelper.cpp", "new_id": "a4688c6c75d66dfd89474d07bd6ce69d8da90dc0", "new_mode": 33188, "new_path": "src/dawn/native/QueryHelper.cpp" }, { "type": "modify", "old_id": "e0b154bead151f5477e090a1f306513405aea349", "old_mode": 33188, "old_path": "src/dawn/native/metal/MultiDrawEncoder.mm", "new_id": "e4447236d032a275eaa674014fbaf69c1a112fbb", "new_mode": 33188, "new_path": "src/dawn/native/metal/MultiDrawEncoder.mm" }, { "type": "modify", "old_id": "92bed1da08371d27b883786b517a0105bce2a5c0", "old_mode": 33188, "old_path": "src/dawn/native/metal/ShaderModuleMTL.mm", "new_id": "bdc6b9451dd8087205de24196f87b336ccfafded", "new_mode": 33188, "new_path": "src/dawn/native/metal/ShaderModuleMTL.mm" }, { "type": "modify", "old_id": "e0592486e079a5351923bef1844e953b53b3965c", "old_mode": 33188, "old_path": "src/dawn/native/vulkan/ResolveTextureLoadingUtilsVk.cpp", "new_id": "47fe26cf831acc3c6f98f7a3b6a2c337129b0c23", "new_mode": 33188, "new_path": "src/dawn/native/vulkan/ResolveTextureLoadingUtilsVk.cpp" }, { "type": "modify", "old_id": "0acc1fba68b5ec0f60b58439dcddcdb1cf3ea7f2", "old_mode": 33188, "old_path": "src/dawn/replay/BlitBufferToDepthTexture.cpp", "new_id": "208962af8902d21353a6c1d1fc9f3cf2739aef51", "new_mode": 33188, "new_path": "src/dawn/replay/BlitBufferToDepthTexture.cpp" }, { "type": "modify", "old_id": "e01c065dcf945e0f93b8ba969df377c1367e2f05", "old_mode": 33188, "old_path": "src/dawn/tests/BUILD.gn", "new_id": "2736fe50fc1039c283a13ab575cfec44049393d1", "new_mode": 33188, "new_path": "src/dawn/tests/BUILD.gn" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "17d8beab3a060b4bc328f4f318369aceac7e58c7", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/StringsTests.cpp" } ] }