)]}'
{
  "commit": "a5f24e590ae0d0432dc9f95ec38022e752b12bd3",
  "tree": "fde27a2674c83daa1cd514a49dae2e2841a1f892",
  "parents": [
    "8d72a7eec31643a38f6a522195636d7b30008a4f"
  ],
  "author": {
    "name": "Austin Eng",
    "email": "enga@chromium.org",
    "time": "Fri Jul 02 02:29:40 2021 +0000"
  },
  "committer": {
    "name": "Dawn LUCI CQ",
    "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Fri Jul 02 02:29:40 2021 +0000"
  },
  "message": "Validate textures with filtering/non-filtering/comparison samplers\n\nRenames dawn_native::ComponentTypeBit to SampleTypeBit and makes\nthe bitmask match wgpu::TextureSampleType. wgpu::TextureComponentType\nshould be removed in a follow-up CL.\n\nThe Format table is augmented with float/unfilterable-float information\nso that textures can be validated against the BGLEntry\u0027s\nTextureSampleType.\n\nEntryPointMetadata::ShaderBindingInfo no longer inherits BindingInfo\nbecause the two types are diverging further. Most notably, this CL\nreflects from Tint the supported SampleTypeBits for texture bindings.\nThis bitset is validated against the bind group layout.\n\nAdds an isFiltering getter to SamplerBase. A filtering sampler must\nnot be used with a non-filtering sampler binding.\n\nLastly, the CL reflects sampler/texture pairs from Tint and validates\nan entrypoint against the pipeline layout that a filtering sampler is\nnot used with an unfilterable-float texture binding.\n\nBug: dawn:367\nChange-Id: If9f2c0d8fbad5641c2ecc30615a3c68a6ed6150a\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/56521\nReviewed-by: Jiawei Shao \u003cjiawei.shao@intel.com\u003e\nCommit-Queue: Austin Eng \u003cenga@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "b4bbfd7038218badab4ffdeaf52cd7e58581dac5",
      "old_mode": 33188,
      "old_path": "src/dawn_native/BindGroup.cpp",
      "new_id": "bc43346c5108fe6abb39449d64603b5aa8865b24",
      "new_mode": 33188,
      "new_path": "src/dawn_native/BindGroup.cpp"
    },
    {
      "type": "modify",
      "old_id": "f4a1730f143f0e3ec656be5b865cf0c5cb3218ad",
      "old_mode": 33188,
      "old_path": "src/dawn_native/BindingInfo.h",
      "new_id": "0d6cfc02ae3cb2aad3f0208bc09879aee55bceb6",
      "new_mode": 33188,
      "new_path": "src/dawn_native/BindingInfo.h"
    },
    {
      "type": "modify",
      "old_id": "0bebc18e5857c13e2c2446b113514cab450eec67",
      "old_mode": 33188,
      "old_path": "src/dawn_native/Format.cpp",
      "new_id": "a60d3b94e6d547939e38d14c282d94542f926e99",
      "new_mode": 33188,
      "new_path": "src/dawn_native/Format.cpp"
    },
    {
      "type": "modify",
      "old_id": "01457d1369e4bb9e829c5910b55f0a6867168708",
      "old_mode": 33188,
      "old_path": "src/dawn_native/Format.h",
      "new_id": "2708d04ba69ea50d6431c0b78ac3794f5fb8986b",
      "new_mode": 33188,
      "new_path": "src/dawn_native/Format.h"
    },
    {
      "type": "modify",
      "old_id": "52e2008f423f8524aeca054dcbd82dcf1e24d430",
      "old_mode": 33188,
      "old_path": "src/dawn_native/PipelineLayout.cpp",
      "new_id": "9a4b3a5990d3f638cb01de7e6c01c9785737c843",
      "new_mode": 33188,
      "new_path": "src/dawn_native/PipelineLayout.cpp"
    },
    {
      "type": "modify",
      "old_id": "51db0805f543c315c8d910a45050674fc700df35",
      "old_mode": 33188,
      "old_path": "src/dawn_native/Sampler.cpp",
      "new_id": "1637b16da7bcfeb1a55bf55c5b1257dbd120e76a",
      "new_mode": 33188,
      "new_path": "src/dawn_native/Sampler.cpp"
    },
    {
      "type": "modify",
      "old_id": "2fd938c15402e7d8b51b9b256ca54740018e7f12",
      "old_mode": 33188,
      "old_path": "src/dawn_native/Sampler.h",
      "new_id": "aa74966e48833373b28175cda9d672d6b41a324d",
      "new_mode": 33188,
      "new_path": "src/dawn_native/Sampler.h"
    },
    {
      "type": "modify",
      "old_id": "18c8cb13bb79024bf8db78b7bb896af5016ee66a",
      "old_mode": 33188,
      "old_path": "src/dawn_native/ShaderModule.cpp",
      "new_id": "e201251ed31bade3e479d1a14e7ccb59a472bd28",
      "new_mode": 33188,
      "new_path": "src/dawn_native/ShaderModule.cpp"
    },
    {
      "type": "modify",
      "old_id": "d39d4640552b6d5f0cb23653e7ed5f8ab75be81b",
      "old_mode": 33188,
      "old_path": "src/dawn_native/ShaderModule.h",
      "new_id": "dd3d34a99328fc2a7372ad59ab2457979adfe33b",
      "new_mode": 33188,
      "new_path": "src/dawn_native/ShaderModule.h"
    },
    {
      "type": "modify",
      "old_id": "fafd6c2247552fcd5014a1484a923a5f0532f3e2",
      "old_mode": 33188,
      "old_path": "src/dawn_native/SpirvUtils.cpp",
      "new_id": "9472508c3822290a138f732b4a0251f8802696e8",
      "new_mode": 33188,
      "new_path": "src/dawn_native/SpirvUtils.cpp"
    },
    {
      "type": "modify",
      "old_id": "9ed94a5f8d3fb2f52add77c08a9ae0456c1eb203",
      "old_mode": 33188,
      "old_path": "src/dawn_native/SpirvUtils.h",
      "new_id": "158b165e7cf2bd436502373d133812f82b467526",
      "new_mode": 33188,
      "new_path": "src/dawn_native/SpirvUtils.h"
    },
    {
      "type": "modify",
      "old_id": "08ce0590c316977ba67c376b6391c732c0ddcdfd",
      "old_mode": 33188,
      "old_path": "src/tests/end2end/CopyTextureForBrowserTests.cpp",
      "new_id": "1ca8ea47e94b432fc249f5a74b342b7424b4db39",
      "new_mode": 33188,
      "new_path": "src/tests/end2end/CopyTextureForBrowserTests.cpp"
    },
    {
      "type": "modify",
      "old_id": "ad727c30a8db3319174d6af991792ed78b567625",
      "old_mode": 33188,
      "old_path": "src/tests/end2end/DepthStencilSamplingTests.cpp",
      "new_id": "461fa00db61b6cee3a3470c6680f2936c976a61f",
      "new_mode": 33188,
      "new_path": "src/tests/end2end/DepthStencilSamplingTests.cpp"
    },
    {
      "type": "modify",
      "old_id": "04f62dccdc8c3dd01c4ae7a47412edc33a5c0fe7",
      "old_mode": 33188,
      "old_path": "src/tests/unittests/validation/BindGroupValidationTests.cpp",
      "new_id": "b6031dd80ebdb4917c0d05dc4aa373f7447ca492",
      "new_mode": 33188,
      "new_path": "src/tests/unittests/validation/BindGroupValidationTests.cpp"
    },
    {
      "type": "modify",
      "old_id": "13d4ddd83972fa999f133e8253c053c09d32169e",
      "old_mode": 33188,
      "old_path": "src/tests/unittests/validation/GetBindGroupLayoutValidationTests.cpp",
      "new_id": "51ba72d8a59b0509de82dec353bcda98bcaa4359",
      "new_mode": 33188,
      "new_path": "src/tests/unittests/validation/GetBindGroupLayoutValidationTests.cpp"
    }
  ]
}