commit a6788bdfee90a790c2e4991ba795e2a8a61635eb
author Ben Clayton <bclayton@google.com> Thu May 23 23:19:52 2024 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu May 23 23:19:52 2024 +0000
tree b0cea515dbad8e16cee2b5f9d064839fe02b82f3
parent dff37c4f88943033d2b0f95b5a1834b35dbb29d4

[tint][core] Test that OOB Splat::Index() returns nullptr

This got dropped with:
https://dawn-review.googlesource.com/c/dawn/+/189123

Change-Id: Id3dca0cc0520ee94c65070e27d2d4c29de81c8b2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/189714
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>

src/tint/lang/core/constant/splat_test.cc

diff --git a/src/tint/lang/core/constant/splat_test.cc b/src/tint/lang/core/constant/splat_test.cc
index 553cf14..10c67f2 100644
--- a/src/tint/lang/core/constant/splat_test.cc
+++ b/src/tint/lang/core/constant/splat_test.cc
@@ -80,6 +80,7 @@
     ASSERT_NE(sp->Index(0), nullptr);
     ASSERT_NE(sp->Index(1), nullptr);
     ASSERT_NE(sp->Index(2), nullptr);
+    EXPECT_EQ(sp->Index(3), nullptr);
 
     EXPECT_EQ(sp->Index(0)->As<Scalar<f32>>()->ValueOf(), 1.f);
     EXPECT_EQ(sp->Index(1)->As<Scalar<f32>>()->ValueOf(), 1.f);
@@ -95,6 +96,7 @@
     constant::CloneContext ctx{core::type::CloneContext{{nullptr}, {nullptr, &mgr.types}}, mgr};
 
     auto* r = sp->Clone(ctx);
+    EXPECT_NE(r, sp);
     ASSERT_NE(r, nullptr);
     EXPECT_TRUE(r->type->Is<core::type::Vector>());
     EXPECT_TRUE(r->el->Is<Scalar<i32>>());