tree 81495508f4a39867f19a0f8ab7f567ae87554100
parent 71f33f2b997b836d39289e324c3a31d83552a179
author Ryan Harrison <rharrison@chromium.org> 1728064936 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1728064936 +0000

[tint][ir][val] Enforce entry point returns have location or builtin

Specifically when the return is non-void

This CL also changes some of the `CheckFunction` behaviour to not exit
early within this method for non-functional errors, i.e. if something
is null that will cause a segfault later still exit early, but if this
issue justr IR semantics like missing a decoration let the calling
code handle exiting.

This was done to make it somewhat easier to reason about what this
function was doing, since the early exit behaviour meant that the
order of checks affected the flow control in non-obvious ways.

This does introduce at least one instance of 'duplicate' errors,
i.e. a more general and specific error both being logged, but I have
filed a follow up issue (https://issues.chromium.org/issues/371219657)
about going through a proper refactoring of this function, since it is
broadly too complex as it is.

Fixes: 369813099

Change-Id: I4891db07cbad2dc0812b41ac2186ad9ba80d2648
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/209414
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: James Price <jrprice@google.com>
Reviewed-by: James Price <jrprice@google.com>