)]}' { "commit": "a8ce0a434e12990eaac11312998237a4249f2e44", "tree": "a7d0531ff2f30654e468b10180e31312732819b1", "parents": [ "1c92c159adf995b450275de69407625328bb2796" ], "author": { "name": "Jiawei Shao", "email": "jiawei.shao@intel.com", "time": "Mon Mar 04 01:31:38 2019 +0000" }, "committer": { "name": "Commit Bot service account", "email": "commit-bot@chromium.org", "time": "Mon Mar 04 01:31:38 2019 +0000" }, "message": "Add validation on the creation of 4x Multisampled textures\n\nThis patch adds validations on the creation of the multisampled textures\nwith sampleCount \u003d\u003d 4. The validations include:\n1. Only accept 1 or 4 as valid value of sampleCount.\n2. According to Vulkan SPEC, when sampleCount \u003e 1:\n- The value of mipLevelCount can only be 1\n- We cannot create cube map or cube map array texture views on this\n texture.\n\nBUG\u003ddawn:56\nTEST\u003ddawn_unittests\n\nChange-Id: Iac7cbe7cd7af16216b9185afd37a80eef0712f6b\nReviewed-on: https://dawn-review.googlesource.com/c/5160\nCommit-Queue: Jiawei Shao \u003cjiawei.shao@intel.com\u003e\nReviewed-by: Kai Ninomiya \u003ckainino@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "a97536ade41618251d991500038b499a4a41e1b4", "old_mode": 33188, "old_path": "src/dawn_native/Texture.cpp", "new_id": "5d21ad6b2d67d39d897f99f9af1dc2bac33e9bee", "new_mode": 33188, "new_path": "src/dawn_native/Texture.cpp" }, { "type": "modify", "old_id": "d7dd6d3f531eb7118de8df6757f568c7be47428b", "old_mode": 33188, "old_path": "src/dawn_native/Texture.h", "new_id": "0c0222a9b7056188cce3e155b9fa322b56ce9406", "new_mode": 33188, "new_path": "src/dawn_native/Texture.h" }, { "type": "modify", "old_id": "28743c37bdf06a4e96f67cc14e2bebe5a2833676", "old_mode": 33188, "old_path": "src/tests/unittests/validation/TextureValidationTests.cpp", "new_id": "dce5af18bb56ecb7d4bdf862707239e0ce02a252", "new_mode": 33188, "new_path": "src/tests/unittests/validation/TextureValidationTests.cpp" }, { "type": "modify", "old_id": "9d8c31a5b87ef6eed10c1be51b17589e30136c3a", "old_mode": 33188, "old_path": "src/tests/unittests/validation/TextureViewValidationTests.cpp", "new_id": "b33060064c53180f95edf7151ce44edc38c4b8cb", "new_mode": 33188, "new_path": "src/tests/unittests/validation/TextureViewValidationTests.cpp" } ] }