)]}' { "commit": "a942e5364cd25a693ac09ecf74a2eaea65db0ecb", "tree": "f1e3313769e049758936f31c8fc5480d645d9d18", "parents": [ "9a1aa91f55eb654995acba23bfdda565896c629b" ], "author": { "name": "Kai Ninomiya", "email": "kainino@chromium.org", "time": "Thu Oct 16 14:08:32 2025 -0700" }, "committer": { "name": "Dawn LUCI CQ", "email": "dawn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Oct 16 14:08:32 2025 -0700" }, "message": "Revert \"[dawn][wire] Handle command chunking in the wire in more robustly.\"\n\nThis reverts commit 11b115b26569c8aa46781b4dac589ce17f5d6c89.\n\nReason for revert: Fuzzer crash https://crbug.com/452575709\n\nOriginal change\u0027s description:\n\u003e [dawn][wire] Handle command chunking in the wire in more robustly.\n\u003e\n\u003e - With the changes to make the wire more spontaneous, chunked\n\u003e command serialization and handling need to be updated to work\n\u003e in a multithreaded manner. Previously, the handler assumes that\n\u003e once a chunked command is received, it will receive the entire\n\u003e chunked command before it receives any other commands. This may\n\u003e no longer be true, so we upgrade chunked commands into its own\n\u003e command so with unique id\u0027s to ensure that we handle them\n\u003e appropriately.\n\u003e - This change also unifies the command id enums in the wire to a\n\u003e single enum since chunked command handling may occur on both\n\u003e the server and the client (though in practice in Chromium,\n\u003e only the server-\u003eclient may be multithreaded for now.) This\n\u003e allows us to handle commands in a unified way and also ensures\n\u003e that the command ids are now unique both direction.\n\u003e\n\u003e Bug: 412761856\n\u003e Change-Id: Ia1eb34d57c2e2fe0457c70aae9348bc051fce573\n\u003e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/266475\n\u003e Reviewed-by: Corentin Wallez \u003ccwallez@chromium.org\u003e\n\u003e Reviewed-by: Kai Ninomiya \u003ckainino@chromium.org\u003e\n\u003e Commit-Queue: Loko Kung \u003clokokung@google.com\u003e\n\nTBR\u003dcwallez@chromium.org,kainino@chromium.org,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com,lokokung@google.com\n\nFixed: 452575709\nBug: 412761856\nChange-Id: I02915daf7e8d35729e3afdb9425ce6a51679958f\nReviewed-on: https://dawn-review.googlesource.com/c/dawn/+/267254\nBot-Commit: rubber-stamper@appspot.gserviceaccount.com \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nCommit-Queue: rubber-stamper@appspot.gserviceaccount.com \u003crubber-stamper@appspot.gserviceaccount.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "dd55164ccc443078ee4fbee89db2ed5aff246a19", "old_mode": 33188, "old_path": "generator/dawn_json_generator.py", "new_id": "4bd67574e3010359e90af8cd623a36fcad2e4410", "new_mode": 33188, "new_path": "generator/dawn_json_generator.py" }, { "type": "modify", "old_id": "97149525fbedd9de9db90980f0232c070cd1b501", "old_mode": 33188, "old_path": "generator/templates/dawn/wire/WireCmd.cpp", "new_id": "f12db7f6e62bd961a30d1c2db6513920bf1833e8", "new_mode": 33188, "new_path": "generator/templates/dawn/wire/WireCmd.cpp" }, { "type": "modify", "old_id": "bd42e2af1f84c9c0240b0fb6628aab05a7b1867c", "old_mode": 33188, "old_path": "generator/templates/dawn/wire/WireCmd.h", "new_id": "ba1542a23d53561ccff89a097966fc707b0d45b2", "new_mode": 33188, "new_path": "generator/templates/dawn/wire/WireCmd.h" }, { "type": "modify", "old_id": "5c741fcf8bac9f00d6b7429d2065a751bcd27b42", "old_mode": 33188, "old_path": "generator/templates/dawn/wire/client/ClientHandlers.cpp", "new_id": "dc32d845f55184e9a9dd409a7b4e6ee834f529cb", "new_mode": 33188, "new_path": "generator/templates/dawn/wire/client/ClientHandlers.cpp" }, { "type": "modify", "old_id": "576a0a32fa7f39f1f81bffff58d0d4d785298213", "old_mode": 33188, "old_path": "generator/templates/dawn/wire/client/ClientPrototypes.inc", "new_id": "12907e129fc0e578da9adc5ccb29399cb87da0b5", "new_mode": 33188, "new_path": "generator/templates/dawn/wire/client/ClientPrototypes.inc" }, { "type": "modify", "old_id": "57876a21824426772a66bee9904c57e15c560885", "old_mode": 33188, "old_path": "generator/templates/dawn/wire/server/ServerHandlers.cpp", "new_id": "c954823421d2e3d77c2d1ce9c23b1c1b07335519", "new_mode": 33188, "new_path": "generator/templates/dawn/wire/server/ServerHandlers.cpp" }, { "type": "modify", "old_id": "7cdc7c3e22c54d13a8757da832cd2c71c4f674eb", "old_mode": 33188, "old_path": "generator/templates/dawn/wire/server/ServerPrototypes.inc", "new_id": "f7404df04bf8aed3eb408f2151a71dee6ada3bf2", "new_mode": 33188, "new_path": "generator/templates/dawn/wire/server/ServerPrototypes.inc" }, { "type": "modify", "old_id": "0fd2c0159e8b2874b7d4972909d77fa3245cbdbe", "old_mode": 33188, "old_path": "src/dawn/dawn_wire.json", "new_id": "ad848fd1643d1d1510144ca5500d41ebdfd5b6ac", "new_mode": 33188, "new_path": "src/dawn/dawn_wire.json" }, { "type": "modify", "old_id": "aab12c698f3c225f4aa87cc93152e2bc1c4d95c2", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/wire/WireQueueTests.cpp", "new_id": "1751551bf01d7b738cf75c2a807e0301e3006d83", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/wire/WireQueueTests.cpp" }, { "type": "modify", "old_id": "41ef35466022603ffa24a9fbfe8e5e8bb722573b", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/wire/WireTest.cpp", "new_id": "3d6020446666d939002d191ac1e3ef9d704643a2", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/wire/WireTest.cpp" }, { "type": "modify", "old_id": "ab62ea6ef74d67021d911a3899074431fbc0c162", "old_mode": 33188, "old_path": "src/dawn/tests/unittests/wire/WireTest.h", "new_id": "41fdbaceec19127bf36124b8c827aa8530e82cc9", "new_mode": 33188, "new_path": "src/dawn/tests/unittests/wire/WireTest.h" }, { "type": "modify", "old_id": "5f23cb1770f5e46925d4a44646bfc705b0566cd4", "old_mode": 33188, "old_path": "src/dawn/wire/ChunkedCommandHandler.cpp", "new_id": "aa3de33aa8e0f71dba68491a62a3c704a5a2d8bc", "new_mode": 33188, "new_path": "src/dawn/wire/ChunkedCommandHandler.cpp" }, { "type": "modify", "old_id": "050c81365ded19ef5902d4cd22490e2d16a55fa7", "old_mode": 33188, "old_path": "src/dawn/wire/ChunkedCommandHandler.h", "new_id": "d5ab08e01d63e17dec7eb3d4a59464740b8a477d", "new_mode": 33188, "new_path": "src/dawn/wire/ChunkedCommandHandler.h" }, { "type": "modify", "old_id": "51de9d5838844dd1f47e4985a540ed8e120585d3", "old_mode": 33188, "old_path": "src/dawn/wire/ChunkedCommandSerializer.cpp", "new_id": "f30649568eaa984e537caebf7970a54afae78a66", "new_mode": 33188, "new_path": "src/dawn/wire/ChunkedCommandSerializer.cpp" }, { "type": "modify", "old_id": "bc15d5072ab9d261fb324bb284f891576ad03b67", "old_mode": 33188, "old_path": "src/dawn/wire/ChunkedCommandSerializer.h", "new_id": "61943158d9b1d45331bdf6dfaacd192de7c0b145", "new_mode": 33188, "new_path": "src/dawn/wire/ChunkedCommandSerializer.h" }, { "type": "modify", "old_id": "f3e12b1ebed4dbba45064f9424eaf2c9e6c79ae6", "old_mode": 33188, "old_path": "src/dawn/wire/client/Client.cpp", "new_id": "6d7c7ad5b3f5ae73646cc50924d9bb8a1981ec4e", "new_mode": 33188, "new_path": "src/dawn/wire/client/Client.cpp" }, { "type": "modify", "old_id": "1406fa49982d505ac2233241ef7b02d90d2c3c4f", "old_mode": 33188, "old_path": "src/dawn/wire/client/Client.h", "new_id": "3732454fe9caf8056b4a430000e625b2cf7c1a8f", "new_mode": 33188, "new_path": "src/dawn/wire/client/Client.h" }, { "type": "modify", "old_id": "6ded5678d4d0a641434d8fa91b3442cab6a9ddaa", "old_mode": 33188, "old_path": "src/dawn/wire/server/Server.h", "new_id": "a8896b49a61ffeb006c10549abc31ab72bef2b02", "new_mode": 33188, "new_path": "src/dawn/wire/server/Server.h" } ] }